From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E99A1C3ABD8 for ; Fri, 16 May 2025 20:24:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=wK+kLL3ofBUa9HVa+9T566UL4xro0DCdbR7BZ4cxWTE=; b=d05OVbAvx+OwcL6cy43FG/hCJQ N7Ae8qutiBYOV5BcvZ/qLB+L+mkRhHoc5BYBBDnMHcGfHfC07d+dUxFTyFBq70meWqL9ukosLszAA jxIr2/3zhY1lNa4k9ayeLbvkNJ/hc5wtRGs9niN8gv41qj+3VVouvK1zeq2BERqF/1aJ2yN2FxpoJ aFhGaTgMuXp4WZXqfE2MU4ufCzmPNaJ7lc1Q2SOfWPKNrZ7/pYCAtQf99zx/WVXF5op0bPYlzs3vf NHvxl1Uke8U1KOTZ/KscVXm+9qXLWs/43wW9IRY39AQ1WRGeNL04QrGLSwmEtc7osUIo+yQMSho7+ nuZ22MSA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uG1bd-00000004Yuh-068J; Fri, 16 May 2025 20:24:33 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uG1Ua-00000004Y4X-2lK3; Fri, 16 May 2025 20:17:17 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id D8CC05C024A; Fri, 16 May 2025 20:14:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8C9B1C4CEE4; Fri, 16 May 2025 20:17:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1747426635; bh=gdghEq68rS4dPfk9w/Dn9+8ctElaEIgaJKGdi8w2LsI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cC+TjSS/6y17tbIKaZGsUJoPoCD1aU/C16eEMGQPyvJ9FM3znQC7DENjYVkdt70Jh aFOIkPu/qJkm3eWmq1rZ2IciIRicDngFiXU/dDFBxngh3y8GA6Wvms3mKF9TBmdNFZ 6Ip4GISVjxFV4aqS7OtJ3OWKMATh3yfxhYQfPgtaJF3bvXCNoXjFNAWo1/jWsdwbOj PKDyYPwhzcuV8TMg9FkaF8jKMQ6Ph4dVqc7AAl881N/gOMY4aLKf74zn5KFQuQnZ5a mlhX1lzFp+/ApepbLqGVDxBdxj0XGVweXkfe4TRVDRA5JOcUHIvUX7elCJNqi29r4C fXGzduw+HA5kg== Date: Fri, 16 May 2025 21:17:11 +0100 From: Simon Horman To: Lorenzo Bianconi Cc: Christophe JAILLET , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, netdev@vger.kernel.org Subject: Re: [PATCH v3 1/4] net: airoha: Fix an error handling path in airoha_alloc_gdm_port() Message-ID: <20250516201711.GK3339421@horms.kernel.org> References: <5c94b9b345017f29ed653e2f05d25620d128c3f0.1746715755.git.christophe.jaillet@wanadoo.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250516_131716_738569_D25C98B1 X-CRM114-Status: GOOD ( 11.54 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Thu, May 15, 2025 at 11:16:56PM +0200, Lorenzo Bianconi wrote: > > If register_netdev() fails, the error handling path of the probe will not > > free the memory allocated by the previous airoha_metadata_dst_alloc() call > > because port->dev->reg_state will not be NETREG_REGISTERED. > > > > So, an explicit airoha_metadata_dst_free() call is needed in this case to > > avoid a memory leak. > > > > Fixes: af3cf757d5c9 ("net: airoha: Move DSA tag in DMA descriptor") > > Signed-off-by: Christophe JAILLET > > Acked-by: Lorenzo Bianconi Reviewed-by: Simon Horman