From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 13A79C54ED0 for ; Thu, 22 May 2025 16:27:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=hDrRfxUh05bF14pzZXQ+mC3f/tIJuaPORyh0q5iuGpM=; b=2UcrI+sw4B33ppNPjISDE4gBPR C2awOy3Wx9NN2kf8/iZ95EqGg62iF2i3ZaT3CQ9M4HOJLNRyFSQV0SoYSxayx1duVMg3duASOmP+h C6wGj/ChK1bheKLZV8cRQWeFzb9/F+/wPfzbqlk7gAeYH6WAw3t3QJKfRd4ottjf6/DBX5v5t8XCq Prbp7THdJHiLOkqwn3SaELgu75LLpV6AtOeVkXX4sgWfBPxyIs26yFVu7a/myy+CMyaW0eAzDIroM mKksaUwW51ZQ2VIG16y5NqcCSE07SSGtgLsmttEjt9AcFWW0CUTTdznGozJwxXs3durnKaxTftcDt SQNEfsbA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uI8lw-00000001Z2N-38I2; Thu, 22 May 2025 16:27:57 +0000 Received: from relay6-d.mail.gandi.net ([2001:4b98:dc4:8::226]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uI8Hi-00000001W1M-2tHJ; Thu, 22 May 2025 15:56:45 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id 62288439A5; Thu, 22 May 2025 15:56:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1747929396; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hDrRfxUh05bF14pzZXQ+mC3f/tIJuaPORyh0q5iuGpM=; b=LrOFkxjDWfPYlaJ27v0bKylFL4XWO+4kvvgStRLZlUDRYZHdyChNIb2pfDuGENtsuftdv/ wGbOCWfZtxzREyaEFwnH82wXULSKdAdYw/PBXzq/zAP46MQh+2qKay6Pd/jwy3zwxJN8dw rgJTGQYyYqHyrBnB5+bbAyyUPyuK4SQmrz1l5b6bKlFTJX3baN6Ej14byKnrUchMCQnb3+ vJDkRIAED2cQX+6NzREg8KVZNhwI6WQ0582mb8M9FYZVQz3yCa/TIqtPexDE/d9Fb/Krsm aRFHR6fwOi/MpKAjV481sgJjj5EABYXpHVIjb+acU9Q+t95PRAEbZnkSC880OA== Date: Thu, 22 May 2025 17:56:23 +0200 From: Luca Ceresoli To: Maxime Ripard Cc: Maarten Lankhorst , Thomas Zimmermann , David Airlie , Simona Vetter , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Jagan Teki , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Douglas Anderson , Chun-Kuang Hu , Krzysztof Kozlowski , Liu Ying , Anusha Srivatsa , Paul Kocialkowski , Dmitry Baryshkov , Hui Pu , Thomas Petazzoni , dri-devel@lists.freedesktop.org, asahi@lists.linux.dev, linux-kernel@vger.kernel.org, chrome-platform@lists.linux.dev, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-renesas-soc@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-stm32@st-md-mailman.stormreply.com, Louis Chauvet , Alim Akhtar , Inki Dae , Kyungmin Park , Seung-Woo Kim , Manikandan Muralidharan , Adam Ford , Adrien Grassein , Aleksandr Mishin , Andy Yan , AngeloGioacchino Del Regno , Benson Leung , Biju Das , Christoph Fritz , Cristian Ciocaltea , Detlev Casanova , Dharma Balasubiramani , Guenter Roeck , Heiko Stuebner , Jani Nikula , Janne Grunau , Jerome Brunet , Jesse Van Gavere , Kevin Hilman , Kieran Bingham , Martin Blumenstingl , Matthias Brugger , Philipp Zabel , Phong LE , Sasha Finkelstein , Sugar Zhang , Sui Jingfeng , Tomi Valkeinen , Vitalii Mordan , "Rob Herring (Arm)" , Hsin-Te Yuan , Pin-yen Lin , Xin Ji , Aradhya Bhatia , Tomi Valkeinen , Ian Ray , Martyn Welch , Peter Senna Tschudin , Helge Deller , Kuninori Morimoto , Laurent Pinchart , Alexandre Torgue , Maxime Coquelin , Philippe Cornu , Raphael Gallais-Pou , Yannick Fertre , Alain Volmat , Raphael Gallais-Pou , Michal Simek , Jonathan Corbet , linux-doc@vger.kernel.org Subject: Re: [PATCH v3 00/22] drm: convert all bridges to devm_drm_bridge_alloc() Message-ID: <20250522175623.1a6d9b14@booty> In-Reply-To: <20250522-amphibian-shiny-chachalaca-cf05ba@houat> References: <20250509-drm-bridge-convert-to-alloc-api-v3-0-b8bc1f16d7aa@bootlin.com> <20250521162216.79dd3290@booty> <20250522-amphibian-shiny-chachalaca-cf05ba@houat> Organization: Bootlin X-Mailer: Claws Mail 4.3.1 (GTK 3.24.49; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtddtgdeifeejucdltddurdegfedvrddttddmucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpeffhffvvefukfgjfhhoofggtgfgsehtjeertdertddvnecuhfhrohhmpefnuhgtrgcuvegvrhgvshholhhiuceolhhutggrrdgtvghrvghsohhlihessghoohhtlhhinhdrtghomheqnecuggftrfgrthhtvghrnhepgfejhffgjeelkeeftdekfefgteekgefhleelueeijeffieekieeigefhledtffetnecuffhomhgrihhnpehkvghrnhgvlhdrohhrghdpfhhrvggvuggvshhkthhophdrohhrghdpsghoohhtlhhinhdrtghomhenucfkphepvdgrtddvmeeijedtmedvtddvtdemvggrtddumegsvgegudemleehvgejmeefgeefmeeludefvgenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpedvrgdtvdemieejtdemvddtvddtmegvrgdtudemsggvgedumeelhegvjeemfeegfeemledufegvpdhhvghlohepsghoohhthidpmhgrihhlfhhrohhmpehluhgtrgdrtggvrhgvshholhhisegsohhothhlihhnrdgtohhmpdhnsggprhgtphhtthhopeelhedprhgtphhtthhopehmrhhiphgrrhgusehkvghrnhgvlhdrohhrghdprhgtphhtthhopehmrggrrhhtvghnrdhlrghnkhhho hhrshhtsehlihhnuhigrdhinhhtvghlrdgtohhmpdhrtghpthhtohepthiiihhmmhgvrhhmrghnnhesshhushgvrdguvgdprhgtphhtthhopegrihhrlhhivggusehgmhgrihhlrdgtohhmpdhrtghpthhtohepshhimhhonhgrsehffhiflhhlrdgthhdprhgtphhtthhopegrnhgurhiivghjrdhhrghjuggrsehinhhtvghlrdgtohhmpdhrtghpthhtohepnhgvihhlrdgrrhhmshhtrhhonhhgsehlihhnrghrohdrohhrghdprhgtphhtthhopehrfhhoshhssehkvghrnhgvlhdrohhrgh X-GND-Sasl: luca.ceresoli@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250522_085643_860270_AE9EE2DF X-CRM114-Status: GOOD ( 34.53 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hi Maxime, On Thu, 22 May 2025 16:57:30 +0200 Maxime Ripard wrote: [...] > > As the commit was a mistake, I'm applying the revert by the end of this > > week (i.e. on Friday) unless there are better instructions. > > Given the lack of answers, and that it looks correct to me, just leave > it there. We can always revert later on if things turned out to be > broken. OK, I'll leave the commit and drop the revert in v4. > > > drm: convert many bridge drivers from devm_kzalloc() to devm_drm_bridge_alloc() API > > > > This patch affects multiple drivers. Running get_maintainers.pl > > points at Shawn Guo's repository. After reviewing the MAINTAINERS file, > > this looks like due to the 'N:' line in: > > > > ARM/FREESCALE IMX / MXC ARM ARCHITECTURE > > M: Shawn Guo > > M: Sascha Hauer > > R: Pengutronix Kernel Team > > ... > > T: git git://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git > > N: imx > > ... > > > > (https://gitlab.freedesktop.org/drm/misc/kernel/-/blob/drm-misc-next/MAINTAINERS?ref_type=heads#L2511-2528) > > > > Here 'imx' matches the 'drivers/gpu/drm/bridge/imx/imx-legacy-bridge.c' > > file that is touched by the patch. That regexp appears overly generic to me. > > I agree, or at least, we shouldn't wait for Shawn or Sasha... > > > Shawn, can it be fixed by making it less generic? > > > > If not, can we at least add a band-aid 'X:' entry for > > drivers/gpu/drm/bridge/imx? > > > > I think the other matching entry is the one to consider: > > > > DRM DRIVERS FOR FREESCALE IMX BRIDGE > > M: Liu Ying > > L: dri-devel@lists.freedesktop.org > > S: Maintained > > F: Documentation/devicetree/bindings/display/bridge/fsl,imx8qxp-ldb.yaml > > F: Documentation/devicetree/bindings/display/bridge/fsl,imx8qxp-pixel-combiner.yaml > > F: Documentation/devicetree/bindings/display/bridge/fsl,imx8qxp-pixel-link.yaml > > F: Documentation/devicetree/bindings/display/bridge/fsl,imx8qxp-pxl2dpi.yaml > > F: drivers/gpu/drm/bridge/imx/ > > > > (https://gitlab.freedesktop.org/drm/misc/kernel/-/blob/drm-misc-next/MAINTAINERS?ref_type=heads#L7940-7948) > > ... As long as Ying is fine with it, because it does look like they are > the actual maintainer. Ack, thanks for confirming this. Bottom line, given that large patch has your Acked-by, and given the shawnguo repo was ruled out, the conclusion is it can apply it to drm-misc-next. Having that large patch applied will be relieving me a lot! I think next time I'm going to split any imilar change in per-driver patches, even if it is spatch-automated. > > > drm/todo: add entry to remove devm_drm_put_bridge() > > > > This involves documentation maintained on another tree. Where should it > > be applied? There are two matching entries in MAINTAINERS: > > > > * DRM DRIVERS -> the drm tree > > * DRM DRIVERS AND MISC GPU PATCHES -> the drm-misc tree > > > > To me it looks like the second is obviously the closest match as we are > > dealing with DRM bridges, so I'm applying this as well on Friday unless > > there are better instructions. > > Yes, they should be applied to drm-misc. OK, will do soon. > That being said, putting a two days timeout on *any* email is really > over-the-top. I doubt you reply to any of your mail in such a short > timeframe. We have rules for a reason, I'd expect you to follow them, no > matter how frustrating the lack of answers can be. Apologies if that was too much. I was indeed nervous about the revert. A patch got applied by mistake and I believe it should have been reverted very quickly, if need be. Both Louis and I didn't want to break the process again. So we asked, but not having answer after 2+ weeks I must admit I got a bit nervous about it. Sorry about that and thanks for the feedback about my questions. Luca -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com