Linux-mediatek Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Kyrie Wu <kyrie.wu@mediatek.com>
To: Hans Verkuil <hverkuil-cisco@xs4all.nl>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>,
	Kyrie Wu <kyrie.wu@mediatek.com>, <linux-media@vger.kernel.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-mediatek@lists.infradead.org>
Cc: <srv_heupstream@mediatek.com>
Subject: [PATCH v5 12/12] media: mediatek: jpeg: fix remove buffer operation for multi-core
Date: Fri, 30 May 2025 15:45:37 +0800	[thread overview]
Message-ID: <20250530074537.26338-13-kyrie.wu@mediatek.com> (raw)
In-Reply-To: <20250530074537.26338-1-kyrie.wu@mediatek.com>

move remove buffer code to spinlock protect area for multi-core

Signed-off-by: Kyrie Wu <kyrie.wu@mediatek.com>
---
 drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c b/drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c
index eba9f58b9198..34fa03bcfdd3 100644
--- a/drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c
+++ b/drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c
@@ -1684,9 +1684,6 @@ static void mtk_jpegenc_worker(struct work_struct *work)
 		goto enc_end;
 	}
 
-	v4l2_m2m_src_buf_remove(ctx->fh.m2m_ctx);
-	v4l2_m2m_dst_buf_remove(ctx->fh.m2m_ctx);
-
 	schedule_delayed_work(&comp_jpeg[hw_id]->job_timeout_work,
 			      msecs_to_jiffies(MTK_JPEG_HW_TIMEOUT_MSEC));
 
@@ -1707,6 +1704,8 @@ static void mtk_jpegenc_worker(struct work_struct *work)
 			     &src_buf->vb2_buf);
 	mtk_jpeg_set_enc_params(ctx, comp_jpeg[hw_id]->reg_base);
 	mtk_jpeg_enc_start(comp_jpeg[hw_id]->reg_base);
+	v4l2_m2m_src_buf_remove(ctx->fh.m2m_ctx);
+	v4l2_m2m_dst_buf_remove(ctx->fh.m2m_ctx);
 	jpeg_buf_queue_inc(ctx);
 	v4l2_m2m_job_finish(jpeg->m2m_dev, ctx->fh.m2m_ctx);
 	spin_unlock_irqrestore(&comp_jpeg[hw_id]->hw_lock, flags);
@@ -1803,9 +1802,6 @@ static void mtk_jpegdec_worker(struct work_struct *work)
 		goto dec_end;
 	}
 
-	v4l2_m2m_src_buf_remove(ctx->fh.m2m_ctx);
-	v4l2_m2m_dst_buf_remove(ctx->fh.m2m_ctx);
-
 	mtk_jpeg_set_dec_src(ctx, &src_buf->vb2_buf, &bs);
 	if (mtk_jpeg_set_dec_dst(ctx,
 				 &jpeg_src_buf->dec_param,
@@ -1833,6 +1829,8 @@ static void mtk_jpegdec_worker(struct work_struct *work)
 				jpeg_src_buf->bs_size,
 				&bs,
 				&fb);
+	v4l2_m2m_src_buf_remove(ctx->fh.m2m_ctx);
+	v4l2_m2m_dst_buf_remove(ctx->fh.m2m_ctx);
 	mtk_jpeg_dec_start(comp_jpeg[hw_id]->reg_base);
 	jpeg_buf_queue_inc(ctx);
 	v4l2_m2m_job_finish(jpeg->m2m_dev, ctx->fh.m2m_ctx);
-- 
2.46.0



  parent reply	other threads:[~2025-05-30  8:09 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-30  7:45 [PATCH v5 00/12] Enable jpeg enc & dec multi-hardwares for MT8196 Kyrie Wu
2025-05-30  7:45 ` [PATCH v5 01/12] media: dt-bindings: mediatek,jpeg: Add mediatek, mt8196-jpgdec compatible Kyrie Wu
2025-05-30  7:45 ` [PATCH v5 02/12] media: dt-bindings: mediatek,jpeg: Add mediatek, mt8196-jpgenc compatible Kyrie Wu
2025-05-30  7:45 ` [PATCH v5 03/12] media: mediatek: jpeg: add jpeg compatible Kyrie Wu
2025-05-30  7:45 ` [PATCH v5 04/12] media: mediatek: jpeg: add jpeg smmu sid setting Kyrie Wu
2025-05-30  7:45 ` [PATCH v5 05/12] media: mediatek: jpeg: fix jpeg hw count setting Kyrie Wu
2025-05-30  7:45 ` [PATCH v5 06/12] media: mediatek: jpeg: refactor jpeg buffer payload setting Kyrie Wu
2025-05-30 17:33   ` Nicolas Dufresne
2025-06-06  2:50     ` Kyrie Wu (吴晗)
2025-05-30  7:45 ` [PATCH v5 07/12] media: mediatek: jpeg: refactor jpeg dst buffer layout Kyrie Wu
2025-05-30 17:38   ` Nicolas Dufresne
2025-06-06  2:54     ` Kyrie Wu (吴晗)
2025-05-30  7:45 ` [PATCH v5 08/12] media: mediatek: jpeg: fix stop streaming flow for multi-core Kyrie Wu
2025-05-30 17:40   ` Nicolas Dufresne
2025-06-06  3:14     ` Kyrie Wu (吴晗)
2025-05-30  7:45 ` [PATCH v5 09/12] media: mediatek: jpeg: refactor multi-core clk suspend and resume setting Kyrie Wu
2025-05-30 17:43   ` Nicolas Dufresne
2025-06-06  3:23     ` Kyrie Wu (吴晗)
2025-06-06 14:34       ` Nicolas Dufresne
2025-05-30  7:45 ` [PATCH v5 10/12] media: mediatek: jpeg: fix decoding buffer number setting timing issue Kyrie Wu
2025-05-30  7:45 ` [PATCH v5 11/12] media: mediatek: jpeg: refactor decoding resolution change operation Kyrie Wu
2025-05-30  7:45 ` Kyrie Wu [this message]
2025-05-30 17:45 ` [PATCH v5 00/12] Enable jpeg enc & dec multi-hardwares for MT8196 Nicolas Dufresne
2025-06-06  2:45   ` Kyrie Wu (吴晗)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250530074537.26338-13-kyrie.wu@mediatek.com \
    --to=kyrie.wu@mediatek.com \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=hverkuil-cisco@xs4all.nl \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=mchehab@kernel.org \
    --cc=robh@kernel.org \
    --cc=srv_heupstream@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox