From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 97D8DC77B7F for ; Wed, 25 Jun 2025 00:54:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=HlgkLB/SL2NXvDCthyFBdG5UcMQowB9KaSzVwyHfQ1k=; b=BRX6+aSlhQ3xA27YDQ1oz3mtEJ mwjmbZKH47862MFKF8hnkFGd2u1LJfikMsvm+iencgFKV+pHJEzDXz8s2SyJojDs0gDTSlti7mQ64 2t5nPbvMqdiW6K9KUUpqsqx4fI9dYyFlrYgL6m4Fcha7ibsZ3gUOeHm09K0UXdYRG9qMtU9L0tIiL undiSIpYjqA1CMH7v4BM7UV+Vv1NTcBd7y7rjlWFQrJ0AxvYJU103ofsgji89PbYapGMhKSNTgZZ7 T8wcu5RUgFLDf9KBVyxhgvUHMs84x81YdJFY6lhbF252s5L0PP15Jg+fYIa1S1PfpxN4njMcUSE2B 6QcXZh1A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uUEOp-00000007DWC-2nkZ; Wed, 25 Jun 2025 00:54:03 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uUEMO-00000007DN9-3JUr; Wed, 25 Jun 2025 00:51:34 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 028945C5553; Wed, 25 Jun 2025 00:49:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0696FC4CEE3; Wed, 25 Jun 2025 00:51:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1750812691; bh=rdyW583uKp4K8gHxquDp6eEZG0Zkfp097JbY8E5eFzU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VeOt/Pz+GybkKWK2kmcAbCiazoM8877vyJM6SUCcAislZ47f7V1+fbHBTWYDBzQPz Zd7xi+UX/cbmwB9N1I8clWHo5byqh8ECa/iVW8Y+m8MFqGPf7mLGf4MR1nl6bXZ5M4 rBOHQlBME4j45JBp8KxbstPmit9Hvl0XK0vixC79x27tWCxVry83Zljkhg+oFw5tcn tUM4GWxa+7ylJ0Kk9Vw3XRZG/tfvpCo8rejuXFv6aGftAuV64wnMk+9bG0gcITr3Pj xzPrC/1n6dtTtV/4uiFuURBJ4UV1kS4B0YCUDv8EpkhorsXQnHUX1U1YPug8W/RR6b oBJy7Z6wq5SDA== Date: Tue, 24 Jun 2025 19:51:30 -0500 From: Rob Herring To: AngeloGioacchino Del Regno Cc: lee@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, matthias.bgg@gmail.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, kernel@collabora.com Subject: Re: [PATCH v1 1/2] dt-bindings: mfd: Add binding for MediaTek MT6363 series SPMI PMIC Message-ID: <20250625005130.GA2106374-robh@kernel.org> References: <20250623120038.108891-1-angelogioacchino.delregno@collabora.com> <20250623120038.108891-2-angelogioacchino.delregno@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250623120038.108891-2-angelogioacchino.delregno@collabora.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250624_175132_913528_D518FB17 X-CRM114-Status: GOOD ( 19.62 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Mon, Jun 23, 2025 at 02:00:37PM +0200, AngeloGioacchino Del Regno wrote: > Add a binding for the MediaTek MT6363/6373 (and similar) multi > function PMICs connected over SPMI. > > These PMICs are found on board designs using newer MediaTek SoCs, > such as the Dimensity 9400 Smartphone chip, or the Chromebook > MT8196 chip. > > Signed-off-by: AngeloGioacchino Del Regno > --- > .../bindings/mfd/mediatek,mt6363.yaml | 98 +++++++++++++++++++ > 1 file changed, 98 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mfd/mediatek,mt6363.yaml > > diff --git a/Documentation/devicetree/bindings/mfd/mediatek,mt6363.yaml b/Documentation/devicetree/bindings/mfd/mediatek,mt6363.yaml > new file mode 100644 > index 000000000000..2ce57e659d12 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/mediatek,mt6363.yaml > @@ -0,0 +1,98 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/mfd/mediatek,mt6363.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: MediaTek MT6363 series SPMI PMICs multi-function device > + > +maintainers: > + - AngeloGioacchino Del Regno > + > +description: | > + Some MediaTek Power Management ICs (PMICs) found in board designs with > + the Helio, Dimensity and/or Kompanio series of SoCs are interfaced to > + the chip via the System Power Management Interface (SPMI) bus. > + > + These PMICs are multi-function devices with various sub modules. > + For example, those may include one, or more of the following: > + - Auxiliary ADC Controller > + - Clock Controller > + - eFuses > + - GPIO Controller > + - Interrupt Controller > + - Keys > + - LEDs Controller > + - Regulators > + - RTC > + > +properties: > + compatible: > + items: > + - enum: > + - mediatek,mt6363 > + - mediatek,mt6373 > + > + reg: > + maxItems: 1 > + > + '#address-cells': > + const: 0 > + > + '#size-cells': > + const: 0 > + > + interrupts: > + maxItems: 1 > + > + interrupt-controller: true > + > + "#interrupt-cells": > + const: 3 > + > + adc: > + type: object > + $ref: /schemas/iio/adc/mediatek,mt6359-auxadc.yaml# > + unevaluatedProperties: false > + > + regulators: > + type: object > + oneOf: > + - $ref: /schemas/regulator/mediatek,mt6363-regulator.yaml# > + - $ref: /schemas/regulator/mediatek,mt6373-regulator.yaml# This causes the schemas to be applied 4 times (2 each). Better if you do: properties: compatible: contains: enum: [ the compatibles in those schemas ] > + additionalProperties: true > + > + keys: > + type: object > + $ref: /schemas/input/mediatek,pmic-keys.yaml > + unevaluatedProperties: false > + > +required: > + - compatible > + - reg > + - '#address-cells' > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + > + spmi { > + #address-cells = <2>; > + #size-cells = <0>; > + > + pmic@4 { > + compatible = "mediatek,mt6363"; > + reg = <0x4 SPMI_USID>; > + interrupts = <4 64 IRQ_TYPE_LEVEL_HIGH>; > + interrupt-controller; > + #address-cells = <0>; > + #interrupt-cells = <3>; > + > + regulators { > + compatible = "mediatek,mt6363-regulator"; > + }; Make the example complete. with adc and keys nodes. > + }; > + }; > -- > 2.49.0 >