From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
To: Sergey Senozhatsky <senozhatsky@chromium.org>
Cc: Chaotian Jing <chaotian.jing@mediatek.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Masami Hiramatsu <mhiramat@kernel.org>,
Tomasz Figa <tfiga@chromium.org>,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH] mtk-sd: reset host->mrq on prepare_data() error
Date: Wed, 25 Jun 2025 17:22:56 +0900 [thread overview]
Message-ID: <20250625172256.d1b4948e018fac55e575a49a@kernel.org> (raw)
In-Reply-To: <20250625052106.584905-1-senozhatsky@chromium.org>
On Wed, 25 Jun 2025 14:20:37 +0900
Sergey Senozhatsky <senozhatsky@chromium.org> wrote:
> Do not leave host with dangling ->mrq pointer if we hit
> the msdc_prepare_data() error out path.
>
> Signed-off-by: Sergey Senozhatsky <senozhatsky@chromium.org>
Reviewed-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Thanks for fixing it.
> ---
> drivers/mmc/host/mtk-sd.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
> index b12cfb9a5e5f..d7020e06dd55 100644
> --- a/drivers/mmc/host/mtk-sd.c
> +++ b/drivers/mmc/host/mtk-sd.c
> @@ -1492,6 +1492,7 @@ static void msdc_ops_request(struct mmc_host *mmc, struct mmc_request *mrq)
> if (mrq->data) {
> msdc_prepare_data(host, mrq->data);
> if (!msdc_data_prepared(mrq->data)) {
> + host->mrq = NULL;
> /*
> * Failed to prepare DMA area, fail fast before
> * starting any commands.
> --
> 2.50.0.714.g196bf9f422-goog
>
--
Masami Hiramatsu (Google) <mhiramat@kernel.org>
next prev parent reply other threads:[~2025-06-25 9:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-12 11:26 [PATCH] mtk-sd: Prevent memory corruption from DMA map failure Masami Hiramatsu (Google)
2025-06-19 2:05 ` Masami Hiramatsu
2025-06-19 11:20 ` Ulf Hansson
2025-06-25 3:56 ` Sergey Senozhatsky
2025-06-25 4:13 ` Sergey Senozhatsky
2025-06-25 4:42 ` Masami Hiramatsu
2025-06-25 5:20 ` [PATCH] mtk-sd: reset host->mrq on prepare_data() error Sergey Senozhatsky
2025-06-25 8:22 ` Masami Hiramatsu [this message]
2025-06-25 12:45 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250625172256.d1b4948e018fac55e575a49a@kernel.org \
--to=mhiramat@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chaotian.jing@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=senozhatsky@chromium.org \
--cc=tfiga@chromium.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox