From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Cc: Andy Shevchenko <andriy.shevchenko@intel.com>, <jic23@kernel.org>,
<dlechner@baylibre.com>, <nuno.sa@analog.com>, <andy@kernel.org>,
<robh@kernel.org>, <krzk+dt@kernel.org>, <conor+dt@kernel.org>,
<matthias.bgg@gmail.com>, <linux-iio@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>, <kernel@collabora.com>
Subject: Re: [PATCH v2 4/6] iio: adc: mt6359: Move reference voltage to platform data
Date: Fri, 4 Jul 2025 10:14:41 +0100 [thread overview]
Message-ID: <20250704101441.00004cbd@huawei.com> (raw)
In-Reply-To: <cbd79481-474e-4c9f-bbe8-367917115ccd@collabora.com>
On Thu, 3 Jul 2025 16:40:38 +0200
AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> wrote:
> Il 03/07/25 16:28, Andy Shevchenko ha scritto:
> > On Thu, Jul 03, 2025 at 04:11:44PM +0200, AngeloGioacchino Del Regno wrote:
> >> In preparation to add support for new PMICs, add a `vref_mv`
> >
> > I still think that the vref_mV is a better naming.
> >
>
> Ouch, I think I missed that comment; if there's nothing else to change,
> I wonder if the capital V can be fixed while applying?
>
> Otherwise I can send a v3...
>
If that's all that comes up I'll tweak whilst applying.
J
> Cheers,
> Angelo
>
> >> the AUXADC_VOLT_FULL definition.
> >>
> >> As a consequence, the definition was also removed.
> >
>
>
next prev parent reply other threads:[~2025-07-04 11:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-03 14:11 [PATCH v2 0/6] iio: Add support for MT6363/6373 Auxiliary ADC AngeloGioacchino Del Regno
2025-07-03 14:11 ` [PATCH v2 1/6] dt-bindings: iio: adc: mt6359: Add MT6363 PMIC AuxADC AngeloGioacchino Del Regno
2025-07-03 14:11 ` [PATCH v2 2/6] dt-bindings: iio: adc: mt6359: Add MT6373 " AngeloGioacchino Del Regno
2025-07-03 14:11 ` [PATCH v2 3/6] iio: adc: mt6359: Add ready register index and mask to channel data AngeloGioacchino Del Regno
2025-07-03 14:11 ` [PATCH v2 4/6] iio: adc: mt6359: Move reference voltage to platform data AngeloGioacchino Del Regno
2025-07-03 14:28 ` Andy Shevchenko
2025-07-03 14:40 ` AngeloGioacchino Del Regno
2025-07-04 9:14 ` Jonathan Cameron [this message]
2025-07-03 14:11 ` [PATCH v2 5/6] iio: adc: mt6359: Add support for MediaTek MT6363 PMIC AUXADC AngeloGioacchino Del Regno
2025-07-03 14:11 ` [PATCH v2 6/6] iio: adc: mt6359: Add support for MediaTek MT6373 " AngeloGioacchino Del Regno
2025-07-03 14:30 ` [PATCH v2 0/6] iio: Add support for MT6363/6373 Auxiliary ADC Andy Shevchenko
2025-07-04 12:39 ` Nuno Sá
2025-07-06 10:44 ` Jonathan Cameron
2025-07-07 10:44 ` AngeloGioacchino Del Regno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250704101441.00004cbd@huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=kernel@collabora.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox