* [PATCH 0/2] watchdog: mediatek: Add compatible for MT8189
@ 2025-06-27 9:44 Zexin Wang
2025-06-27 9:44 ` [PATCH 1/2] " Zexin Wang
2025-06-27 9:44 ` [PATCH 2/2] dt-bindings: watchdog: mediatek: Add support " Zexin Wang
0 siblings, 2 replies; 5+ messages in thread
From: Zexin Wang @ 2025-06-27 9:44 UTC (permalink / raw)
To: Wim Van Sebroeck, Guenter Roeck, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Matthias Brugger
Cc: Project_Global_Chrome_Upstream_Group, linux-watchdog, devicetree,
linux-kernel, linux-arm-kernel, linux-mediatek, Zexin Wang
This patch series introduces support for the MT8189 watchdog driver
by add compatible.
Zexin Wang (2):
watchdog: mediatek: Add compatible for MT8189
dt-bindings: watchdog: mediatek: Add support for MT8189
Documentation/devicetree/bindings/watchdog/mediatek,mtk-wdt.yaml | 1 +
drivers/watchdog/mtk_wdt.c | 1 +
2 files changed, 2 insertions(+)
--
2.45.2
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/2] watchdog: mediatek: Add compatible for MT8189
2025-06-27 9:44 [PATCH 0/2] watchdog: mediatek: Add compatible for MT8189 Zexin Wang
@ 2025-06-27 9:44 ` Zexin Wang
2025-07-08 8:44 ` Krzysztof Kozlowski
2025-06-27 9:44 ` [PATCH 2/2] dt-bindings: watchdog: mediatek: Add support " Zexin Wang
1 sibling, 1 reply; 5+ messages in thread
From: Zexin Wang @ 2025-06-27 9:44 UTC (permalink / raw)
To: Wim Van Sebroeck, Guenter Roeck, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Matthias Brugger
Cc: Project_Global_Chrome_Upstream_Group, linux-watchdog, devicetree,
linux-kernel, linux-arm-kernel, linux-mediatek, Zexin Wang
Add compatible string for watchdog driver on MT8189 SoC.
Signed-off-by: Zexin Wang <ot_zexin.wang@mediatek.com>
---
drivers/watchdog/mtk_wdt.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/watchdog/mtk_wdt.c b/drivers/watchdog/mtk_wdt.c
index 91d110646e16..ae61e7654e8f 100644
--- a/drivers/watchdog/mtk_wdt.c
+++ b/drivers/watchdog/mtk_wdt.c
@@ -501,6 +501,7 @@ static const struct of_device_id mtk_wdt_dt_ids[] = {
{ .compatible = "mediatek,mt8183-wdt", .data = &mt8183_data },
{ .compatible = "mediatek,mt8186-wdt", .data = &mt8186_data },
{ .compatible = "mediatek,mt8188-wdt", .data = &mt8188_data },
+ { .compatible = "mediatek,mt8189-wdt" },
{ .compatible = "mediatek,mt8192-wdt", .data = &mt8192_data },
{ .compatible = "mediatek,mt8195-wdt", .data = &mt8195_data },
{ /* sentinel */ }
--
2.45.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/2] dt-bindings: watchdog: mediatek: Add support for MT8189
2025-06-27 9:44 [PATCH 0/2] watchdog: mediatek: Add compatible for MT8189 Zexin Wang
2025-06-27 9:44 ` [PATCH 1/2] " Zexin Wang
@ 2025-06-27 9:44 ` Zexin Wang
2025-07-08 8:43 ` Krzysztof Kozlowski
1 sibling, 1 reply; 5+ messages in thread
From: Zexin Wang @ 2025-06-27 9:44 UTC (permalink / raw)
To: Wim Van Sebroeck, Guenter Roeck, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Matthias Brugger
Cc: Project_Global_Chrome_Upstream_Group, linux-watchdog, devicetree,
linux-kernel, linux-arm-kernel, linux-mediatek, Zexin Wang
Add compatible string for watchdog on MT8189 SoC.
Signed-off-by: Zexin Wang <ot_zexin.wang@mediatek.com>
---
Documentation/devicetree/bindings/watchdog/mediatek,mtk-wdt.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/watchdog/mediatek,mtk-wdt.yaml b/Documentation/devicetree/bindings/watchdog/mediatek,mtk-wdt.yaml
index 8d2520241e37..ad69bd28ac9e 100644
--- a/Documentation/devicetree/bindings/watchdog/mediatek,mtk-wdt.yaml
+++ b/Documentation/devicetree/bindings/watchdog/mediatek,mtk-wdt.yaml
@@ -29,6 +29,7 @@ properties:
- mediatek,mt8183-wdt
- mediatek,mt8186-wdt
- mediatek,mt8188-wdt
+ - mediatek,mt8189-wdt
- mediatek,mt8192-wdt
- mediatek,mt8195-wdt
- items:
--
2.45.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] dt-bindings: watchdog: mediatek: Add support for MT8189
2025-06-27 9:44 ` [PATCH 2/2] dt-bindings: watchdog: mediatek: Add support " Zexin Wang
@ 2025-07-08 8:43 ` Krzysztof Kozlowski
0 siblings, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2025-07-08 8:43 UTC (permalink / raw)
To: Zexin Wang
Cc: Wim Van Sebroeck, Guenter Roeck, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Matthias Brugger,
Project_Global_Chrome_Upstream_Group, linux-watchdog, devicetree,
linux-kernel, linux-arm-kernel, linux-mediatek
On Fri, Jun 27, 2025 at 05:44:20PM +0800, Zexin Wang wrote:
> Add compatible string for watchdog on MT8189 SoC.
>
> Signed-off-by: Zexin Wang <ot_zexin.wang@mediatek.com>
> ---
> Documentation/devicetree/bindings/watchdog/mediatek,mtk-wdt.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/watchdog/mediatek,mtk-wdt.yaml b/Documentation/devicetree/bindings/watchdog/mediatek,mtk-wdt.yaml
> index 8d2520241e37..ad69bd28ac9e 100644
> --- a/Documentation/devicetree/bindings/watchdog/mediatek,mtk-wdt.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/mediatek,mtk-wdt.yaml
> @@ -29,6 +29,7 @@ properties:
> - mediatek,mt8183-wdt
> - mediatek,mt8186-wdt
> - mediatek,mt8188-wdt
> + - mediatek,mt8189-wdt
So it is compatible with previous variant. Express it and drop driver
patch. Your commit msg should already say that - describe the hardware.
Now your commit msg basically duplicates patch and subject so it is 100%
redundant.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] watchdog: mediatek: Add compatible for MT8189
2025-06-27 9:44 ` [PATCH 1/2] " Zexin Wang
@ 2025-07-08 8:44 ` Krzysztof Kozlowski
0 siblings, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2025-07-08 8:44 UTC (permalink / raw)
To: Zexin Wang
Cc: Wim Van Sebroeck, Guenter Roeck, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Matthias Brugger,
Project_Global_Chrome_Upstream_Group, linux-watchdog, devicetree,
linux-kernel, linux-arm-kernel, linux-mediatek
On Fri, Jun 27, 2025 at 05:44:19PM +0800, Zexin Wang wrote:
> Add compatible string for watchdog driver on MT8189 SoC.
>
> Signed-off-by: Zexin Wang <ot_zexin.wang@mediatek.com>
> ---
> drivers/watchdog/mtk_wdt.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/watchdog/mtk_wdt.c b/drivers/watchdog/mtk_wdt.c
> index 91d110646e16..ae61e7654e8f 100644
> --- a/drivers/watchdog/mtk_wdt.c
> +++ b/drivers/watchdog/mtk_wdt.c
> @@ -501,6 +501,7 @@ static const struct of_device_id mtk_wdt_dt_ids[] = {
> { .compatible = "mediatek,mt8183-wdt", .data = &mt8183_data },
> { .compatible = "mediatek,mt8186-wdt", .data = &mt8186_data },
> { .compatible = "mediatek,mt8188-wdt", .data = &mt8188_data },
> + { .compatible = "mediatek,mt8189-wdt" },
Redundant commit, really, a least with that hardware description as in
commit msg.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-07-08 9:23 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-27 9:44 [PATCH 0/2] watchdog: mediatek: Add compatible for MT8189 Zexin Wang
2025-06-27 9:44 ` [PATCH 1/2] " Zexin Wang
2025-07-08 8:44 ` Krzysztof Kozlowski
2025-06-27 9:44 ` [PATCH 2/2] dt-bindings: watchdog: mediatek: Add support " Zexin Wang
2025-07-08 8:43 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).