From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 20FE8CA0EFA for ; Sat, 23 Aug 2025 06:32:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=GS/zqLZ7qyXkT4joWGssYQK3kGFHcKwQnTldwg/vqrg=; b=nAy3DCLzG77gZbsl5eusVBX2zH 5Pux2eGj1Ps7+FJs/QpPeTH9YM53kN19s7VkrMOqXPnsqMLiLKszRTBu1bJ1BqOyeQrAL2XGscrhu 1aKawk0YwbYrSxt7dGIpw0TjNQVuCozZyBXlWaBzDOpDzDqTOGL+aen+uIMqG4mSGKnbq9ciuXD9d Dl+dtDCNIbFm2KfSA4BwOfOz/75rjzuUk++lm0y83j3YmBv8tDWZL1HvHmxil2KkCxq2aSOSlcb1k VCEqMYWCL9GpGell+zLibHX718uQvPXp7YyZWrwhixiwOaAtgJmacu0n/Jp4SK2Poj60Z6C51C4Lf MsA4Ml7Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uphnI-000000041DD-32c4; Sat, 23 Aug 2025 06:32:04 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1upSue-00000002rG1-11nD; Fri, 22 Aug 2025 14:38:40 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id AB8C26026B; Fri, 22 Aug 2025 14:38:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 23E83C113CF; Fri, 22 Aug 2025 14:38:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1755873519; bh=0ohbEUcDQtMZ8LIN1dVF0ofMoZ/hGdLyI2kAkLh7ZKA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=V/o4d2lQpWluTRU64SKjomir38I8NJi6S9ntSkoEbKRY6tqm/4BPvkiVX5b8wSp3H +CarlZrKKN46utWL+/QSTCo1IXlBGvkLMHYHOZErae2Z3VlxJoYXn8sQnjlvdoz0x9 6cJ17jsyLDY69OMlZJTFrw2aBaa75ACZI0OzNe3DGktGuzAddCX1Mc1mEnomi3XDN/ l+03Fiw9Az8B2Kuv73xg6F8CGQLujZBdr4EusRr2d6oyE+mAIm79qatpEcUceo7B9b Z5dDy6ck95qOJc9iMv7sscc40h1F+T+AYsyhBxFarpl1Py5S8YLEZaLr95urPyCgpe 62NWVl87KI1lg== Date: Fri, 22 Aug 2025 07:38:38 -0700 From: Jakub Kicinski To: Lorenzo Bianconi Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Paolo Abeni , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, netdev@vger.kernel.org Subject: Re: [PATCH net-next 2/3] net: airoha: Add airoha_ppe_dev struct definition Message-ID: <20250822073838.7da185f9@kernel.org> In-Reply-To: References: <20250819-airoha-en7581-wlan-rx-offload-v1-0-71a097e0e2a1@kernel.org> <20250819-airoha-en7581-wlan-rx-offload-v1-2-71a097e0e2a1@kernel.org> <20250821183453.4136c5d3@kernel.org> <20250822070440.71bdd804@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Fri, 22 Aug 2025 16:26:06 +0200 Lorenzo Bianconi wrote: > > > I moved the of_node_put() here (and in the if branch) in order to fix a similar > > > issue fixed by Alok for airoha_npu. > > > > Ah, didn't notice it in the print.. > > maybe remove the empty line between the of_find_device.. and the null > > check on pdev then? > > I am fine with it. I did it this way just to be consistent with NPU code: > https://github.com/torvalds/linux/blob/master/drivers/net/ethernet/airoha/airoha_npu.c#L403 > Do you want me to post v3? Nah, it's fine.