From: <peter.wang@mediatek.com>
To: <linux-scsi@vger.kernel.org>, <martin.petersen@oracle.com>
Cc: <wsd_upstream@mediatek.com>, <linux-mediatek@lists.infradead.org>,
<peter.wang@mediatek.com>, <chun-hung.wu@mediatek.com>,
<alice.chao@mediatek.com>, <cc.chou@mediatek.com>,
<chaotian.jing@mediatek.com>, <jiajie.hao@mediatek.com>,
<yi-fan.peng@mediatek.com>, <qilin.tan@mediatek.com>,
<lin.gui@mediatek.com>, <tun-yu.yu@mediatek.com>,
<eddie.huang@mediatek.com>, <naomi.chu@mediatek.com>,
<ed.tsai@mediatek.com>, <sanjeev.y@mediatek.com>
Subject: [PATCH v1 02/10] ufs: host: mediatek: Enhance recovery on resume failure
Date: Mon, 25 Aug 2025 18:10:10 +0800 [thread overview]
Message-ID: <20250825101815.2891905-3-peter.wang@mediatek.com> (raw)
In-Reply-To: <20250825101815.2891905-1-peter.wang@mediatek.com>
From: Peter Wang <peter.wang@mediatek.com>
This patch improves the recovery process when a resume operation
fails. If both the resume and recovery fail, it logs the device's
power status and returns 0 to prevent I/O hang..
Signed-off-by: Peter Wang <peter.wang@mediatek.com>
---
drivers/ufs/host/ufs-mediatek.c | 15 ++++++++++++++-
1 file changed, 14 insertions(+), 1 deletion(-)
diff --git a/drivers/ufs/host/ufs-mediatek.c b/drivers/ufs/host/ufs-mediatek.c
index 3882bcc85305..d396878cc9a4 100644
--- a/drivers/ufs/host/ufs-mediatek.c
+++ b/drivers/ufs/host/ufs-mediatek.c
@@ -1780,8 +1780,21 @@ static int ufs_mtk_resume(struct ufs_hba *hba, enum ufs_pm_op pm_op)
}
return 0;
+
fail:
- return ufshcd_link_recovery(hba);
+ /*
+ * Check if the platform (parent) device has resumed, and ensure that
+ * power, clock, and MTCMOS are all turned on.
+ */
+ err = ufshcd_link_recovery(hba);
+ if (err) {
+ dev_err(hba->dev, "Device PM: req=%d, status:%d, err:%d\n",
+ hba->dev->power.request,
+ hba->dev->power.runtime_status,
+ hba->dev->power.runtime_error);
+ }
+
+ return 0; /* Cannot return a failure, otherwise, the I/O will hang. */
}
static void ufs_mtk_dbg_register_dump(struct ufs_hba *hba)
--
2.45.2
next prev parent reply other threads:[~2025-08-25 11:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-25 10:10 [PATCH v1 00/10] ufs: host: mediatek: Power Management and Stability Enhancements peter.wang
2025-08-25 10:10 ` [PATCH v1 01/10] ufs: host: mediatek: Enhance recovery on hibernation exit failure peter.wang
2025-08-25 15:46 ` Bart Van Assche
2025-08-26 3:04 ` Peter Wang (王信友)
2025-08-25 10:10 ` peter.wang [this message]
2025-08-25 10:10 ` [PATCH v1 03/10] ufs: host: mediatek: Correct system PM flow peter.wang
2025-08-25 10:10 ` [PATCH v1 04/10] ufs: host: mediatek: Correct resume flow for LPM and MTCMOS peter.wang
2025-08-25 10:10 ` [PATCH v1 05/10] ufs: host: mediatek: Support UFS PHY runtime PM and correct sequence peter.wang
2025-08-25 10:10 ` [PATCH v1 06/10] ufs: host: mediatek: Disable auto-hibern8 during power mode changes peter.wang
2025-08-25 10:10 ` [PATCH v1 07/10] ufs: host: mediatek: Return error directly on idle wait timeout peter.wang
2025-08-25 10:10 ` [PATCH v1 08/10] ufs: host: mediatek: Fix adapt issue after PA_Init peter.wang
2025-08-25 10:10 ` [PATCH v1 09/10] ufs: host: mediatek: Fix unbalanced IRQ enable issue peter.wang
2025-08-25 10:10 ` [PATCH v1 10/10] ufs: host: mediatek: Fix device power control peter.wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250825101815.2891905-3-peter.wang@mediatek.com \
--to=peter.wang@mediatek.com \
--cc=alice.chao@mediatek.com \
--cc=cc.chou@mediatek.com \
--cc=chaotian.jing@mediatek.com \
--cc=chun-hung.wu@mediatek.com \
--cc=ed.tsai@mediatek.com \
--cc=eddie.huang@mediatek.com \
--cc=jiajie.hao@mediatek.com \
--cc=lin.gui@mediatek.com \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=naomi.chu@mediatek.com \
--cc=qilin.tan@mediatek.com \
--cc=sanjeev.y@mediatek.com \
--cc=tun-yu.yu@mediatek.com \
--cc=wsd_upstream@mediatek.com \
--cc=yi-fan.peng@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).