From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C1DBECCD193 for ; Mon, 13 Oct 2025 14:15:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=7VLNzWiaaayGbLPJ+CR/kQopGEdhcg7BnTJUn+bNJDA=; b=e1Uv4MeYtlGrj/UzfjIr40n4g9 u7oN5M0LpOttHXdjhnEDTWogMY3IgG4g955CRbHH3GAEkj1I+G9nzJaESIrSu6a6X1QQe7IEDMxtC H1f75PfWep/+e2ckYrv7CRB6KsfSmMHDFbMSbG5bJB4k+2ivOH/ajaLNbBHyGpvc2hsVr+Pjgwo8X yfbQw9LdCIKrM6yUAJpoJWiTQwj9EMmbLwT7dwVXMcOKCWAA75p7InXgoGJOrvIUYSNN0smsYp3G+ hnUHj62w2n/+xjUSCBK5lWo68hbskFakSnPmi6fBtzY2VIM/6oCvrWiWctlevEG9DcAGgQGT/jQX4 N5KthCDw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1v8JKx-0000000DLxr-31kn; Mon, 13 Oct 2025 14:15:43 +0000 Received: from mail-lf1-f51.google.com ([209.85.167.51]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1v8JKO-0000000DKtV-2K77 for linux-mediatek@lists.infradead.org; Mon, 13 Oct 2025 14:15:10 +0000 Received: by mail-lf1-f51.google.com with SMTP id 2adb3069b0e04-57d8ff3944dso4608886e87.3 for ; Mon, 13 Oct 2025 07:15:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1760364906; x=1760969706; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=7VLNzWiaaayGbLPJ+CR/kQopGEdhcg7BnTJUn+bNJDA=; b=EZrrk8Egtio1/eNZItOEff5C5q59fO0WGrXg6jBQnypES2MT8HO03afXEY4V4TIgbn L3ucvqtalpV0N3Of8KdQ7BBLCwY+JsfJNctjDf39sBAeK/jUOL7HvEtBo/JZNFi5bANd SA8b8KRlsOZGeM2q+6pa4TJ9eSgsPhQqbGO2w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760364906; x=1760969706; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7VLNzWiaaayGbLPJ+CR/kQopGEdhcg7BnTJUn+bNJDA=; b=OhLcff/aePlG2u4pLrxK0A+MY1DfARsohMW3yHrUFnNDojAoKITi0mox9fE8rGCqqb 0o0ok90rAE7PnW+6Ptu5zyNim93hww4Ev30w8IJtjNU1JfmxxzfQwaYTjXvad+FWVCCi d6lYBQIrbLZDQf1JB/sP7rn5RxQI4Rk0lnrgqBSQ5J4+i4XHftpV6+HBGGDV8j8Qj6UY h1K+uWEnMLtlrgbXL2n1eGxoJqsyi4f//DFyR2huFHkE5dJPQ+USUJCLzrfnfY7e0SI1 ryNX3MO8k8hZPaq18VUjXfphXrhL2gF3w3N+H0WxxYlTFZiq5yi54Heen8H3I76AZHpE lF6w== X-Forwarded-Encrypted: i=1; AJvYcCXZ2KcKKc5Nej0Ng0VU6LdZ8BXISeCQRvPw7NlnffYIjjNTzIxZmqTocIajm+Me5Rhq5Kb3VgfQasUzYVoPow==@lists.infradead.org X-Gm-Message-State: AOJu0YzDbo+BUHaSym0/C4tK/l6Urgq6enf5UPCNO5lHQ2MzNK4B1fT7 hvljHf8FwyzZPz+CH+FGzcUwUVJNqoozXSuhRSPv2CETbSQPBXTEuIrpoqiuROx9ig== X-Gm-Gg: ASbGncuQK0gASJ8wyqlLVFeM7XvYOgr28/KKXHfVTe30z0TcgYp3jQk0XdIo1nBBht3 bPnC7DHMxzKqSbSIBgbci0G4NzFrIYPwTKkm/RBX+PAJjjnqI8yPxKEEvQZv8UUokzuhh1IIAXs NisZ3ufZbocoHcCJBd+vmBGMFMMY3+dv0vFVGI3sBljM47d7bdf6kOisGl1aj5vhMrMmzM6dcML DtxeItsHXdQVmtLDyXnxshdru7gz8pjjg6lKDroKXi4fNImrH8RG9ufpWVEiBPcR6XpV1eQrl3r S1qvGxWKB92PgFPsIm4aDKTMr1FxFPA4kABGFrRm8HDx7Q9f/HvBMLLHeOh+DePxUd/SMKoRIr+ uZhrumjImd+o7GwLghEpxkJbufPEof1MhiCkygXuzdNvNj3CPgdBkLwVDJSGT6V8IFz/Z3fVk3V 04RwldRQzS9WPdlc+MYw== X-Google-Smtp-Source: AGHT+IHgQ/WMhPa6rwn8Aka868vYVRu77lc4adXi44XLWG27weltH/9eVYPP+kQHy8I85fd7fOXyWw== X-Received: by 2002:a05:6512:3c87:b0:58b:23e:5ec with SMTP id 2adb3069b0e04-5906d8e5b43mr6011775e87.26.1760364906103; Mon, 13 Oct 2025 07:15:06 -0700 (PDT) Received: from ribalda.c.googlers.com (56.213.88.34.bc.googleusercontent.com. [34.88.213.56]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-590881e4e58sm4165256e87.25.2025.10.13.07.15.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Oct 2025 07:15:05 -0700 (PDT) From: Ricardo Ribalda Date: Mon, 13 Oct 2025 14:15:08 +0000 Subject: [PATCH 28/32] media: rkisp1: Use %pe format specifier MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20251013-ptr_err-v1-28-2c5efbd82952@chromium.org> References: <20251013-ptr_err-v1-0-2c5efbd82952@chromium.org> In-Reply-To: <20251013-ptr_err-v1-0-2c5efbd82952@chromium.org> To: Linus Walleij , Dmitry Torokhov , Mauro Carvalho Chehab , Hans Verkuil , Sakari Ailus , =?utf-8?q?Krzysztof_Ha=C5=82asa?= , Tomi Valkeinen , Leon Luo , Kieran Bingham , Jacopo Mondi , Kieran Bingham , Laurent Pinchart , =?utf-8?q?Niklas_S=C3=B6derlund?= , Julien Massot , Jacopo Mondi , Daniel Scally , Dave Stevenson , Benjamin Mugnier , Sylvain Petinot , Yong Zhi , Bingbu Cao , Tianshu Qiu , Tiffany Lin , Andrew-CT Chen , Yunfei Dong , Matthias Brugger , AngeloGioacchino Del Regno , Rui Miguel Silva , Laurent Pinchart , Martin Kepplinger , Purism Kernel Team , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Dafna Hirschfeld , Heiko Stuebner , Sylwester Nawrocki , Krzysztof Kozlowski , Alim Akhtar , Yemike Abhilash Chandra , Greg Kroah-Hartman Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, imx@lists.linux.dev, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-staging@lists.linux.dev, Ricardo Ribalda X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251013_071508_624563_93E98CDC X-CRM114-Status: GOOD ( 12.97 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org The %pe format specifier is designed to print error pointers. It prints a symbolic error name (eg. -EINVAL) and it makes the code simpler by omitting PTR_ERR(). This patch fixes this cocci report: ./platform/rockchip/rkisp1/rkisp1-isp.c:940:3-10: WARNING: Consider using %pe to print PTR_ERR() ./platform/rockchip/rkisp1/rkisp1-csi.c:372:3-10: WARNING: Consider using %pe to print PTR_ERR() Signed-off-by: Ricardo Ribalda --- drivers/media/platform/rockchip/rkisp1/rkisp1-csi.c | 4 ++-- drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-csi.c b/drivers/media/platform/rockchip/rkisp1/rkisp1-csi.c index 841e58c20f7fcb484643138627413425a049d1fa..ddc6182f3e4bdacdd1962c86f6259334b16aa505 100644 --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-csi.c +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-csi.c @@ -368,8 +368,8 @@ static int rkisp1_csi_s_stream(struct v4l2_subdev *sd, int enable) source_pad = media_entity_remote_source_pad_unique(&sd->entity); if (IS_ERR(source_pad)) { - dev_dbg(rkisp1->dev, "Failed to get source for CSI: %ld\n", - PTR_ERR(source_pad)); + dev_dbg(rkisp1->dev, "Failed to get source for CSI: %pe\n", + source_pad); return -EPIPE; } diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c b/drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c index 8c29a1c9309a846152d212dcb50b7bf991d4f422..147d33eb6ee0d975b257c5df2997b811ba3a62e1 100644 --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c @@ -936,8 +936,8 @@ static int rkisp1_isp_s_stream(struct v4l2_subdev *sd, int enable) sink_pad = &isp->pads[RKISP1_ISP_PAD_SINK_VIDEO]; source_pad = media_pad_remote_pad_unique(sink_pad); if (IS_ERR(source_pad)) { - dev_dbg(rkisp1->dev, "Failed to get source for ISP: %ld\n", - PTR_ERR(source_pad)); + dev_dbg(rkisp1->dev, "Failed to get source for ISP: %pe\n", + source_pad); return -EPIPE; } -- 2.51.0.760.g7b8bcc2412-goog