* [PATCH] mt76: connac: remove unused reserved field in gtk rekey TLV struct
@ 2025-11-11 13:44 Nick Huang
2025-11-11 14:00 ` Lorenzo Bianconi
0 siblings, 1 reply; 3+ messages in thread
From: Nick Huang @ 2025-11-11 13:44 UTC (permalink / raw)
To: nbd, lorenzo, ryder.lee
Cc: shayne.chen, sean.wang, linux-wireless, linux-kernel,
linux-mediatek, Nick Huang
The 'reserverd' field in struct mt76_connac_gtk_rekey_tlv was unused
and misspelled. Removing it cleans up the structure definition and
improves code readability.
Signed-off-by: Nick Huang <sef1548@gmail.com>
---
drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.h b/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.h
index 27daf4195..28cf46a5f 100644
--- a/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.h
+++ b/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.h
@@ -1681,7 +1681,6 @@ struct mt76_connac_gtk_rekey_tlv {
__le32 group_cipher;
__le32 key_mgmt; /* NONE-PSK-IEEE802.1X */
__le32 mgmt_group_cipher;
- u8 reserverd[4];
} __packed;
#define MT76_CONNAC_WOW_MASK_MAX_LEN 16
--
2.48.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mt76: connac: remove unused reserved field in gtk rekey TLV struct
2025-11-11 13:44 [PATCH] mt76: connac: remove unused reserved field in gtk rekey TLV struct Nick Huang
@ 2025-11-11 14:00 ` Lorenzo Bianconi
2025-11-11 14:10 ` Nick Huang
0 siblings, 1 reply; 3+ messages in thread
From: Lorenzo Bianconi @ 2025-11-11 14:00 UTC (permalink / raw)
To: Nick Huang
Cc: nbd, ryder.lee, shayne.chen, sean.wang, linux-wireless,
linux-kernel, linux-mediatek
[-- Attachment #1: Type: text/plain, Size: 1024 bytes --]
> The 'reserverd' field in struct mt76_connac_gtk_rekey_tlv was unused
> and misspelled. Removing it cleans up the structure definition and
> improves code readability.
>
> Signed-off-by: Nick Huang <sef1548@gmail.com>
> ---
> drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.h b/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.h
> index 27daf4195..28cf46a5f 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.h
> +++ b/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.h
> @@ -1681,7 +1681,6 @@ struct mt76_connac_gtk_rekey_tlv {
> __le32 group_cipher;
> __le32 key_mgmt; /* NONE-PSK-IEEE802.1X */
> __le32 mgmt_group_cipher;
> - u8 reserverd[4];
This field is used to keep the struct size consistent with the fw one so it is
expected to not be used.
Regards,
Lorenzo
> } __packed;
>
> #define MT76_CONNAC_WOW_MASK_MAX_LEN 16
> --
> 2.48.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mt76: connac: remove unused reserved field in gtk rekey TLV struct
2025-11-11 14:00 ` Lorenzo Bianconi
@ 2025-11-11 14:10 ` Nick Huang
0 siblings, 0 replies; 3+ messages in thread
From: Nick Huang @ 2025-11-11 14:10 UTC (permalink / raw)
To: Lorenzo Bianconi
Cc: nbd, ryder.lee, shayne.chen, sean.wang, linux-wireless,
linux-kernel, linux-mediatek
Lorenzo Bianconi <lorenzo@kernel.org> 於 2025年11月11日 週二 下午10:00寫道：
>
> > The 'reserverd' field in struct mt76_connac_gtk_rekey_tlv was unused
> > and misspelled. Removing it cleans up the structure definition and
> > improves code readability.
> >
> > Signed-off-by: Nick Huang <sef1548@gmail.com>
> > ---
> > drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.h | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.h b/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.h
> > index 27daf4195..28cf46a5f 100644
> > --- a/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.h
> > +++ b/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.h
> > @@ -1681,7 +1681,6 @@ struct mt76_connac_gtk_rekey_tlv {
> > __le32 group_cipher;
> > __le32 key_mgmt; /* NONE-PSK-IEEE802.1X */
> > __le32 mgmt_group_cipher;
> > - u8 reserverd[4];
>
> This field is used to keep the struct size consistent with the fw one so it is
> expected to not be used.
>
> Regards,
> Lorenzo
>
> > } __packed;
> >
> > #define MT76_CONNAC_WOW_MASK_MAX_LEN 16
> > --
> > 2.48.1
> >
Hi Lorenzo,
Got it, thanks for explaining. Makes sense that this field is just for
size consistency.
Cheers,
Nick Huang
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-11-11 14:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-11 13:44 [PATCH] mt76: connac: remove unused reserved field in gtk rekey TLV struct Nick Huang
2025-11-11 14:00 ` Lorenzo Bianconi
2025-11-11 14:10 ` Nick Huang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).