Linux-mediatek Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	 Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	 David Airlie <airlied@gmail.com>,
	Simona Vetter <simona@ffwll.ch>,
	 Andrzej Hajda <andrzej.hajda@intel.com>,
	 Neil Armstrong <neil.armstrong@linaro.org>,
	Robert Foss <rfoss@kernel.org>,
	 Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
	 Jonas Karlman <jonas@kwiboo.se>,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	 Dmitry Baryshkov <lumag@kernel.org>,
	 Chun-Kuang Hu <chunkuang.hu@kernel.org>,
	 Philipp Zabel <p.zabel@pengutronix.de>,
	 Matthias Brugger <matthias.bgg@gmail.com>,
	 AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>,
	 Jyri Sarha <jyri.sarha@iki.fi>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	 linux-mediatek@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	 Marek Szyprowski <m.szyprowski@samsung.com>,
	 Louis-Alexis Eyraud <louisalexis.eyraud@collabora.com>,
	 Aradhya Bhatia <aradhya.bhatia@linux.dev>,
	 Linus Walleij <linusw@kernel.org>,
	Chaoyi Chen <chaoyi.chen@rock-chips.com>,
	 Vicente Bergas <vicencb@gmail.com>,
	 Marek Vasut <marek.vasut+renesas@mailbox.org>,
	 Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>,
	stable@vger.kernel.org
Subject: [PATCH 0/4] drm: Revert and fix enable/disable sequence
Date: Fri, 05 Dec 2025 11:51:47 +0200	[thread overview]
Message-ID: <20251205-drm-seq-fix-v1-0-fda68fa1b3de@ideasonboard.com> (raw)

Changing the enable/disable sequence in commit c9b1150a68d9
("drm/atomic-helper: Re-order bridge chain pre-enable and post-disable")
has caused regressions on multiple platforms: R-Car, MCDE, Rockchip.

This is an alternate series to Linus' series:

https://lore.kernel.org/all/20251202-mcde-drm-regression-thirdfix-v6-0-f1bffd4ec0fa%40kernel.org/

This series first reverts the original commit and reverts a fix for
mediatek which is no longer needed. It then exposes helper functions
from DRM core, and finally implements the new sequence only in the tidss
driver.

There is one more fix in upstream for the original commit, commit
5d91394f2361 ("drm/exynos: fimd: Guard display clock control with
runtime PM calls"), but I have not reverted that one as it looks like a
valid patch in its own.

I added Cc stable v6.17+ to all patches, but I didn't add Fixes tags, as
I wasn't sure what should they point to. But I could perhaps add Fixes:
<original commit> to all of these.

Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
---
Linus Walleij (1):
      drm/atomic-helper: Export and namespace some functions

Tomi Valkeinen (3):
      Revert "drm/atomic-helper: Re-order bridge chain pre-enable and post-disable"
      Revert "drm/mediatek: dsi: Fix DSI host and panel bridge pre-enable order"
      drm/tidss: Fix enable/disable order

 drivers/gpu/drm/drm_atomic_helper.c | 122 ++++++++++++++----
 drivers/gpu/drm/mediatek/mtk_dsi.c  |   6 -
 drivers/gpu/drm/tidss/tidss_kms.c   |  30 ++++-
 include/drm/drm_atomic_helper.h     |  22 ++++
 include/drm/drm_bridge.h            | 249 ++++++++++--------------------------
 5 files changed, 214 insertions(+), 215 deletions(-)
---
base-commit: 88e721ab978a86426aa08da520de77430fa7bb84
change-id: 20251205-drm-seq-fix-b4ed1f56604b

Best regards,
-- 
Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>



             reply	other threads:[~2025-12-05  9:52 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20251205095238eucas1p1b7cf95d86a9aecf19877ac568148e265@eucas1p1.samsung.com>
2025-12-05  9:51 ` Tomi Valkeinen [this message]
2025-12-05  9:51   ` [PATCH 1/4] Revert "drm/atomic-helper: Re-order bridge chain pre-enable and post-disable" Tomi Valkeinen
2025-12-08 11:23     ` Aradhya Bhatia
2025-12-05  9:51   ` [PATCH 2/4] Revert "drm/mediatek: dsi: Fix DSI host and panel bridge pre-enable order" Tomi Valkeinen
2025-12-05  9:51   ` [PATCH 3/4] drm/atomic-helper: Export and namespace some functions Tomi Valkeinen
2025-12-08 11:24     ` Aradhya Bhatia
2025-12-05  9:51   ` [PATCH 4/4] drm/tidss: Fix enable/disable order Tomi Valkeinen
2025-12-08 11:26     ` Aradhya Bhatia
2025-12-05 12:36   ` [PATCH 0/4] drm: Revert and fix enable/disable sequence Linus Walleij
2025-12-05 14:25   ` Marek Szyprowski
2025-12-08 11:06   ` Maxime Ripard
2025-12-12 14:21   ` Tomi Valkeinen
2025-12-14 11:14     ` Linus Walleij
2025-12-14 12:42       ` Tomi Valkeinen
2025-12-22 23:18         ` Linus Walleij
2025-12-23 11:48           ` Tomi Valkeinen
2026-01-03 19:12             ` Linus Walleij
2026-01-03 19:27               ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251205-drm-seq-fix-v1-0-fda68fa1b3de@ideasonboard.com \
    --to=tomi.valkeinen@ideasonboard.com \
    --cc=Laurent.pinchart@ideasonboard.com \
    --cc=airlied@gmail.com \
    --cc=andrzej.hajda@intel.com \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=aradhya.bhatia@linux.dev \
    --cc=chaoyi.chen@rock-chips.com \
    --cc=chunkuang.hu@kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jernej.skrabec@gmail.com \
    --cc=jonas@kwiboo.se \
    --cc=jyri.sarha@iki.fi \
    --cc=linusw@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=louisalexis.eyraud@collabora.com \
    --cc=lumag@kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=marek.vasut+renesas@mailbox.org \
    --cc=matthias.bgg@gmail.com \
    --cc=mripard@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=p.zabel@pengutronix.de \
    --cc=rfoss@kernel.org \
    --cc=simona@ffwll.ch \
    --cc=stable@vger.kernel.org \
    --cc=tzimmermann@suse.de \
    --cc=vicencb@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox