From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 12473D1CDC6 for ; Sun, 7 Dec 2025 14:01:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=8YQ8sHlNNu/5RbON/Ec6l62YniwlAW7dxyB2Fsz3Np0=; b=1uNubPbVD1UnqFlcFoMMMGDNf+ XOM1AFH+zFW1uDMchH9PU8bMbNMbHtARkEv4i97NmYLcNz9ZKK/5JfZwN+OEqvWByhyV8IF6F+KKP T8ZrqwKC0OdQe4gCgwTIo7tnKybbSdDmQTS9u2nzQne1EhjNqAle73IRUX0P78fkMw/pMV2H4ZQ9Q ZNnMe316C1PSuAC1CLlaisF9opuUD556q3NwzR6AP6er6bqpHmkZTqMgYfWfCVPDN00AZQn24fNFp cWJ0NT4YSuC4goR3XF5+4+64mtuEQfY1WIYJo4+59yxcpnMoFdy8zU3V3a2MX03x6/1aMxuU8ifgq E6PLRFVQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vSFK9-0000000BzGj-2zqR; Sun, 07 Dec 2025 14:01:17 +0000 Received: from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vSFK7-0000000BzGY-0bXo; Sun, 07 Dec 2025 14:01:16 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id C0E276001D; Sun, 7 Dec 2025 14:01:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0AD22C4CEFB; Sun, 7 Dec 2025 14:00:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1765116073; bh=XIPzPHGdu9MVAiWYzmLVkJFzpk/+VDBaaF5v6Z7S21s=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=EsCx8mM87A8HyrcrJI3CQaCEoWdzjxwjyxeqqWomtZPKX5oKnNhnVYczlV7yr+api h1nrsAZDZtwq8anuESeyBIikhqAGux8Sco7E2Rn/vfqVt3PrLc2LEXvN4NSCJv8VNd QVVaCfRbNh41EPha2La8wU9XYpzaRw5oeg/WKfl2DGoA8/1tRRDfQAYNuQDEo9c9yk dqBAsLPZNDc43gMPXaP5nnzCsVtGWyKsl2w7so4uosQ6fq9FfMfKiMuPsd2YnYkyMA RKvB9A/O4JQAg0lFIEGn3i1jJw/CzAX645QjvGuZeOKfDEgbv9poaPspTv29soMaUq UJU9YlFfffWtg== Date: Sun, 7 Dec 2025 14:00:46 +0000 From: Jonathan Cameron To: Romain Gantois Cc: MyungJoo Ham , Chanwoo Choi , Guenter Roeck , Peter Rosin , Nuno =?UTF-8?B?U8Oh?= , Andy Shevchenko , Lars-Peter Clausen , Michael Hennerich , Mariel Tinaco , Kevin Tsai , Linus Walleij , Dmitry Torokhov , Eugen Hristev , Vinod Koul , Kishon Vijay Abraham I , Sebastian Reichel , Chen-Yu Tsai , Hans de Goede , Support Opensource , Paul Cercueil , Iskren Chernev , Krzysztof Kozlowski , Marek Szyprowski , Matheus Castello , Saravanan Sekar , Matthias Brugger , AngeloGioacchino Del Regno , Casey Connolly , Pali =?UTF-8?B?Um9ow6Fy?= , Orson Zhai , Baolin Wang , Chunyan Zhang , Amit Kucheria , Thara Gopinath , "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui , Lukasz Luba , Claudiu Beznea , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Sylwester Nawrocki , Olivier Moysan , Arnaud Pouliquen , Maxime Coquelin , Alexandre Torgue , David Lechner , Thomas Petazzoni , linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-iio@vger.kernel.org, linux-input@vger.kernel.org, linux-phy@lists.infradead.org, linux-pm@vger.kernel.org, linux-mips@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-sound@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com Subject: Re: [PATCH] iio: inkern: Use namespaced exports Message-ID: <20251207140046.56322d6f@jic23-huawei> In-Reply-To: <5948030.DvuYhMxLoT@fw-rgant> References: <20251201-iio-inkern-use-namespaced-exports-v1-1-da1935f70243@bootlin.com> <78240755-44dc-4835-aca5-99540cca0304@baylibre.com> <5948030.DvuYhMxLoT@fw-rgant> X-Mailer: Claws Mail 4.3.1 (GTK 3.24.51; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Tue, 02 Dec 2025 08:30:58 +0100 Romain Gantois wrote: > On Monday, 1 December 2025 18:15:54 CET David Lechner wrote: > > On 12/1/25 4:59 AM, Romain Gantois wrote: > > > Use namespaced exports for IIO consumer API functions. > > > > > > Signed-off-by: Romain Gantois > > > --- > > > > ... > > > > > diff --git a/drivers/iio/dac/ds4424.c b/drivers/iio/dac/ds4424.c > > > index a8198ba4f98a..33d6692f46fe 100644 > > > --- a/drivers/iio/dac/ds4424.c > > > +++ b/drivers/iio/dac/ds4424.c > > > @@ -14,7 +14,6 @@ > > > > > > #include > > > #include > > > #include > > > > > > -#include > > > > Unrelated change? > > Indeed, I'll leave that out in v2. Please spin a precursor patch that makes that change. That way we can easily check all files either both include that header and have the namespace enabled, or neither. I might merge this is a slightly funny way that leave it initially not meeting that rule so that the precursor isn't in the immutable branch for other subsystems but lets keep it logical in the patch set! Jonathan > > > > #define DS4422_MAX_DAC_CHANNELS 2 > > > #define DS4424_MAX_DAC_CHANNELS 4 > > > > > > @@ -321,3 +320,4 @@ MODULE_AUTHOR("Ismail H. Kose > > > ");> > > > MODULE_AUTHOR("Vishal Sood "); > > > MODULE_AUTHOR("David Jung "); > > > MODULE_LICENSE("GPL v2"); > > > > > > +MODULE_IMPORT_NS("IIO_CONSUMER"); > > > > Is this actually needed if we don't use anything from consumer.h? > > No, it's not. > > Thanks, >