From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9F3D7D6D220 for ; Thu, 18 Dec 2025 12:58:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=5ffKBB6lbOaIsBkcG3obI8JTmPQlnI+BcIQn8P1gOiM=; b=obaFaUhygbHpabIqfhrc2HR7ZP yzixgCa9977pdw/6QCCyw6AAEcRRK4tuVDvHTJguO24WliY8mPp7wyHBM+SBkXy5w6SRWCBJs6hgc eTzkmk/elakj06knADvCLvDupOyNos3xGVZfdByf4gWZ9+mI4K1O8qiro32xt7l8t2kgkaUMyJaU6 fi9tfzm436m/19NtfGLRp0/1gMaDQ/2Tfgbv+DQemkYtKZSwTxnph/eseYycQEjwD0c++u/ovXrFH aH9fuejtj/uIRmAWENUj9x6aJrGkFjwxzT5ij0nrZJvBptaxnyiNjTZpNRon8zmu0cxPvNTBuq3oM jJz/k5Xw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vWDaL-00000008U7q-0Pp2; Thu, 18 Dec 2025 12:58:25 +0000 Received: from sender4-pp-f112.zoho.com ([136.143.188.112]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vWDaB-00000008Tvr-0azJ; Thu, 18 Dec 2025 12:58:20 +0000 ARC-Seal: i=1; a=rsa-sha256; t=1766062687; cv=none; d=zohomail.com; s=zohoarc; b=dMdNV4RMBFgMseDehbPS4r6Ovgw9iAt3Fnrz7TZAbAFSke9Upvbm4RgVPvqvHj4UcpWHRU26wR9wvKJg+LCnTj4+PvuqLxIeVY9JD5i7b1vG8g/jkQVUfuKlCAZmtKS2jAuGAIgZeZMTwhQN1lllngrwhJG5IIpi9y/sC4BmaZ0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1766062687; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=5ffKBB6lbOaIsBkcG3obI8JTmPQlnI+BcIQn8P1gOiM=; b=ePNQ06ZOEfTbvGQzjkF3XXMcztTXO1SIXy4k3FOWPXeg3MQ1/uWNTkdnXmgsaSu7QMRLmrUjJ5baGtwqMxr7CHFAlr4rX3xPLiYoeLe3AKN1J3efaBMcT8BpZDBCsMOHHgsN8hJq673piO4k//RuYF9K/fXjQ+NyT6pUbsCeryU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=nicolas.frattaroli@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1766062686; s=zohomail; d=collabora.com; i=nicolas.frattaroli@collabora.com; h=From:From:Date:Date:Subject:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Message-Id:References:In-Reply-To:To:To:Cc:Cc:Reply-To; bh=5ffKBB6lbOaIsBkcG3obI8JTmPQlnI+BcIQn8P1gOiM=; b=Ou451zT+guHS/ZJgVj6zaho8e2sUi8BUyx9Vjqkf8hy9KOKb4vd2pOl8yl5MpcVO sI9IhlINd3ZUX1sbJXAoXnFasCI9YyettWSnXasTiJHpS/udEm2amBgdwF5NzFnVzMI pURCPLjbFwIycXGYB9ALhJR0FT2vWx9uLkWjRtaM= Received: by mx.zohomail.com with SMTPS id 17660626852801023.0968326979573; Thu, 18 Dec 2025 04:58:05 -0800 (PST) From: Nicolas Frattaroli Date: Thu, 18 Dec 2025 13:55:14 +0100 Subject: [PATCH v4 24/25] scsi: ufs: mediatek: Remove ret local from link_startup_notify MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20251218-mt8196-ufs-v4-24-ddec7a369dd2@collabora.com> References: <20251218-mt8196-ufs-v4-0-ddec7a369dd2@collabora.com> In-Reply-To: <20251218-mt8196-ufs-v4-0-ddec7a369dd2@collabora.com> To: Alim Akhtar , Avri Altman , Bart Van Assche , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Chunfeng Yun , Vinod Koul , Kishon Vijay Abraham I , Peter Wang , Stanley Jhu , "James E.J. Bottomley" , "Martin K. Petersen" , Philipp Zabel , Liam Girdwood , Mark Brown , Chaotian Jing , Neil Armstrong Cc: Louis-Alexis Eyraud , kernel@collabora.com, linux-scsi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-phy@lists.infradead.org, Nicolas Frattaroli X-Mailer: b4 0.14.3 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251218_045815_576002_76C70C6E X-CRM114-Status: GOOD ( 11.79 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Remove the "ret" local variable from ufs_mtk_link_startup_notify, as it's pointless; in all cases it is assigned, it is returned right after without being read first. Rework the code to just return directly, and get rid of the default branch while at it. Signed-off-by: Nicolas Frattaroli --- drivers/ufs/host/ufs-mediatek.c | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/ufs/host/ufs-mediatek.c b/drivers/ufs/host/ufs-mediatek.c index 7c5d30a79456..bec726ea15b7 100644 --- a/drivers/ufs/host/ufs-mediatek.c +++ b/drivers/ufs/host/ufs-mediatek.c @@ -1518,21 +1518,15 @@ static void ufs_mtk_post_link(struct ufs_hba *hba) static int ufs_mtk_link_startup_notify(struct ufs_hba *hba, enum ufs_notify_change_status stage) { - int ret = 0; - switch (stage) { case PRE_CHANGE: - ret = ufs_mtk_pre_link(hba); - break; + return ufs_mtk_pre_link(hba); case POST_CHANGE: ufs_mtk_post_link(hba); - break; - default: - ret = -EINVAL; - break; + return 0; } - return ret; + return -EINVAL; } static int ufs_mtk_device_reset(struct ufs_hba *hba) -- 2.52.0