Linux-mediatek Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Luca Leonardo Scorcia <l.scorcia@gmail.com>
Cc: linux-mediatek@lists.infradead.org,
	 Wim Van Sebroeck <wim@linux-watchdog.org>,
	Guenter Roeck <linux@roeck-us.net>,
	 Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	 Conor Dooley <conor+dt@kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	 AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	 linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	 linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 7/7] arm64: dts: mt8167: Add additional mmsys reset bits
Date: Thu, 12 Feb 2026 12:38:46 +0100	[thread overview]
Message-ID: <20260212-flawless-stirring-foxhound-c9fefc@quoll> (raw)
In-Reply-To: <6f803b6dd1f61728c17afadd2fe983e9fdc0c109.1770836190.git.l.scorcia@gmail.com>

On Wed, Feb 11, 2026 at 07:03:28PM +0000, Luca Leonardo Scorcia wrote:
> Some extra mmsys reset bits are defined in the Lenovo
> Smart Clock kernel sources - file cmdq_mdp.c
> 
> Signed-off-by: Luca Leonardo Scorcia <l.scorcia@gmail.com>
> ---
>  include/dt-bindings/reset/mt8167-resets.h | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/include/dt-bindings/reset/mt8167-resets.h b/include/dt-bindings/reset/mt8167-resets.h
> index f77c2ca897cf..b379f8f023d5 100644
> --- a/include/dt-bindings/reset/mt8167-resets.h
> +++ b/include/dt-bindings/reset/mt8167-resets.h
> @@ -33,6 +33,15 @@
>  #define MT8167_TOPRGU_SW_RST_NUM		15
>  
>  /* MMSYS resets */
> +#define MT8167_MMSYS_SW0_RST_B_SMI_COMMON	0
> +#define MT8167_MMSYS_SW0_RST_B_SMI_LARB		1
> +#define MT8167_MMSYS_SW0_RST_B_CAM_MDP		2
> +#define MT8167_MMSYS_SW0_RST_B_MDP_RDMA0	3
> +#define MT8167_MMSYS_SW0_RST_B_MDP_RSZ0		4
> +#define MT8167_MMSYS_SW0_RST_B_MDP_RSZ1		5
> +#define MT8167_MMSYS_SW0_RST_B_MDP_TDSHP0	6
> +#define MT8167_MMSYS_SW0_RST_B_MDP_WDMA		7
> +#define MT8167_MMSYS_SW0_RST_B_MDP_WROT0	8

? You just added this file in other commit. Don't add half-baked
bindings/code, but complete at once.

Best regards,
Krzysztof



      parent reply	other threads:[~2026-02-12 11:38 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-11 19:03 [PATCH 0/7] arm64: dts: mt8167: Add the mmsys reset bit to reset DSI Luca Leonardo Scorcia
2026-02-11 19:03 ` [PATCH 1/7] soc: mediatek: mtk-mmsys: Add resets for mt8167 Luca Leonardo Scorcia
2026-02-12  9:52   ` AngeloGioacchino Del Regno
2026-02-11 19:03 ` [PATCH 2/7] dt-bindings: mediatek: Add reset controller constants " Luca Leonardo Scorcia
2026-02-12  9:52   ` AngeloGioacchino Del Regno
2026-02-12 11:36   ` Krzysztof Kozlowski
2026-02-11 19:03 ` [PATCH 3/7] watchdog: mediatek: Add support for mt8167 TOPRGU/WDT Luca Leonardo Scorcia
2026-02-12  9:52   ` AngeloGioacchino Del Regno
2026-02-11 19:03 ` [PATCH 4/7] dt-bindings: watchdog: Support MediaTek MT8167 wdt Luca Leonardo Scorcia
2026-02-12  9:52   ` AngeloGioacchino Del Regno
2026-02-11 19:03 ` [PATCH 5/7] arm64: dts: mt8167: Add a specific watchdog dts node Luca Leonardo Scorcia
2026-02-12  9:52   ` AngeloGioacchino Del Regno
2026-02-11 19:03 ` [PATCH 6/7] arm64: dts: mt8167: Add the mmsys reset bit to reset dsi Luca Leonardo Scorcia
2026-02-12  8:01   ` Luca Leonardo Scorcia
2026-02-12  9:57     ` AngeloGioacchino Del Regno
2026-02-12  9:52   ` AngeloGioacchino Del Regno
2026-02-11 19:03 ` [PATCH 7/7] arm64: dts: mt8167: Add additional mmsys reset bits Luca Leonardo Scorcia
2026-02-12  9:55   ` AngeloGioacchino Del Regno
2026-02-12 11:38   ` Krzysztof Kozlowski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260212-flawless-stirring-foxhound-c9fefc@quoll \
    --to=krzk@kernel.org \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=l.scorcia@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=matthias.bgg@gmail.com \
    --cc=p.zabel@pengutronix.de \
    --cc=robh@kernel.org \
    --cc=wim@linux-watchdog.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox