From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 860EDE98DF7 for ; Mon, 23 Feb 2026 07:27:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To: Content-Transfer-Encoding:Content-Type:MIME-Version:Message-Id:Date:Subject: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=+Lif/v6jrZ/kaLcznuMV5NFqGRHxVZU6OFm4P/Ynz3s=; b=u0L2aOhFd0BKXj di9aaZ7xeqDF6tfE0/h9munFH3IGbgwm3bViqHDJhSRYhVz5rrwE3fC+pHzvp9WSqeK/SydKlaon1 iur2BDBvFiELVcnhrehLqRTIRY3oPaQYSv88ihnmgAYqoEE1gkEEeEqd1KoHM7jmCwwP+oC//0tLz moqi+3xUMXonNzK8Kc/hHOPZhqBd0JHs7In9aTtfj5b4HqoihvVty5xbnQK35fsc5iMiKD3GO1UoK 85CpaMa92hFugZRmTPiPcBJ94hN6ka42IIHPqanMydhry51gsldxdQJOFmlpgSPxJa7EOBTJwXbYM m4jzYHnw6nbPN5+GpFNw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vuQMC-0000000HMcn-36c6; Mon, 23 Feb 2026 07:27:52 +0000 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vuQM9-0000000HMaR-0JUq for linux-mediatek@lists.infradead.org; Mon, 23 Feb 2026 07:27:50 +0000 Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61MMGh2T3532324 for ; Mon, 23 Feb 2026 07:27:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=qcppdkim1; bh=+Lif/v6jrZ/kaLcznuMV5N FqGRHxVZU6OFm4P/Ynz3s=; b=VIiZZeQ3woW7l8DMziY9OPKkuzrr5WNhrX5twr Ot+moTFjx0q5lnDv2or3HQApaGPAmGRN5kBaE9R1gOL4H9XLEJsO2V7GjrwR6KS/ tjoF3hKqVcrtYtggls9p2aTzeYdDOfWzzeICU7aJZD7k3wBXJLhlT9QO5Th5FVBZ J2OFM6fMPkp/Er9l8bdQJEg3PqYWiqCuez3tlzixbMcjJKMvz9CNOy4SRJkIo1xA sV4vkvs2yAakQhJTZXYBjOtq6L/Ae8FSE/PS1IcJYsBKCOMJFCMns+gcLB6upM/R lI3Lhx/blom9t0CM8AxYew3hhZCFZeaOFLQywNLhRa9aiGKg== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cf5u8krvs-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 23 Feb 2026 07:27:45 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-8cb3fae6f60so5290530085a.1 for ; Sun, 22 Feb 2026 23:27:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1771831665; x=1772436465; darn=lists.infradead.org; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:from:to:cc:subject:date:message-id:reply-to; bh=+Lif/v6jrZ/kaLcznuMV5NFqGRHxVZU6OFm4P/Ynz3s=; b=HTGR0vW0SbBlzpXiuZjX1xt1ic/w6AD+VKRFIL3KhVer1vASvFG9QMCcbdyY2WRcz0 2tg9E6UX8IvoRtx3OtVZJp02HQfUkVff0RysGif2pzhD9mfd0NmeZfRmSpy1bTOvxupG 6lz1iykZLvv1zxkB07zMxfU9gagJw6CunWnD+3vV3GjMCMrvQwFz0tXrMha7lfQwvYRr 59o1K2V+0Bm8dq2uKOME73AIeeBhL/DoXOffqi0ip28Hqhe9x4xZH8ZFTyl4UsRv9xgd KwqjpDxkd59kFA4boMPGljZ+MfUaU+Y+7w/4fCsXzXXVTT5oXMTjoI1WaKbMUxOJy94d 86fA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771831665; x=1772436465; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+Lif/v6jrZ/kaLcznuMV5NFqGRHxVZU6OFm4P/Ynz3s=; b=T/o/jQE7UHFChBFHlNtNPxc/5rK+DMirNGmom9pdQ70qv8YM4qfcWgrFW0Ia185CWk TCO96OetKJo/3BvHWx6yefoKEnnBGilYyjQjQTHDeXLZW9uwZPiBk7V5kzT4f33I/zmE G6kbIkaGyIMK6qK5VCctR3ntaMgE//hvmOAbCwWJNuA0yhkBQ1qaXF8XvMyw2xFdt8w8 zzdBb7yQ8/+i5wPPYnC1yljNgJA9I+pEYEQt3HYNZyIqkCXi+0fj/nAWrVcSjAzgsjNo PFImah1/AhlKNn53sVUkfh8ID0FuYdbGv+kuI345DWeL7KSLymFveTyKxvsuMDgx2srF OrNQ== X-Forwarded-Encrypted: i=1; AJvYcCWzvm4eT+D5NNhPc5WDHeRO9TdsT0nu705klMGGs2FGSpOMPk+7PVXOi17aTAAzPV4vMvoXd81pxqyMFnp54A==@lists.infradead.org X-Gm-Message-State: AOJu0Ywz4DlqyihDU7rDfIYMVmu3vZTTRJvX7Qya844WlfXN0JdqFV38 WUqV4tJEIlYc9tt+Wn6NUOh505rPJgCpBb8lPW/Da5BIG+m1LhIyBv1xJCliCl2m/t5Oi4JAkw1 Nqiy7WIAgyCuHB0wzieRCJUdS32WiwennAjVNJysF7nftRtyzfaMmTEI5WEWIB8EcDZR5mdBJUl A= X-Gm-Gg: AZuq6aIUa6OsrQrg+8j8yw0Y7fFuhZFE4XftIXB6vUy0stwewuubmM7qogn9lpG73o5 uf4d3vWk/XELacNMtaOThWGLE3FMJT2ROyMIdPUtq01njHyTlNXct2EXI5JDY4+oSI9+Nh8LbTA bC/BbXzyNSdmQ4YRsvhvGbyyY+zg/3rZFvERBZsBqkXbufZeMxy0/Q3n35NrX3R7Pl1o0LutU/M WFlfJWoKH8Kb1leiVF/E/brhDuWhzhPR0WaIdOfPkcknXViHsmHbFyDPnnsapeBKjCesMYa9Zn7 e3xqicphFKB2Mz+mAQbrbNdXphkJgPK9vUObXZqfj9Db88qaQtKk7bKRJ5QkH6nnjHzXvodK1Ke GUGrZBZFI38kukrCFtpOVffPIBqhpubqx1uiLdYkxabskcA== X-Received: by 2002:a05:620a:3949:b0:8cb:4d46:7a6e with SMTP id af79cd13be357-8cb7be5dc53mr1446018485a.10.1771831665242; Sun, 22 Feb 2026 23:27:45 -0800 (PST) X-Received: by 2002:a05:620a:3949:b0:8cb:4d46:7a6e with SMTP id af79cd13be357-8cb7be5dc53mr1446016185a.10.1771831664738; Sun, 22 Feb 2026 23:27:44 -0800 (PST) Received: from [127.0.1.1] ([178.197.223.140]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43970bf9ff5sm18550286f8f.4.2026.02.22.23.27.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 22 Feb 2026 23:27:44 -0800 (PST) From: Krzysztof Kozlowski Subject: [PATCH 0/9] workqueue / drivers: Add device-managed allocate workqueue Date: Mon, 23 Feb 2026 08:27:28 +0100 Message-Id: <20260223-workqueue-devm-v1-0-10b3a6087586@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIAGABnGkC/x3MSw5AMBRG4a3IHWtSTRC2Igbojxvxuk1LIvauM fwG5zzkIAxHdfKQILDjfYvI0oSGudsmKLbRZLQptDFaXbssp4eHsgirslVeZchRavQUo0Mw8v0 Pm/Z9P35gpCpgAAAA X-Change-ID: 20260220-workqueue-devm-d9591e5e70eb To: Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Jonathan Corbet , Shuah Khan , Tejun Heo , Lai Jiangshan , Tobias Schrammm , Sebastian Reichel , Andy Shevchenko , Dan Carpenter , Krzysztof Kozlowski , Lee Jones , Dzmitry Sankouski , Matthias Brugger , AngeloGioacchino Del Regno , Benson Leung , Tzung-Bi Shih Cc: driver-core@lists.linux.dev, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Sebastian Reichel , linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, chrome-platform@lists.linux.dev, Krzysztof Kozlowski , stable@vger.kernel.org X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=2816; i=krzysztof.kozlowski@oss.qualcomm.com; h=from:subject:message-id; bh=7mljl1U9eXffJpZ0hBAWdNAHR5m+p0KaG/n8r9LaqAA=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBpnAFmZkGFLhO7cbL4Sqp0/lLgGV3Z1pGEZFFfE 0wp1vv9KA+JAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaZwBZgAKCRDBN2bmhouD 1w6hD/0ZJmVgKfBwm7gdyPe4n638O/Y+0/1CnXxbSLVvC65RI+b67sjIRddYF78ZDR86k0TSQ/q DjiUVn5vZAowj6LeTHrZRaRtHU4IZE+hh4eAQ1lSS/4NgwPBo9lQ7MI1jCAqg/hhcrMyEI1apzN uz6mXYcLAmYs176+CiTXgk3dZheGTTQuy1dq216FpqcPC37DNvAo9MRMMNrQphMMBOccJtUBxD3 FVpfb3ryijGZo7GnGUR2Zl9th+Ckpj/DwAceYI6vXj/GFH9Re/rG7P/HCyXgU4IZTHyprrcN0A4 +Fimqo16Xxk9ffA8Ay5jkNF5/dFwQpgwMaVL2UJ04reD02gmHC/ib98vWMWTn3f/7w9pHDHAREO P6lx3QQKk6T3RT93ubw+O1DmjEMUeFnQHjEzk3b2S24uPwigtCuuaaFwe3gKzE0RhJAa3WROqJW dDx5NhC+Xg1aVOvRnLui39fkdqlwI9+AymUaGv3Ywe4BuBFA+lIcaUtPr14MrB329TWkJJB4ESJ PI9P0pNKpiPr/7BP05GVUyC8Wog05QRUVQBpPrxGG7VNotOJv1XCvWsNbVW8DMTvYVdkjPGefdM gp9gsjavEO6zd1p18hW06CbQu1O3rfae5eMWQTfiESznwD7h8CdoGC1MzLglLGA/ohMND7X7f4Y IcMk/BuoVRa2UNw== X-Developer-Key: i=krzysztof.kozlowski@oss.qualcomm.com; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B X-Proofpoint-GUID: oq84eXPNF4FsTl5Nb8S315Xdx1XFl3X8 X-Authority-Analysis: v=2.4 cv=cJftc1eN c=1 sm=1 tr=0 ts=699c0171 cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=6nO30s3o7FuWeffXwhKHTA==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=5RJr-VCCejNB9LTRrg8A:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-ORIG-GUID: oq84eXPNF4FsTl5Nb8S315Xdx1XFl3X8 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjIzMDA2NCBTYWx0ZWRfX7FsM9ZQb1oEt PBw1HDd+yrX+11cMqRjQXTkVVVOMOcnGVBPT+EawW9F9NyWa9LbuMi1elphtB0fZi1iJVO/2CSN rv/0IgJANW8vV+7H2Fy2OtEU61Hin9qjIkwwiyVvdQwL7Oeib0J7Pts/RTD2ISniCW5bvtHdYPd hTw+PBa0uqLm5ghuZ4sz0/B6TxObOlXKUGP+aFdaZvQhauqdqxPeGq820TiCusxs2nBtiFSc4XK sA6GM3qLpghOk5fzyzekTOcEdzvLmKgSBnn8z6F4flZrdEw1uiyCsK5kzpiL/Fg8KOxt5V5qaSQ dD8NBQwN2LS2oz/E++HNhrwvKFWoF8E/nSafPT8Mw9960tGUKx8F+RpXVsKIk9/V9zBTXTG22Ig 8+dxQJ2S2oOEVnRypNGFm2wMpKyXvc9PyoUZczky9/V9WJl4ny0ySTpKHksEKweqlJ9/fy60OBW i4yp6fTfZUNprSsoE/g== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-23_01,2026-02-20_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 spamscore=0 clxscore=1015 malwarescore=0 suspectscore=0 priorityscore=1501 lowpriorityscore=0 phishscore=0 impostorscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2602230064 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260222_232749_222215_6B4A2C9F X-CRM114-Status: GOOD ( 15.31 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Merging / Dependency ==================== All further patches depend on the first one, thus this probably should go via one tree, e.g. power supply. The first patch might be needed for other trees as well, e.g. if more drivers are discovered, so the best if it is on dedicated branch in case it has to be shared. Description =========== Add a Resource-managed version of alloc_workqueue() to fix common problem of drivers mixing devm() calls with destroy_workqueue. Such naive and discouraged driver approach leads to difficult to debug bugs when the driver: 1. Allocates workqueue in standard way and destroys it in driver remove() callback, 2. Sets work struct with devm_work_autocancel(), 3. Registers interrupt handler with devm_request_threaded_irq(). Which leads to following unbind/removal path: 1. destroy_workqueue() via driver remove(), Any interrupt coming now would still execute the interrupt handler, which queues work on destroyed workqueue. 2. devm_irq_release(), 3. devm_work_drop() -> cancel_work_sync() on destroyed workqueue. devm_alloc_workqueue() has two benefits: 1. Solves above problem of mix-and-match devres and non-devres code in driver, 2. Simplify any sane drivers which were correctly using alloc_workqueue() + devm_add_action_or_reset(). Best regards, Krzysztof --- Krzysztof Kozlowski (9): workqueue: devres: Add device-managed allocate workqueue power: supply: cw2015: Free allocated workqueue power: supply: max77705: Free allocated workqueue and fix removal order power: supply: mt6370: Simplify with devm_create_singlethread_workqueue power: supply: ipaq_micro: Simplify with devm mfd: ezx-pcap: Drop memory allocation error message mfd: ezx-pcap: Return directly instead of empty gotos mfd: ezx-pcap: Avoid rescheduling after destroying workqueue platform/chrome: cros_usbpd_logger: Simplify with devm Documentation/driver-api/driver-model/devres.rst | 7 ++++ drivers/mfd/ezx-pcap.c | 27 +++++-------- drivers/platform/chrome/cros_usbpd_logger.c | 18 ++++----- drivers/power/supply/cw2015_battery.c | 3 +- drivers/power/supply/ipaq_micro_battery.c | 50 ++++++++---------------- drivers/power/supply/max77705_charger.c | 36 ++++++----------- drivers/power/supply/mt6370-charger.c | 13 +----- include/linux/workqueue.h | 32 +++++++++++++++ kernel/workqueue.c | 32 +++++++++++++++ 9 files changed, 117 insertions(+), 101 deletions(-) --- base-commit: bc32aa8c2aea9fd3acda58dd8a5ea6c17e9dfc36 change-id: 20260220-workqueue-devm-d9591e5e70eb Best regards, -- Krzysztof Kozlowski