From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BA795E98DF8 for ; Mon, 23 Feb 2026 07:28:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=AH50fw9QTtdpPbt41EGIzTuypwuiZyQQHwG7B4PGWqg=; b=3Aakggeyzq8b+pII/xlzY57tdw 9PQ1GQwDVRHH+tGu/q6tZNDDJYAV+8inOUaYT/rWVURopirG+pN96DpLpIb0hgbfwruJYeUM34trs PPfV9yIm210qemrr4gB6U/q24LQjB1Vwwap88QD2m9Y4bNCsSFZu0jIr5PO5FGcgyUzmF+mx38Gnl J/vE1ROxtVuotRyUSMbf0zE0ShM5ksmGl9yEE/gPjmYZs75XLHINWyGLelrJXUaoHm41/oY/g+iOt 2sO1gh92gXN6CQQXvpt0dz4+liendbP1SVcdXhSJn4cwjYglVJ7TWik4r1FJPf25nr6fN6BNdCsh7 jpcJnOsQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vuQMN-0000000HMqC-30Lp; Mon, 23 Feb 2026 07:28:03 +0000 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vuQMG-0000000HMgi-2Pqs for linux-mediatek@lists.infradead.org; Mon, 23 Feb 2026 07:27:57 +0000 Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61MLvihN2163668 for ; Mon, 23 Feb 2026 07:27:55 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= AH50fw9QTtdpPbt41EGIzTuypwuiZyQQHwG7B4PGWqg=; b=IPkQwJkV2xswGPCh rc3S7O5B9GNV14vX4IX8goHyV0CQK1YBxQHVtKRzM7s59ilh+7WdzmyNwk0bPXo1 4BtOGKkxBBhQecc+toLDIAgYgKgx5oOC+N9otwEZFgVfHQKJtSlX9txYMWJQJHxD xUHTNr7LClPUIZveXVZbDiFmTfdb21XbH410rYJS3nv4+71vAyTjwE8jCfPA9ziA b61Lq5jOuNoK1GnE5TKO9/QABCXAQPfFymvBkzuQlukp0j0gJb4u22iIvLXz0rHw f9xG75AOu5gdH4B2LSoLOVXpfvnCRMMZE/DnZy3j34HbXdOgUxLXgx54prbFk90E yuSbgw== Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cf5v3ur77-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 23 Feb 2026 07:27:55 +0000 (GMT) Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-89473f5a755so533260186d6.0 for ; Sun, 22 Feb 2026 23:27:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1771831675; x=1772436475; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=AH50fw9QTtdpPbt41EGIzTuypwuiZyQQHwG7B4PGWqg=; b=aWGJ74BZU2286jBgFnuhRAeIyBDo0REwH52W0rP6YE4vL/r/aimihp/A2Cu6Ob5H6d 7pCgrfzO4aBWxUUrvDcLxSr/CMeXwjeuev66lA8e9Rxr0is8Ji6ebIpWYzp1aUOQ6F9t rS2aYfsgKxJ2kOmIRlmkkwZpG1MeJMp4ILozI+uEkUJ/NngFhHsJ2JUEW07jxmf5mNKG HjgLJMdL79BWkqL1Np+blwVZO4xAKZn9nYtoVjP+oRw3pP38fcP+skT2Di8gZRzm/tAH u7s0XOV6GjCFnLOOfwg5TVtkB+d3qLoqYJ483Av2VAhs5V6zRhIloyxNWkn433Um4lDF HAiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771831675; x=1772436475; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=AH50fw9QTtdpPbt41EGIzTuypwuiZyQQHwG7B4PGWqg=; b=SY9X/WwBW9qaguPmaI/qMy85fVbtorhZqwa+dCTxn13cEccu1ud1yhddWgs7pop+SA 7gmkueQoOu3kI5uCEEKhDBAh8CpR8zHic9amRZ5f/46OVTaKHyXX2fH2CdnsozCUnGRJ +uYKii1KLTzm3V+AKkapvnjvcO3IR6nAobQjY/tTVHILT82LWrHskNFHJmlB5f0WUr4g UPfKJ6P1nC0wiSOtc7X/LMQozRJ5eydLgVYp/7aVFV9xmBNL24NBmlCZm+nmWUMuz5gt uO0GQgqr4fhs9DQkBKjeyEEnNMjfCEkFNcYKgQg8aP7KzqciM7iPkl8xRW82Cg0NZlP0 HUYQ== X-Forwarded-Encrypted: i=1; AJvYcCUCOj0qLtITQnGErwM3yV9Pcn8zeD3gZX0BF5xHMm/LUdz+yjWZYC0Pxl+JfYe9bvLciUqWjdgTW0x+cONdoA==@lists.infradead.org X-Gm-Message-State: AOJu0Yzf3wOhTXFhZl5Xpspzlxyn8viX+rCJwPO11v9wx2NfCfUaD/mR AKeLtL4QrWIVL7jf3t17s4Vr+hAvwcCYX4lnkx4nyjaNDeWA3wmRFyGZYaFeaA9Whir2b+flUcU j4Z4kC/V7NiksGzA3GK7W9yd7k/TSaqSsQZ+9l2gblVWAxQMLKr3uK6TCnjVIalsuiPNy+2Yzps E= X-Gm-Gg: AZuq6aKGCItbWAn72HCQuaQlQKhv4P6+chU9lxtTRnrYSjebyHoIZoEIdopG8QRiMoZ qrXjoKNofdeC+YB8z7OucVyI+Udvy3I7Pqkj/SUWLQkGpO6J3q4IDSXEfbtQXD1MRF05eShvcRm 88Ox19NieLVw9iJKyrhejXYbA99NBXnUbhdO0g2gwgYZsQCIcIBOkLarvF3zjCz5iBX0lRY9m8T BLh5ukP/HesHtlD8R7IPmixtkQ8eP/DgozBfltxNruOBFEGVcZG56hjCKO7sp67F8VIXUWKHHd4 SpW8wNF6022PjNXz2seTZvo9qlB/lEXFPJhFyyBM9ewAbOnN2F76ToTojoxgvKO4dBJYNpihwAB y3jkKuMF6ndKywmriKdyRfkXPWV748gsQ9Xjn9C21HqBm7g== X-Received: by 2002:a05:620a:25c7:b0:8c6:ed3d:be60 with SMTP id af79cd13be357-8cb8ca8926emr880337185a.71.1771831674953; Sun, 22 Feb 2026 23:27:54 -0800 (PST) X-Received: by 2002:a05:620a:25c7:b0:8c6:ed3d:be60 with SMTP id af79cd13be357-8cb8ca8926emr880334085a.71.1771831674487; Sun, 22 Feb 2026 23:27:54 -0800 (PST) Received: from [127.0.1.1] ([178.197.223.140]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43970bf9ff5sm18550286f8f.4.2026.02.22.23.27.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 22 Feb 2026 23:27:54 -0800 (PST) From: Krzysztof Kozlowski Date: Mon, 23 Feb 2026 08:27:33 +0100 Subject: [PATCH 5/9] power: supply: ipaq_micro: Simplify with devm MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260223-workqueue-devm-v1-5-10b3a6087586@oss.qualcomm.com> References: <20260223-workqueue-devm-v1-0-10b3a6087586@oss.qualcomm.com> In-Reply-To: <20260223-workqueue-devm-v1-0-10b3a6087586@oss.qualcomm.com> To: Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Jonathan Corbet , Shuah Khan , Tejun Heo , Lai Jiangshan , Tobias Schrammm , Sebastian Reichel , Andy Shevchenko , Dan Carpenter , Krzysztof Kozlowski , Lee Jones , Dzmitry Sankouski , Matthias Brugger , AngeloGioacchino Del Regno , Benson Leung , Tzung-Bi Shih Cc: driver-core@lists.linux.dev, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Sebastian Reichel , linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, chrome-platform@lists.linux.dev, Krzysztof Kozlowski X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=3021; i=krzysztof.kozlowski@oss.qualcomm.com; h=from:subject:message-id; bh=G2Qaq1IYTDtA8nYq8hb67ozAR45iYXNAROMWtKf03Uw=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBpnAFqVbGd+Oyd+isBnLp3Irn3IzZIFzgrOBn+8 5TEkaEct86JAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaZwBagAKCRDBN2bmhouD 1/PbEACD32lwshZ2ZGTfWR2j4TEzEqcr5UkWKivQj4l2BDJ3b0cx3v9UXC+uQpxEwQRsNqj0BvG I1fbqNt2AyWmkGgU5CQ/mctWF9CLx35r8IK/9NdFjOqcFxht4uwjb6upeBsp+J9Pv4HEfYA0wAN KTA7ic+gakOj5ORF0AX0XB+z9UwqeB8IbQrIH7214fJQfuMgYgOooGihxSqfiOsUPuOZ9ls5/dM epmwdKvIbeyOiwRprJ77lkVrp+OMFQXa7Z3PUu0SZkkyFzbd7PZxw1z192ZbcfxAarusRPDYPy3 wg9eYXwcNtW8bxgrkKEeFuuHIQYLM/XjrlvnAGGRttd3REFDczgFmq2NJxW17OOVDZeYCMfKj4U x50tsh+z6Y0ziwp0yrkLamVu++cpOHEeoets78gt/cg4eSkEFdA7Bm6o1PBYHVqPrYUMwYO3uzw jTyOPwQM3T2UT6UB95Cz2t5+dDzKC/lSPReC0bsI+qBURe6pUl4SOcPr44WISrvlDFn+uxccMAP cZ9tGiPuZpEGR4H7DnWR1quOQzOJwWZEQ/EbBXRzQS0zF1KAcc0gxH1sTluqtgGKh/1LOGDmNJk ILB2rMYlea2r74+WwfmYhcO0zntsIz41R1A3mBVMXjAxQHSN1RCq0uN/1cASc2WbfdgyvfjfE/z 84W99rJwWh793pg== X-Developer-Key: i=krzysztof.kozlowski@oss.qualcomm.com; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B X-Authority-Analysis: v=2.4 cv=YL6SCBGx c=1 sm=1 tr=0 ts=699c017b cx=c_pps a=wEM5vcRIz55oU/E2lInRtA==:117 a=6nO30s3o7FuWeffXwhKHTA==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=PkD0MmKtpR7JdVUpc-MA:9 a=QEXdDO2ut3YA:10 a=OIgjcC2v60KrkQgK7BGD:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-ORIG-GUID: 5QDhAFebLdODoOO89G33Adk_zd7dhlkE X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjIzMDA2NCBTYWx0ZWRfXwBqK2lieaHO+ 1p854bon+J2bWRtOfUYSTFgID/8Zn7mSeYaQ+tnT3UuYP2R1cbCqn7GqkY9dbdQH6ddnBtrUFuE qX/ZVczBShA090VfFCdE8F7rOvGwkIXHrTaovjU34fodAEP8e9tuc8Er4fjDJ3gI9TVp3pR+24X Oc3KaMbvg3hJGNLm/LFfHPe6DrmeAcTlHtD0/up01I/7aoQEohIaRww5a9ZefdjKFoTbYQ5d6me USmH9bLdTR/8bnzu/pvoNFhlI1tVGtCRIVFujkK+RrV1olB5XkNZVtMNqV4rs2gkYDQMJuWRQoz q2mgtQdpxjNIK99VjCP/WorIwYlQvdG39kwpfM1O3uzT7bhZd9qkBz33Cj9ikWoul58gJOpeRbj qylWUQMQRyxdDUz48mOyKMs34BSMwIwsmBfX7UhW2C2E9HV6NgxqfBisOlMhdCfLjSRG0qvasQf 6hzu4bx2K7qYOTDR39A== X-Proofpoint-GUID: 5QDhAFebLdODoOO89G33Adk_zd7dhlkE X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-23_01,2026-02-20_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 priorityscore=1501 lowpriorityscore=0 bulkscore=0 phishscore=0 impostorscore=0 suspectscore=0 clxscore=1015 spamscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2602230064 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260222_232756_747311_72EF1355 X-CRM114-Status: GOOD ( 16.60 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Simplify the driver by using devm interfaces, which allow to drop probe() error paths and the remove() callback. Signed-off-by: Krzysztof Kozlowski --- drivers/power/supply/ipaq_micro_battery.c | 50 ++++++++++--------------------- 1 file changed, 16 insertions(+), 34 deletions(-) diff --git a/drivers/power/supply/ipaq_micro_battery.c b/drivers/power/supply/ipaq_micro_battery.c index ff8573a5ca6d..5e3fe3852d0e 100644 --- a/drivers/power/supply/ipaq_micro_battery.c +++ b/drivers/power/supply/ipaq_micro_battery.c @@ -7,6 +7,7 @@ * Author : Linus Walleij */ +#include #include #include #include @@ -232,49 +233,31 @@ static int micro_batt_probe(struct platform_device *pdev) return -ENOMEM; mb->micro = dev_get_drvdata(pdev->dev.parent); - mb->wq = alloc_workqueue("ipaq-battery-wq", - WQ_MEM_RECLAIM | WQ_PERCPU, 0); + mb->wq = devm_alloc_workqueue(&pdev->dev, "ipaq-battery-wq", + WQ_MEM_RECLAIM | WQ_PERCPU, 0); if (!mb->wq) return -ENOMEM; - INIT_DELAYED_WORK(&mb->update, micro_battery_work); + ret = devm_delayed_work_autocancel(&pdev->dev, &mb->update, micro_battery_work); + if (ret) + return ret; + platform_set_drvdata(pdev, mb); queue_delayed_work(mb->wq, &mb->update, 1); - micro_batt_power = power_supply_register(&pdev->dev, - µ_batt_power_desc, NULL); - if (IS_ERR(micro_batt_power)) { - ret = PTR_ERR(micro_batt_power); - goto batt_err; - } + micro_batt_power = devm_power_supply_register(&pdev->dev, + µ_batt_power_desc, + NULL); + if (IS_ERR(micro_batt_power)) + return PTR_ERR(micro_batt_power); - micro_ac_power = power_supply_register(&pdev->dev, - µ_ac_power_desc, NULL); - if (IS_ERR(micro_ac_power)) { - ret = PTR_ERR(micro_ac_power); - goto ac_err; - } + micro_ac_power = devm_power_supply_register(&pdev->dev, + µ_ac_power_desc, NULL); + if (IS_ERR(micro_ac_power)) + return PTR_ERR(micro_ac_power); dev_info(&pdev->dev, "iPAQ micro battery driver\n"); return 0; - -ac_err: - power_supply_unregister(micro_batt_power); -batt_err: - cancel_delayed_work_sync(&mb->update); - destroy_workqueue(mb->wq); - return ret; -} - -static void micro_batt_remove(struct platform_device *pdev) - -{ - struct micro_battery *mb = platform_get_drvdata(pdev); - - power_supply_unregister(micro_ac_power); - power_supply_unregister(micro_batt_power); - cancel_delayed_work_sync(&mb->update); - destroy_workqueue(mb->wq); } static int __maybe_unused micro_batt_suspend(struct device *dev) @@ -303,7 +286,6 @@ static struct platform_driver micro_batt_device_driver = { .pm = µ_batt_dev_pm_ops, }, .probe = micro_batt_probe, - .remove = micro_batt_remove, }; module_platform_driver(micro_batt_device_driver); -- 2.51.0