From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6BF75F513E0 for ; Thu, 5 Mar 2026 21:46:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=n4xjjhrcSsGg/B56PKtYV9FcQh+keTvXc9MMcImQ6Q8=; b=kqEUjS0hxp0SOrGVGeKSAl5lCQ eBq+FCxvRcVtOnDKjNyShNZ6KK57F4eLLk1KH9ZR2ncy+JEJdK0xHHxO2WMQTLZiAdm4Xv6mjuNlc ScHcqxUR9N7rEWCBsSRGV+3qyppHyYjuGGr0Cs2pG2oNkp6/NcCJNhlnj1XZ14rf9oUcWTKLv6ojb K7SDCDoVDce3LgyEP/Xb+fJOxTaIBzTt/71G1U8MUAsAtB6k9KQihSNsVuXJGBrLpjmpbMfxHzDO0 YNSlAfiQZmjeHADMTPFdBKRabMOZ5PjUen7JrAU6gZbIFa6w0WYu8bd0QHMN+6n2tzItqcZKbGglm X2XYGqrQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vyGWm-00000002bSB-3oST; Thu, 05 Mar 2026 21:46:40 +0000 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vyGWi-00000002bJX-0XS2 for linux-mediatek@lists.infradead.org; Thu, 05 Mar 2026 21:46:37 +0000 Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 625Kn0A11810535 for ; Thu, 5 Mar 2026 21:46:35 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= n4xjjhrcSsGg/B56PKtYV9FcQh+keTvXc9MMcImQ6Q8=; b=nr4T+3ebr1GJrOG6 oJS1QoImgPAnuAAGCrayURKG6BxlosUfnXUwq/PWK6ywxT/K4BzCHSJlmRScuKc1 YDLEDC5EdgKDgnHIwOhbJ/ypifKbXb2fXrY1kSU4BqI/Xivne2zrKiU09upW9WEk hj8gxxcO8lu5OhvwP+/vBktvBJOdsqEsZ2M6GXGhPExJUogJ4BQCPR12z3cHFnqQ g+J7fjOh6uDcM3BbxgUZzqyeD5r8JJhyfVR6c5VcNNIFaFuyIrGZF1RpPoBQNJaC fxQ/UGt1g+KdbfOt/8gi4RDZ0HrqA1I61U2/o3j42lldLnNas1910ChS8YzrA/K0 OcGQZQ== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cqgp407pv-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 05 Mar 2026 21:46:34 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-8c71500f274so914058485a.1 for ; Thu, 05 Mar 2026 13:46:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772747194; x=1773351994; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=n4xjjhrcSsGg/B56PKtYV9FcQh+keTvXc9MMcImQ6Q8=; b=kvPihx0QJMmXao32aDAIHQRA/DD8HcK31hjRyvwr10bp435GyVkh/vQpZ0UDYvHf9j q/SKnR1KBJknUIxR/S0K7MtagA0yHQViWk5WHFglvGtz0wljDu/DD/JdjN1uAFmY+obl t+oEf4anXMAXX32uoVX1WjbADptfXGVx0BHilP8bWKblDKreF+p50vD4+CUf9xOq1o0+ gyMEt+l9xZ4DwQHKU2HVbK4jjgWt9iQMTYfx4b7vLt5Sfdal15achve51Bq7uSLz0xA/ fGQY42l14VUbpYATjuhGk9v4AEFwrgdXm4K/yWkBCLRjwzwabybwMbjGHBCKNEb86J8N AyHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772747194; x=1773351994; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=n4xjjhrcSsGg/B56PKtYV9FcQh+keTvXc9MMcImQ6Q8=; b=RqU2Ve08z/jbU7EGzuZ3COS2aWvrLR6xhijPEXcicp0KO0VQ72OPc2K/uTJjLsUSE3 dfiF9VY1wlj+LE3Do2QW1QZpOtVip8K1m5BRJ2Rgde/nWrZezXHFkUkdw0sfQWrojdPO ft9px/B9/xfq0puX4JmXh6rDxcQEzvdkVg4Mjatb0yBQ58C9a7XPNBjdrYUbEhHc1+vk Rzg01v/5Ceu/5x4WUVgPLqdPGUzC2wR7RX2XM35C3fbIVFQupTOyOMuBJVWSEqunXVV0 EtedfZZBhnB9xnahmDDH/FitCJg+w9hNp6I+NdUL3AqBU+jolEq7Cr7zFOtlLMH3zaPu 5U1g== X-Forwarded-Encrypted: i=1; AJvYcCW88U6P/fNfqREd8yywgtDoUd6KzX+t78tKcRc0JpFBhl025hWcshiZVowlIxqWRlE7freCUiShb2arw1NDQw==@lists.infradead.org X-Gm-Message-State: AOJu0Yw3UB3oh4KQ9vCDgSWimU2oMbuZGegTfc2cfIhrFiVYTBeuOFVP F4w1lCs2UgHLg7m/z22V79Mw3Ojb2NcFMV8sW4gIDKd+pqV1v3YMx7W6xji/PGbgmrPdDE3ZB05 BzDjMVW695AeitXj37UVPXaaBDMkoM1BYIDwK6/hoR3GS6wwuU7PBNBg7JMyl6hsjULV7dPRvui 8= X-Gm-Gg: ATEYQzxDQchfD6EWw8odIwOLQnrxJMvulB/5CG3NNpZfC9unFjp2DM/6USzfh+PBDsM WvoW/gfAxsLW/6WuXXfavo2BfopCyO5Fkg4ODR9eY8DNB6CGnsUJISRHjMc7AuYiHl6z80MPiMk 1VS2S2tCIH+3N8bJd1FEm7CmvczGSdhB72l7N6i2Fh5jtARgHpkc3lj7YdUR3HF0/myz0F+TNdI wN51X2sQsJ3ja0w5vfev8qWeoV6hVltbeGkir+V0lENMildJdQN3T0tUbqA/nUflohMqcPAOpMM MykoSUVlzRZY5W+PLkcIKcZD8eXmvkKWrd+R+64IKeVbcZthE4hz+bXl5P1uphstdToG7nUqyR4 YDHfWi+WQWQsa1nGAVuiI9PJLLlAlVatlkCn1UTTrcPpa X-Received: by 2002:a05:620a:2806:b0:8c7:9e6:3a72 with SMTP id af79cd13be357-8cd6d31f36emr6488385a.6.1772747194117; Thu, 05 Mar 2026 13:46:34 -0800 (PST) X-Received: by 2002:a05:620a:2806:b0:8c7:9e6:3a72 with SMTP id af79cd13be357-8cd6d31f36emr6484285a.6.1772747193616; Thu, 05 Mar 2026 13:46:33 -0800 (PST) Received: from [127.0.1.1] ([178.197.219.94]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439ba2a58dasm28571575f8f.27.2026.03.05.13.46.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Mar 2026 13:46:32 -0800 (PST) From: Krzysztof Kozlowski Date: Thu, 05 Mar 2026 22:45:47 +0100 Subject: [PATCH v2 08/10] mfd: ezx-pcap: Return directly instead of empty gotos MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260305-workqueue-devm-v2-8-66a38741c652@oss.qualcomm.com> References: <20260305-workqueue-devm-v2-0-66a38741c652@oss.qualcomm.com> In-Reply-To: <20260305-workqueue-devm-v2-0-66a38741c652@oss.qualcomm.com> To: Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Jonathan Corbet , Shuah Khan , Tejun Heo , Lai Jiangshan , Tobias Schrammm , Sebastian Reichel , Andy Shevchenko , Dan Carpenter , Krzysztof Kozlowski , Lee Jones , Dzmitry Sankouski , Matthias Brugger , AngeloGioacchino Del Regno , Benson Leung , Tzung-Bi Shih Cc: Matti Vaittinen , driver-core@lists.linux.dev, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Sebastian Reichel , linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, chrome-platform@lists.linux.dev, Krzysztof Kozlowski X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1584; i=krzysztof.kozlowski@oss.qualcomm.com; h=from:subject:message-id; bh=aBbZ3fBywOvpHZwjLuwnPh4cf1hQWBZWB8iOkYD1Dl0=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBpqfmfZyTBQ2+zfg1PVbm//IV3ttzRuDFXfJ09L Fi7SOtMm4iJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaan5nwAKCRDBN2bmhouD 13yRD/9atq9XS2gdzOD4iwNE2NzTH/fSxgzEasdtz+9zZKfFoTpfnxFWtJTbN7SumZgig525A5R VdZmzIWGbcYZpE3xAn4xsvjLbNB8/GeTpJ1kt8T1rcPPpX94dr5Ht/K5pRdjnVycWFPiKJXtfcA iRY5/XOeIZEhXpU7ClLZTrejxnGjsURe8r+u+LlmWrGlfT4VYT4yepmb5E8OIVDUXnlKFEepRKQ WYPZ09Oyl21MABeuojbxhRPxzoA/jzjdLe+iCBVzlFihUMfiFrrWvfX872J1GXClSLlGaYFGLeA VYOoHJFuO57Q7+4oULKXpzkUTIexLmRp3dGkkprPpzpR0q6+gCsLVeSHJfIl54kgDeKlSJVa4tP 3tx68crLjDIkHq147LN+7Nlv1yacTQ1Drn3PPXGsOwNHTmOkKt6eoO1tJSU8dItyVB3VdAVUtW5 YLK5tSgOKhSGndBJaJennrnsayMckl9rhJer7AXlC+sKZ31Ii2uZY9DFB4tGUXtmtDRpX+Nnw1u mTECOe4Qt/1YAn962XvbBJjzoZWliJdxuREn2dZiFlamnSKzxS8Tk9zX12OJI6nHFFiZNZESZ3L 13YIinDTo1FuLh5Fosug3FzrBQlUb6CCIR4714nwcgAQpBhwwMlKDWA4q46CeQ1kxUm2ocxmk0m CC5zMWv80d+IrUw== X-Developer-Key: i=krzysztof.kozlowski@oss.qualcomm.com; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B X-Proofpoint-ORIG-GUID: VfFf3UMyMEJJMhJZyDOv7FphjiVFHZOL X-Authority-Analysis: v=2.4 cv=LegxKzfi c=1 sm=1 tr=0 ts=69a9f9ba cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=gOEeR9iKwsj33Yj5oN/cWg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=VGyNsPSQNFFz0_f43M8A:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA1MDE4NSBTYWx0ZWRfX67CxUed2SVyV 0zvOrHoVzavKGE4zXTqgvcU8yl/Q0JkVuVVh7UIFQao35z9IWnS9ie2XZMi5O46nCOFOp30OLY7 WNgTE6QoszUu92x5/H/Tz/l6QLInlzZZkb/ru6IFOkOHwWF4s9GXvGTPp5bezpuSN35sYpECa1z O6Z7IHsrUAueHBkgFZoGoaM2v+Br+MQItmWrhjwktKyd+iujvZBsjyVxBNfRr+r1nQiG0/dUvsX SW8fEdCbaopK8PGPQuSOBBkrvvDDLElK+pRQ6ldLts6dCZAbs6PmrDG8aEwkvFG67Fk4Y3qDH24 5lR9z1EXVEcmQ2JH2NpGoZQzii86Jv6BQGWfablYUpIDn1MG/TllPjjoTFodiZ5NAa2iSsLb1gX AhRNBYMC3OqzvFTR8Irp3fKvUUAlR6UconcVLQYtgjPP0hcQL20auZUn7gYa+w5oWELmpwbeEeP 9uYGaPKaF0nP1hcoeQA== X-Proofpoint-GUID: VfFf3UMyMEJJMhJZyDOv7FphjiVFHZOL X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-05_06,2026-03-04_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 impostorscore=0 malwarescore=0 adultscore=0 lowpriorityscore=0 priorityscore=1501 phishscore=0 bulkscore=0 spamscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603050185 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260305_134636_413983_2BB9DE4C X-CRM114-Status: GOOD ( 16.11 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Code is easier to read if empty error paths simply return, instead of jumping to empty label doing only "return ret". Signed-off-by: Krzysztof Kozlowski --- drivers/mfd/ezx-pcap.c | 18 +++++++----------- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/drivers/mfd/ezx-pcap.c b/drivers/mfd/ezx-pcap.c index cd0520a08224..8e51c113a320 100644 --- a/drivers/mfd/ezx-pcap.c +++ b/drivers/mfd/ezx-pcap.c @@ -384,17 +384,15 @@ static int ezx_pcap_probe(struct spi_device *spi) struct pcap_platform_data *pdata = dev_get_platdata(&spi->dev); struct pcap_chip *pcap; int i, adc_irq; - int ret = -ENODEV; + int ret; /* platform data is required */ if (!pdata) - goto ret; + return -ENODEV; pcap = devm_kzalloc(&spi->dev, sizeof(*pcap), GFP_KERNEL); - if (!pcap) { - ret = -ENOMEM; - goto ret; - } + if (!pcap) + return -ENOMEM; spin_lock_init(&pcap->io_lock); spin_lock_init(&pcap->adc_lock); @@ -407,17 +405,15 @@ static int ezx_pcap_probe(struct spi_device *spi) spi->mode = SPI_MODE_0 | (pdata->config & PCAP_CS_AH ? SPI_CS_HIGH : 0); ret = spi_setup(spi); if (ret) - goto ret; + return ret; pcap->spi = spi; /* setup irq */ pcap->irq_base = pdata->irq_base; pcap->workqueue = create_singlethread_workqueue("pcapd"); - if (!pcap->workqueue) { - ret = -ENOMEM; - goto ret; - } + if (!pcap->workqueue) + return -ENOMEM; /* redirect interrupts to AP, except adcdone2 */ if (!(pdata->config & PCAP_SECOND_PORT)) -- 2.51.0