From: Bjorn Helgaas <helgaas@kernel.org>
To: Chen-Yu Tsai <wenst@chromium.org>
Cc: "Matthias Brugger" <matthias.bgg@gmail.com>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"Ryder Lee" <ryder.lee@mediatek.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
"Manivannan Sadhasivam" <mani@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Bartosz Golaszewski" <brgl@bgdev.pl>,
linux-pci@vger.kernel.org, linux-mediatek@lists.infradead.org,
linux-kernel@vger.kernel.org,
"Bartosz Golaszewski" <bartosz.golaszewski@oss.qualcomm.com>
Subject: Re: [PATCH v3 5/7] PCI: mediatek-gen3: Integrate new pwrctrl API
Date: Fri, 6 Mar 2026 13:21:34 -0600 [thread overview]
Message-ID: <20260306192134.GA142888@bhelgaas> (raw)
In-Reply-To: <20260302053109.1117091-6-wenst@chromium.org>
On Mon, Mar 02, 2026 at 01:31:05PM +0800, Chen-Yu Tsai wrote:
> With the new PCI pwrctrl API and PCI slot binding and power drivers, we
> now have a way to describe and power up WiFi/BT adapters connected
> through a PCIe or M.2 slot, or exploded onto the mainboard itself.
>
> Integrate the PCI pwrctrl API into the PCIe driver, so that power is
> properly enabled before PCIe link training is done, allowing the
> card to successfully be detected.
> ...
> @@ -1211,9 +1222,13 @@ static int mtk_pcie_probe(struct platform_device *pdev)
> pcie->soc = device_get_match_data(dev);
> platform_set_drvdata(pdev, pcie);
>
> + err = pci_pwrctrl_create_devices(pcie->dev);
AFAICT this has nothing at all to do with mediatek-gen3; it only has
to do with the fact that the platform provides a way to control the
main power to endpoints that happen to be connected to it. Are we
going to have to add this in every single native host controller
driver?
next prev parent reply other threads:[~2026-03-06 19:21 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-02 5:31 [PATCH v3 0/7] PCI: mediatek-gen3: add power control support Chen-Yu Tsai
2026-03-02 5:31 ` [PATCH v3 1/7] PCI: mediatek-gen3: Clean up mtk_pcie_parse_port() with dev_err_probe() Chen-Yu Tsai
2026-03-02 5:31 ` [PATCH v3 2/7] PCI: mediatek-gen3: Add error path for probe and resume driver callbacks Chen-Yu Tsai
2026-03-02 5:31 ` [PATCH v3 3/7] PCI: mediatek-gen3: Split out device power helpers Chen-Yu Tsai
2026-03-02 5:31 ` [PATCH v3 4/7] PCI: mediatek-gen3: Disable device if further setup fails Chen-Yu Tsai
2026-03-02 5:31 ` [PATCH v3 5/7] PCI: mediatek-gen3: Integrate new pwrctrl API Chen-Yu Tsai
2026-03-06 19:21 ` Bjorn Helgaas [this message]
2026-03-09 6:04 ` Manivannan Sadhasivam
2026-03-06 20:59 ` Bjorn Helgaas
2026-03-09 5:24 ` Chen-Yu Tsai
2026-03-09 21:50 ` Bjorn Helgaas
2026-03-10 4:49 ` Chen-Yu Tsai
2026-03-20 6:10 ` Chen-Yu Tsai
2026-03-23 19:08 ` Bjorn Helgaas
2026-03-24 5:01 ` Chen-Yu Tsai
2026-03-02 5:31 ` [PATCH v3 6/7] arm64: dts: mediatek: mt8195-cherry: add WiFi PCIe and BT USB power supplies Chen-Yu Tsai
2026-03-02 5:31 ` [PATCH v3 7/7] arm64: dts: mediatek: mt8195-cherry-dojo: Describe M.2 M-key NVMe slot Chen-Yu Tsai
2026-03-05 11:25 ` (subset) [PATCH v3 0/7] PCI: mediatek-gen3: add power control support Manivannan Sadhasivam
2026-03-05 12:43 ` AngeloGioacchino Del Regno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260306192134.GA142888@bhelgaas \
--to=helgaas@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=bartosz.golaszewski@oss.qualcomm.com \
--cc=bhelgaas@google.com \
--cc=brgl@bgdev.pl \
--cc=kwilczynski@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=robh@kernel.org \
--cc=ryder.lee@mediatek.com \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox