From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A2DDB106FD60 for ; Fri, 13 Mar 2026 01:21:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=OXTxns2W6eSGRy0mEIfIG3dXjhp8eWYjTL0mDhCObM8=; b=rLMK8vDJAQlzmVJac5lgrYyMYf PcHBTULzjXyB47sj3sVzMImkqRppwPMGdqXrvExXLgau5uy+I6IbjxSKXPx1G3GQ9PxCPUcogUQmE PkYY6PKH2h685ma0X+AtiYX6Y0203lniCVWywa9cSBi1clp7TMWszWDiK0QVq35qmmWE36vQZp7k9 6gorQmuRhd1Gtludf5JBsEGix1Zwe0TCVH2ItOXjG2mPWkn6ZQTTEFJghsZiL9sF6GWZs/xZfujQ1 Ovmp8DqGzVYfJIgVbslbGKfUtwAetRwagwMA92yL3a/IIwclq3pj3lIduyTtc2Qbu9mrIrSpmsy7v KfB8ERng==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1w0rDZ-0000000G40m-1l15; Fri, 13 Mar 2026 01:21:33 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1w0rDW-0000000G3zx-125A; Fri, 13 Mar 2026 01:21:31 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id BACE9407A1; Fri, 13 Mar 2026 01:21:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 31556C4CEF7; Fri, 13 Mar 2026 01:21:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773364889; bh=RT5cCoFd51XlFsbavm43RBi3zqtF/Bni3O89ezyTihQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=lKrIEJvi88ynMx73j9D6v1S2E/u0ZviHUojbpcdcohUAxa2J6HsjbBv5IzZ4Sivbe quWYsKvkiatSCzdjRsht3U5CsSpu8huhGkl9jwjdhYL1L24uI05irsbEz/AcmKJgdQ XvHigJGItZOyb0TCkmI7qVMKh0unkdPu1+0Gtl8z7sQYDw24+9EEs4jjBARFoBAoIc nfxqxA/XKs7V5GNkHLk+P69jGQpRhnTE2sbrY0JHhBcasCsX4k1xTmuXxFBIOakVtO 8PyL2QvmusaSNiXHDaE1Ti1Ks/i9wSYMDAkHJ0v6An4cNtZUeGYjDzfgniFNptYGES tKrIBzyC5F/RA== Date: Thu, 12 Mar 2026 18:21:28 -0700 From: Jakub Kicinski To: Lorenzo Bianconi Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Paolo Abeni , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, netdev@vger.kernel.org Subject: Re: [PATCH net-next] net: airoha: Remove airoha_dev_stop() in airoha_remove() Message-ID: <20260312182128.33d2d88c@kernel.org> In-Reply-To: <20260311-airoha-remove-ndo_stop-remove-v1-1-596fe853b2e1@kernel.org> References: <20260311-airoha-remove-ndo_stop-remove-v1-1-596fe853b2e1@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260312_182130_340203_90630D12 X-CRM114-Status: UNSURE ( 7.01 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Wed, 11 Mar 2026 10:54:57 +0100 Lorenzo Bianconi wrote: > Do not call airoha_dev_stop routine explicitly in airoha_remove() > since it is already executed by unregister_netdev() if necessary This one is a fix I think? We underflow the atomic if the port is already down. Once again, commit message way too terse :( -- pw-bot: cr