From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 65D11109318E for ; Fri, 20 Mar 2026 08:36:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=qXG8BAgH6blcllbAK08/5QVe84xrvs515ihEMjIbAPQ=; b=sgTrEAotzwssdYZZwUlCnK7FKh GhtDDQf7vbM0qOEZB6V0b9wwOuLoDEJj8W3WouxW7e0bhobHxgPcHf7sUOlOxm9j0PWP5Vbc0OTpw Ku7W1hDVQhdVFd9AKf9s5TjOmw0wN6Yt+YwJz7VkiNLY/7DR9OE+cH46gFUlHuSdzBgX2VWyE/Av4 DjGmILynDy7DcJ6ArfDP71p0F21MwOxsxHTmQosQWJSn+dgFTjCo3iIsE1wasfqXkIdZI32A9LaNi u5f08xKROxxVZp+serGqOOa/e+/gV1EYQrGNmg6X59L/DonS9Is5RxH1Z8k0EeoYjp6X6yVvosfMS hqth93Ag==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1w3VKs-0000000CMgx-1NQu; Fri, 20 Mar 2026 08:36:02 +0000 Received: from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1w3VKp-0000000CMgj-2xjb; Fri, 20 Mar 2026 08:36:00 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id BF06F60121; Fri, 20 Mar 2026 08:35:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A4C5BC2BCAF; Fri, 20 Mar 2026 08:35:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773995758; bh=EXYMoywbEg6I7ipMKu2B+8UWo6AsK3Ubq2SrweO67HA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jvuq5Xp6UseMUOiaEpPby4k95jxighut/b4DZJTsuIwWnYgTLOvL0TQjn2MzwgcZF hX28dbGQb0hcuVyKHgoN3lb9yVlMlyxeVfuyOZhGBJb0OW5UGQ0clrbWZvBGLRDVt4 OMtDfW3MNrO9ucsDZXekMlHrKzRvrMm6WPpfLRqSXAA4+wX0jWYNdYfHB6VBq1wqEE +RhpJ+UWkuKqYbwB7BlLYdt0Nx2PpmrFtFmUWJ0Pibig+cHLF6UXOWsWQ1r8DlSu2x x4+WIqhoOd+XXxTSlQNK89qR2ubrZyjMNx8G9f0lhyug9OANWpYKlKrv3dWWB6u41b rJx34QdM0kM7g== Date: Fri, 20 Mar 2026 08:35:54 +0000 From: Simon Horman To: Lorenzo Bianconi Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, netdev@vger.kernel.org Subject: Re: [PATCH net-next] net: airoha: Reset PPE cpu port configuration in airoha_ppe_hw_init() Message-ID: <20260320083554.GB1753385@horms.kernel.org> References: <20260317-airoha-fix-ppe-def-cpu-v1-1-338533d8e234@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260317-airoha-fix-ppe-def-cpu-v1-1-338533d8e234@kernel.org> X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Tue, Mar 17, 2026 at 05:40:47PM +0100, Lorenzo Bianconi wrote: > Before this patch, the PPE cpu port configuration used for a specific GDM > device was set just running ndo_init() callback during the device > initialization. The selected PPE cpu port configuration depends on the QDMA > block assigned to the GDM port. The QDMA block is selected according to > the GDM port LAN/WAN configuration as specified in the commit > '8737d7194d6d ("net: airoha: select QDMA block according LAN/WAN > configuration"). However, the user selected PPE cpu port configuration can > be different with respect to the one hardcoded in the NPU firmware binary. > The hardcoded NPU PPE cpu port configuration is loaded initializing the PPE > engine running the NPU ops ppe_init() callback in airoha_ppe_offload_setup > routine (this is executed at runtime by the netfilter flowtable > infrastructure during flow offloading). > Reset the PPE cpu port configuration in airoha_ppe_hw_init routine in > order to apply the user requested setup according to the device DTS. > Please note this patch is fixing an issue not visible to the user (so we > do not need to backport it) since airoha_eth driver currently supports just > the internal phy available via the MT7530 DSA switch and there are no WAN > interfaces officially supported since PCS/external phy is not merged > mainline yet (it will be posted with following patches). > > Signed-off-by: Lorenzo Bianconi Hi Lorenzo, Thanks for the detailed commit message. Reviewed-by: Simon Horman