From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C81F2CD37B9 for ; Mon, 11 May 2026 10:50:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=AEcqQdxhuFVXx7OvJFukLBeh46o9QjwdgurNQ0HzpJc=; b=ZIhH7XrUwE8KhIvt15zc5MxcHr iFQBJbf+kr6psJxuDTQlc3sPaTWgl0xRtCzvRuZLMsdksxXgzaUQ90cwstpLZmooFD47HaewXW0c8 8EVoeIxgadTzPuR14/3WCl56ogvTcjt1EEeyzyvY1BSFR1ICqZdVUE6csO8fAmpCBcylZiW9Y4Lw7 zHjkG4Vfg+JP8+BxAsI9XJvMg7V5lMjQprtVDt6uEuNZcQyc9qBDumLoXUDoPoOfDUwG5QShMJXxI ALu7SCafcKK6ItCxEypf3vmOfiOxwmnsRPJRzXrfnr9pfVpfi7O0htbXULpO9KvarMlxSBNZ/ab6E P9XVSllg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wMOD3-0000000DA6x-3Vei; Mon, 11 May 2026 10:50:01 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wMOCz-0000000DA2J-12ev; Mon, 11 May 2026 10:49:57 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id B09F760120; Mon, 11 May 2026 10:49:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 13554C2BCFA; Mon, 11 May 2026 10:49:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778496596; bh=GtTOCUnQPmRi1bdY3r2oyNNR2Jf+SjIm6GiVXh4YsaU=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=GSms5RNqkNhlpdXvq5TB2KG/fRLLNTupXApZr7dBsn1q7uP9iL1tz+MyEi0HhYcht RsxfTgcMf0DvAci4ILETh/P/LsaroXhEZlEkX+r4jxgSjdJLBenCx/kmBt8wQ3Oy6I uQ7oCgBNmNTRBjn1A4HxRGoRa3yRv28Dms5hiDbxSd5XzG9mLw+F2dSV8mYmKXEyP/ pDlyLvwqmi6fn2M0ggQjC3t9xNhe6Tz7YtU1/xgPMUL8NUglyxfAOcKzutOZbyIpKs KY+c8GBOoPVBJING2Pgbydf9/Zt6ajG4qaho41j9fFtuDIpkhQO20K+0FTot1emASo lprq6K+vknpKg== From: Lorenzo Bianconi Date: Mon, 11 May 2026 12:49:28 +0200 Subject: [PATCH net-next v6 02/12] net: airoha: Reserve RX headroom to avoid skb reallocation MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260511-airoha-eth-multi-serdes-v6-2-c899462c4f75@kernel.org> References: <20260511-airoha-eth-multi-serdes-v6-0-c899462c4f75@kernel.org> In-Reply-To: <20260511-airoha-eth-multi-serdes-v6-0-c899462c4f75@kernel.org> To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Lorenzo Bianconi Cc: Christian Marangi , Benjamin Larsson , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, Xuegang Lu X-Mailer: b4 0.14.3 X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Reserve NET_SKB_PAD + NET_IP_ALIGN bytes of headroom for received packets to avoid skb head reallocation when pushing protocol headers into the skb. Tested-by: Xuegang Lu Signed-off-by: Lorenzo Bianconi --- drivers/net/ethernet/airoha/airoha_eth.c | 12 ++++++++---- drivers/net/ethernet/airoha/airoha_eth.h | 2 ++ 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/airoha/airoha_eth.c b/drivers/net/ethernet/airoha/airoha_eth.c index f71fb18197ec..3fe2561c85f1 100644 --- a/drivers/net/ethernet/airoha/airoha_eth.c +++ b/drivers/net/ethernet/airoha/airoha_eth.c @@ -543,9 +543,10 @@ static int airoha_qdma_fill_rx_queue(struct airoha_queue *q) q->queued++; nframes++; + offset += AIROHA_RX_HEADROOM; e->buf = page_address(page) + offset; e->dma_addr = page_pool_get_dma_addr(page) + offset; - e->dma_len = SKB_WITH_OVERHEAD(q->buf_size); + e->dma_len = SKB_WITH_OVERHEAD(AIROHA_RX_LEN(q->buf_size)); val = FIELD_PREP(QDMA_DESC_LEN_MASK, e->dma_len); WRITE_ONCE(desc->ctrl, cpu_to_le32(val)); @@ -616,8 +617,9 @@ static int airoha_qdma_rx_process(struct airoha_queue *q, int budget) page = virt_to_head_page(e->buf); len = FIELD_GET(QDMA_DESC_LEN_MASK, desc_ctrl); - data_len = q->skb ? q->buf_size - : SKB_WITH_OVERHEAD(q->buf_size); + data_len = q->skb + ? AIROHA_RX_LEN(q->buf_size) + : SKB_WITH_OVERHEAD(AIROHA_RX_LEN(q->buf_size)); if (!len || data_len < len) goto free_frag; @@ -627,10 +629,12 @@ static int airoha_qdma_rx_process(struct airoha_queue *q, int budget) port = eth->ports[p]; if (!q->skb) { /* first buffer */ - q->skb = napi_build_skb(e->buf, q->buf_size); + q->skb = napi_build_skb(e->buf - AIROHA_RX_HEADROOM, + q->buf_size); if (!q->skb) goto free_frag; + skb_reserve(q->skb, AIROHA_RX_HEADROOM); __skb_put(q->skb, len); skb_mark_for_recycle(q->skb); q->skb->dev = port->dev; diff --git a/drivers/net/ethernet/airoha/airoha_eth.h b/drivers/net/ethernet/airoha/airoha_eth.h index 58530d096de7..d3781103abb5 100644 --- a/drivers/net/ethernet/airoha/airoha_eth.h +++ b/drivers/net/ethernet/airoha/airoha_eth.h @@ -32,6 +32,8 @@ #define AIROHA_FE_MC_MAX_VLAN_TABLE 64 #define AIROHA_FE_MC_MAX_VLAN_PORT 16 #define AIROHA_NUM_TX_IRQ 2 +#define AIROHA_RX_HEADROOM (NET_SKB_PAD + NET_IP_ALIGN) +#define AIROHA_RX_LEN(_n) ((_n) - AIROHA_RX_HEADROOM) #define HW_DSCP_NUM 2048 #define IRQ_QUEUE_LEN(_n) ((_n) ? 1024 : 2048) #define TX_DSCP_NUM 1024 -- 2.54.0