From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 85AF0CD98F7 for ; Thu, 18 Jun 2026 12:58:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:To:From:Reply-To: Cc:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=puwAHt6DIGuC1Wf1TrT+M8/3nufhWyiZt6erLHCVM5o=; b=B9HIyVXlcrIS66vEw8HCl/WF0f D0VD9qs7Bg8kO0/RAjaxjI4DCX0yilk5/Jn00pCjFnvZUoMrgU/GutPQIAfQjxNHrjuEs0bPyxA96 F5T5lePmBdFW58LV+bcizF+y3HZI++SfsKkK8orfuwudJy2evU3QhyYAKhwz5sucK58o+CHh+jfSa b00z1BS6a89V3jWW4NNkbYJgu7emFiVlFnG33qgf3fV6tzKwgWyl2shfrLLKHWvWJxEK8yUzyzVpy d9VHGlRAS9wuWblpWfHvyy2t8sx4HDzS31sNuFs/zhLctwg5nLmDvv+keXC3CXIrf9dNrKiwI21Mv TreSqsuA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1waCK7-00000001ILX-28DL; Thu, 18 Jun 2026 12:58:23 +0000 Received: from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1waCK1-00000001IEA-27cT for linux-mediatek@lists.infradead.org; Thu, 18 Jun 2026 12:58:18 +0000 Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-4921eed3fa2so6775405e9.0 for ; Thu, 18 Jun 2026 05:58:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781787496; x=1782392296; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=puwAHt6DIGuC1Wf1TrT+M8/3nufhWyiZt6erLHCVM5o=; b=UDiAkYWqILdRaFD/DZFAqrORi2rEfW6pPWSAFK6p8ocFNGBoPn162302HXVTHGxOWS 87byp4pw3Sn2jKgSTWDSmCwp69Ow7JRZd4seLpyzGwV4bHdTd4Joe3LQVff0cT8aw4Uh dUQin7Lnj2knreN85GE7Z4DpLaCxlQqj12wd23RaBEfGWfMSAFvPU7i5RdnlUSnBc9R8 Wk4klG64te+oDwS5Z1BqqX1uld1X/f40egJ0fD+ynrltiGByR35UPQr+tpJOU+PEZefr kCJsE54hupV7yNk5+mm7AJC8r6SL821+rfsVRmumW4hnlkwJL68ZTgDfqhpa3Hh2I7bi iT6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781787496; x=1782392296; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=puwAHt6DIGuC1Wf1TrT+M8/3nufhWyiZt6erLHCVM5o=; b=QDS+nwNOaBRoUubDh28570e+WD9qkKXTfHlcW7ClTjIAPHDX28H9+sVS2ss1lIqSoT 2YyYyC5ainatKinRoMu01k5C+Iv4vUL2II7MNmRd6sqHFBhwEPHlRYGCkUr5WKy0CKMD 8pQ4udaHaKAoI4ukSvOgdYh24tJCPkLNfS6+RaSetrHV6pBO7kMnXw3mwPB2LwCZ1r6V 0O8I1PvuZflgsciyZxVzVMEzgM6Xr1K3/XRyCocptQkTLIaBsZ2T4UlvlbK9e370uY4K E6zAyVDYv6tGC6zE+resagtIGZGB4tqwgq3Ns2bhBdFajhyMRpEg5Jchi5GV/8k2ZHis jg/g== X-Forwarded-Encrypted: i=1; AFNElJ/WraiCBjVq/FvdIHM+jXDyy2sB5nktGEfUlyJthzgCycp+k2GFr2ty74bftxVXcN6JkwPOUFWKFcU5wX0xTA==@lists.infradead.org X-Gm-Message-State: AOJu0YzM5bdCKaxWMpJ7sHUYSxxqIhU5dMYPQ9dyeytzQt1Dy6zbXsRX TbMd8q6NqISI9rf6jJU/oVwOmhvUzL7cwKovIeZ4TKvOCmUDXdmTRLM7 X-Gm-Gg: AfdE7clLagmCpoMrSQzHjXD90qTg8VQGMknkYRhaK6fuPMH04YUeCND35bLaMEH+O1o 9iqtCIDJKCamnQjhmQ8g4XT4HdfhOrmS09O8jAm/7eXs3uLWJePO8XMm9wb1I2wulxf17GTXrKG 4WjTZonBu9pAPBrX/adQUc5BUnJNESHXy11I2o0SG1P0Y9pJAM3P9UprnII9KWEDzCPO6Gqz/Ni No2vUdIg8XDU0NPm8gaFkH/vkM1Vps4yzsSNWjbJyg40umZIsOmYguZWYwJAgxMylsTv+GAvHv/ gqHolOnMP5bYPAd+CnR517mqNVpdyIA4GFY+15lHmMpcDsCD14/9m0pcIoaGzUiN9+bN2OazMo5 1fP1yL3yMDdgtvjLXwt9TzuRKm2lo/yaUs42ks2YQKoxGmByAZTgPWRsRGhhYWWluEi0DtRnWoB C/a7yYZNWhM5Wu46ods1dbg3r/VZHSES02WOA/Oy/wcA889PVs9o4Q4eBujx1aoA== X-Received: by 2002:a05:600c:5644:b0:490:adb6:7957 with SMTP id 5b1f17b1804b1-49234141d98mr89030975e9.33.1781787495577; Thu, 18 Jun 2026 05:58:15 -0700 (PDT) Received: from Ansuel-XPS24.localdomain (93-34-88-103.ip49.fastwebnet.it. [93.34.88.103]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-49230a458f2sm241451585e9.3.2026.06.18.05.58.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Jun 2026 05:58:15 -0700 (PDT) From: Christian Marangi To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Simon Horman , Jonathan Corbet , Shuah Khan , Christian Marangi , Lorenzo Bianconi , Heiner Kallweit , Russell King , Saravana Kannan , Philipp Zabel , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, llvm@lists.linux.dev, Maxime Chevallier Subject: [RFC PATCH net-next v8 03/12] net: phylink: add phylink_release_pcs() to externally release a PCS Date: Thu, 18 Jun 2026 14:57:11 +0200 Message-ID: <20260618125752.1223-4-ansuelsmth@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260618125752.1223-1-ansuelsmth@gmail.com> References: <20260618125752.1223-1-ansuelsmth@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260618_055817_583770_AC05C0A5 X-CRM114-Status: GOOD ( 21.89 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Add phylink_release_pcs() to externally release a PCS from a phylink instance. This can be used to handle case when a single PCS needs to be removed and the phylink instance needs to be refreshed. On calling phylink_release_pcs(), the PCS will be removed from the phylink internal PCS list and the phylink supported_interfaces value is reparsed with the remaining PCS interfaces. Also a phylink resolve is triggered to handle the PCS removal. The flag force_major_config is set to make phylink resolve reconfigure the interface (even if it didn't change). This is needed to handle the special case when the current PCS used by phylink is removed and a major_config is needed to propagae the configuration change. With this option enabled we also force mac_config even if the PHY link is not up for the in-band case. Signed-off-by: Christian Marangi --- drivers/net/phy/phylink.c | 56 +++++++++++++++++++++++++++++++++++++++ include/linux/phylink.h | 2 ++ 2 files changed, 58 insertions(+) diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c index c38bcd43b8c8..064d6f5a06da 100644 --- a/drivers/net/phy/phylink.c +++ b/drivers/net/phy/phylink.c @@ -158,6 +158,8 @@ static const phy_interface_t phylink_sfp_interface_preference[] = { static DECLARE_PHY_INTERFACE_MASK(phylink_sfp_interfaces); static void phylink_run_resolve(struct phylink *pl); +static void phylink_link_down(struct phylink *pl); +static void phylink_pcs_disable(struct phylink_pcs *pcs); /** * phylink_set_port_modes() - set the port type modes in the ethtool mask @@ -918,6 +920,60 @@ static void phylink_resolve_an_pause(struct phylink_link_state *state) } } +/** + * phylink_release_pcs - Removes a PCS from the phylink PCS available list + * @pcs: a pointer to the phylink_pcs struct to be released + * + * This function release a PCS from the phylink PCS available list if + * actually in use. It also refreshes the supported interfaces of the + * phylink instance by copying the supported interfaces from the phylink + * conf and merging the supported interfaces of the remaining available PCS + * in the list and trigger a resolve. + */ +void phylink_release_pcs(struct phylink_pcs *pcs) +{ + struct phylink *pl; + + ASSERT_RTNL(); + + pl = pcs->phylink; + if (!pl) + return; + + mutex_lock(&pl->state_mutex); + + list_del(&pcs->list); + pcs->phylink = NULL; + + /* + * Check if we are removing the PCS currently + * in use by phylink. If this is the case, tear down + * the link, force phylink resolve to reconfigure the + * interface mode, disable the current PCS and set the + * phylink PCS to NULL. + */ + if (pl->pcs == pcs) { + phylink_link_down(pl); + phylink_pcs_disable(pl->pcs); + + pl->force_major_config = true; + pl->pcs = NULL; + } + + mutex_unlock(&pl->state_mutex); + + /* Refresh supported interfaces */ + phy_interface_copy(pl->supported_interfaces, + pl->config->supported_interfaces); + list_for_each_entry(pcs, &pl->pcs_list, list) + phy_interface_or(pl->supported_interfaces, + pl->supported_interfaces, + pcs->supported_interfaces); + + phylink_run_resolve(pl); +} +EXPORT_SYMBOL_GPL(phylink_release_pcs); + static unsigned int phylink_pcs_inband_caps(struct phylink_pcs *pcs, phy_interface_t interface) { diff --git a/include/linux/phylink.h b/include/linux/phylink.h index ca9dfc142388..15e6b1a39dfe 100644 --- a/include/linux/phylink.h +++ b/include/linux/phylink.h @@ -751,6 +751,8 @@ void phylink_disconnect_phy(struct phylink *); int phylink_set_fixed_link(struct phylink *, const struct phylink_link_state *); +void phylink_release_pcs(struct phylink_pcs *pcs); + void phylink_mac_change(struct phylink *, bool up); void phylink_pcs_change(struct phylink_pcs *, bool up); -- 2.53.0