From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DA40CCD4F26 for ; Fri, 19 Jun 2026 09:34:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=gRRwy50K4JnGdt30eWE2lTF1ai/8iZTtgfay12HVjsQ=; b=uQExGZtf43q7/CkVMevknsKDrZ pOBsQ7ALbL7GTC7SoA0N614D7KGqjosWn2d7X9OnWHUuKX2L7NrCOHsKpNYIPBM8Rvbx2fnbI+G64 QF2n5VPKlz0cqSex8XgDeAYcpAo/Ckp2M+qHO2DmEi7O+ZrcvNglpOHPLxOtnDPR1FWSFNcJT/nWj qyRXbnMsIHVP9mfTQWcF8qOubNHShjv8t9FMh7BLPdbrLOv3hIlvb0U5Ph978RJs+vbEmeLEDqTYM HWe1wxjKas+2KPXvt/2N3YnoG2ycIW2THCXwtLOfhHUi+IhL2kogxF1NVm6bsaCsuDC20yelh2EUV RL42PpAw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1waVcX-00000002ELS-2oGH; Fri, 19 Jun 2026 09:34:41 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1waVcW-00000002ELE-1O4n; Fri, 19 Jun 2026 09:34:40 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id B942643A57; Fri, 19 Jun 2026 09:34:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AD8F91F000E9; Fri, 19 Jun 2026 09:34:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1781861679; bh=gRRwy50K4JnGdt30eWE2lTF1ai/8iZTtgfay12HVjsQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=Xy+0x16KZlwG5haPppjzskvBUiSoLb5G9gkeIbPo6nFvNOReDSO7RgJHtDvinTwQI 2QZ1c3ZoA6RtJzRy8Xp/nJSX1Zz8vdigEGLBnD3wq+2er7mojMW1KpckFtkeK3JRy4 XJt6hXfhR1TwV0fn/hMECuAcPGBlnDwPy/DZa6+fDGPqfEiKcPsp3YV+k12UxyQvtB 39lrenqCbPtUrYMJsmgVM2awBAoCvevmfa2A7LRUMS8IADDyVx2FPOgqbsoTxAgc/C 4qZJVOuAedeFXR2SMv1ud6AjUhF7QuntFk3tGk1dgfac2/5rRxCTcAme8qyV/RdrRm dLg3W+yI4MMKA== Date: Fri, 19 Jun 2026 10:34:35 +0100 From: Simon Horman To: Lorenzo Bianconi Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Wayen Yan , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, netdev@vger.kernel.org Subject: Re: [PATCH net 1/2] net: airoha: Fix off-by-one in airoha_tc_remove_htb_queue() Message-ID: <20260619093435.GU827683@horms.kernel.org> References: <20260618-airoha-qos-fixes-v1-0-37192652157f@kernel.org> <20260618-airoha-qos-fixes-v1-1-37192652157f@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260618-airoha-qos-fixes-v1-1-37192652157f@kernel.org> X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Thu, Jun 18, 2026 at 08:00:29AM +0200, Lorenzo Bianconi wrote: > airoha_tc_htb_alloc_leaf_queue() computes the HTB QoS channel index > as opt->classid % AIROHA_NUM_QOS_CHANNELS and stores it in qos_sq_bmap. > However, airoha_tc_remove_htb_queue() clears the HTB configuration > using queue + 1 as the channel index, causing an off-by-one error. > Use queue directly as the QoS channel index to match the allocation > logic. > > Fixes: ef1ca9271313b ("net: airoha: Add sched HTB offload support") > Signed-off-by: Lorenzo Bianconi Reviewed-by: Simon Horman