From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 28B94C44500 for ; Thu, 2 Jul 2026 10:15:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date :Subject:CC:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=epGXLRCmvcx4nX7CFVTmNreEgf6Ukls0mpRDETc2X1k=; b=O7B3ihokYeDhDVkQ5nT1T6lqs2 j6nImMDOkSu8EMwgSgDgqZQX+pOvw6d3/lNpmlSnX9xZ6Lw4skZTXALSam+kihc9y8f/ICbsx+SHd 4kRhi4WMfLO6VAU7HpJStLulXocKs3zgjPhIRCicDJIclQD/FfnP91DkobaA+F65gVNGT9GItRJCZ UoKqo5wlZ7Eex/J6Io4wZwdNy6Y2rOzYJagRLCDvrPUHdxfO/RDg0jS2onALp1zf61B87WzMCpS54 8NZSV17x8EZ+NpIXVME9qcPuixBPilPpjWtvvaTA5174+twTrJHXbLYKnJ1LSS7TEWYtI0BbD4OR4 QjGNv2DA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wfERg-000000049JG-0PYi; Thu, 02 Jul 2026 10:15:00 +0000 Received: from desiato.infradead.org ([90.155.92.199]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wfERe-000000049Hd-1YEf for linux-mediatek@bombadil.infradead.org; Thu, 02 Jul 2026 10:14:58 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Type:Content-Transfer-Encoding :MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:CC:To:From: Sender:Reply-To:Content-ID:Content-Description; bh=epGXLRCmvcx4nX7CFVTmNreEgf6Ukls0mpRDETc2X1k=; b=KaRYRD1MdpwHnUEKKZgidt6x+K aWHGY8BeBQHIYNG3DpkFh+TMACmqdXWp9DdY1k0DkBZXci9CBAHtyrlklt5whQU43xquwuryj09yH RNYmpebsb7AkHahT+cX/TrA9t6MEpeNdWFe/971HaLMdgIPhK1bWj9nH+0FP7aRd9bwkQCpCYyuX1 KtX3bWa98wOK1O0xur4MtTdV9N+gduDDnKJc1VhM5zNcmTgdDSzuiLp0OurIz0TwH39azvhYllaWp gIbQFYzJTSt+gqVlwWd8HSB3G/Ug6ikUFZ3SPyb2vVhk6c6V3ClepO6nXEkqLhNNZ6Yp+DBcJIHWl fyEbjmWQ==; Received: from mailgw02.mediatek.com ([216.200.240.185]) by desiato.infradead.org with esmtps (Exim 4.99.2 #2 (Red Hat Linux)) id 1wfERW-00000003f6o-3Mim for linux-mediatek@lists.infradead.org; Thu, 02 Jul 2026 10:14:55 +0000 X-UUID: d781519875fe11f1acbe4559397dec65-20260702 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Type:Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:CC:To:From; bh=epGXLRCmvcx4nX7CFVTmNreEgf6Ukls0mpRDETc2X1k=; b=Z2/4fhnHvsap23pezLwmCWQhAKFg+QnsBwSHXv4QEyaMHzZIU+5na/liW1ZLdaSvg/2y25J7KYUmXg2GlDsLVWrruX3D/a0nl24Ix20Wh48grfYkJmUnxO0BCPeOMx6rYkdqhPIKkOT1dLt08HTmHDyUmy/i51cwZeIU9aRKFL0=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.3.17,REQID:bee77854-4f0a-42c5-80ad-ee1ebb62edf4,IP:0,U RL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION: release,TS:0 X-CID-META: VersionHash:d497b38,CLOUDID:2e87e6ee-6085-4bd7-b32c-8f3a894d1f02,B ulkID:nil,BulkQuantity:0,SF:81|82|102|836|865|888|898,TC:-5,Content:0|15|5 0|99|200|213,EDM:-3,IP:nil,URL:0,File:130,RT:0,Bulk:nil,QS:nil,BEC:-1,COL: 0,OSI:0,OSA:0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0,ARC:0 X-CID-BVR: 2,SSN|SDN X-CID-BAS: 2,SSN|SDN,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR X-CID-RHF: D41D8CD98F00B204E9800998ECF8427E X-UUID: d781519875fe11f1acbe4559397dec65-20260702 Received: from mtkmbs14n2.mediatek.inc [(172.21.101.76)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 1464089073; Thu, 02 Jul 2026 03:14:42 -0700 Received: from mtkmbs11n2.mediatek.inc (172.21.101.187) by MTKMBS14N1.mediatek.inc (172.21.101.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.29; Thu, 2 Jul 2026 18:14:39 +0800 Received: from mtksitap99.mediatek.inc (10.233.130.16) by mtkmbs11n2.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.2562.29 via Frontend Transport; Thu, 2 Jul 2026 18:14:38 +0800 From: Chris Lu To: Marcel Holtmann , Johan Hedberg , Luiz Von Dentz CC: Sean Wang , Will Lee , SS Wu , Steve Lee , linux-bluetooth , linux-kernel , linux-mediatek , Paul Menzel , Chris Lu Subject: [PATCH v9 4/6] Bluetooth: btmtk: Replace magic numbers with WMT packet flag enum Date: Thu, 2 Jul 2026 18:14:34 +0800 Message-ID: <20260702101437.1787800-5-chris.lu@mediatek.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20260702101437.1787800-1-chris.lu@mediatek.com> References: <20260702101437.1787800-1-chris.lu@mediatek.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260702_111452_186573_0DCAB41E X-CRM114-Status: GOOD ( 11.17 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Add BTMTK_WMT_PKT_* enum to represent WMT download packet sequence flags, improving code readability. Replace magic numbers (1, 2, 3) in btmtk_setup_firmware_79xx() and btmtk_setup_firmware() with descriptive enum values: - BTMTK_WMT_PKT_START (1): First packet of a sequence - BTMTK_WMT_PKT_CONTINUE (2): Continuation packet - BTMTK_WMT_PKT_END (3): Final packet of a sequence Signed-off-by: Chris Lu Reviewed-by: Paul Menzel Assisted-by: Claude:Sonnet-4.5 --- drivers/bluetooth/btmtk.c | 12 ++++++------ drivers/bluetooth/btmtk.h | 6 ++++++ 2 files changed, 12 insertions(+), 6 deletions(-) diff --git a/drivers/bluetooth/btmtk.c b/drivers/bluetooth/btmtk.c index 3491060b3ae9..3fe6b4fdc438 100644 --- a/drivers/bluetooth/btmtk.c +++ b/drivers/bluetooth/btmtk.c @@ -269,12 +269,12 @@ int btmtk_setup_firmware_79xx(struct hci_dev *hdev, const char *fwname, while (dl_size > 0) { dlen = min_t(int, 250, dl_size); if (first_block == 1) { - flag = 1; + flag = BTMTK_WMT_PKT_START; first_block = 0; } else if (dl_size - dlen <= 0) { - flag = 3; + flag = BTMTK_WMT_PKT_END; } else { - flag = 2; + flag = BTMTK_WMT_PKT_CONTINUE; } wmt_params.flag = flag; @@ -353,7 +353,7 @@ int btmtk_setup_firmware(struct hci_dev *hdev, const char *fwname, fw_size -= 30; fw_ptr += 30; - flag = 1; + flag = BTMTK_WMT_PKT_START; wmt_params.op = BTMTK_WMT_PATCH_DWNLD; wmt_params.status = NULL; @@ -363,9 +363,9 @@ int btmtk_setup_firmware(struct hci_dev *hdev, const char *fwname, /* Tell device the position in sequence */ if (fw_size - dlen <= 0) - flag = 3; + flag = BTMTK_WMT_PKT_END; else if (fw_size < fw->size - 30) - flag = 2; + flag = BTMTK_WMT_PKT_CONTINUE; wmt_params.flag = flag; wmt_params.dlen = dlen; diff --git a/drivers/bluetooth/btmtk.h b/drivers/bluetooth/btmtk.h index c83c24897c95..51c18dde0a80 100644 --- a/drivers/bluetooth/btmtk.h +++ b/drivers/bluetooth/btmtk.h @@ -66,6 +66,12 @@ enum { BTMTK_WMT_ON_PROGRESS, }; +enum { + BTMTK_WMT_PKT_START = 1, + BTMTK_WMT_PKT_CONTINUE = 2, + BTMTK_WMT_PKT_END = 3, +}; + struct btmtk_wmt_hdr { u8 dir; u8 op; -- 2.45.2