From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 13734C43458 for ; Mon, 6 Jul 2026 01:55:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=hc+/IIfPHTQ5W3C46gmAKHbZoREmTGGCL3gylifCnJk=; b=vZv7G0743Ts595gQWWrlt2/Tp8 gvJBtXaM7Ns4srFkLBMUU7xHFvmG6sMRu/YZTymdz7KQioW5TL0pvsnnH7qRFRsXRX9oZKzOnenWn xVXvcDeDMTuG/nwv9nrOflqYxfgTJCFXtGbOP2SCBAMz1RkmhlnsfQHHzyHZtZPtWz4L4A2YTSDrh tfcTBvNWrbShf6UBx4EO1YOTQW/ths4z6aAI9M9CSRIegOD2C84yaCVEODSwtgRhvw9rdVHV0BAq5 0HvdkjAVXS9pqxK4r0T6EHJ2GMe66Lli4y42Tnpb/z1A3UBhMtPVaSjj7wwxP65aevAfgjkgPrAn5 JdiF/niA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wgYYr-0000000BLz8-3OF3; Mon, 06 Jul 2026 01:55:53 +0000 Received: from mail-pf1-x42f.google.com ([2607:f8b0:4864:20::42f]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wgYYp-0000000BLyP-2TIt for linux-mediatek@lists.infradead.org; Mon, 06 Jul 2026 01:55:52 +0000 Received: by mail-pf1-x42f.google.com with SMTP id d2e1a72fcca58-8471013fac2so2699273b3a.1 for ; Sun, 05 Jul 2026 18:55:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783302950; x=1783907750; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=hc+/IIfPHTQ5W3C46gmAKHbZoREmTGGCL3gylifCnJk=; b=cbW+CITXozcs5DO6c1DCHd3VEGDFuKJ4JsEgX/H/g4HCjwUhfiLVqhy1J2za6mXdBP 8Dq3da+/N/ZqA/cuW+Dr/PQOkJrfvVO0yBRsrsJqksYgxiH5pbO+PJ8PPqN9O1hRlJPI lq2uim3VcA/muro5hQs9aC7Hml2uRy5Zmo2ZKAjf7iK4k+yjsnA18AkEfjHZ40+XBjct 8wo7nv7z/HwT8Z0u9H21meXy1UDFrktfs/bhyoukOY9R666QOJFuc/+/beuaH6I+aB3Z MpGLcskExfKlwptrR0zJYBgzl/IgkOOeYw3S97WFGe2mG+AMPJ7R6MABfe7Xya4kmdKU mL3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783302950; x=1783907750; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=hc+/IIfPHTQ5W3C46gmAKHbZoREmTGGCL3gylifCnJk=; b=MNZ5+qcSehvRuOgi+xQkJBUgwd2omykvNbS+GFc2Zlu0NgMwKFqFul12GuIFhAEiEq KespN8JVF+f7QDxvlbT2LExERcLWNk28hBwoslV/ubTNw3DXBqRN6CbceeelPGYY3hBz p84zxdDVnE3D0l64EF6Zt33NAD63p4/D83bzRsBX+Ojff8NcnBrNYt3sLEoMNWpg1UlH m9Vt8FQH6eyAXQjP+0alolI+sS8odg4AypyfG4bte8GYUed8O0xVz8iiA5X2dOGVUulm 6Z3O2A8llFqV9S5wc/XyJ5JEjqG/CItg4v59Io3P0URlLHcnSLGLH1SSHSO3l6Mvyzhc V+4w== X-Forwarded-Encrypted: i=1; AHgh+Rode3QxEMSaCbdLPOExEx4alyJLMxks3Q+gLjryLBJU+vmMFv/+bduj0Ta9eFdi9K/0F8gMkna38sI1UPZk8w==@lists.infradead.org X-Gm-Message-State: AOJu0YyaIBEnqXPa/KqXLyk8g6Qi5rf4PXAF0nZwnHxHq2QnsK4lG4R0 4UxQqe04wwhvsA33dKv+sRQQhH61vU5sm50yovEb81stcepwbUKZ6AC/ X-Gm-Gg: AfdE7cmCtovSJ3OTEZTvLlnvSAbKR9LtAb0kR11pHWkYGCOmB/tNONHjStLV8CrfETg pJT8oYgJRxrL6aYmUkr6tkC0xShmbHZ6P6c0PWkIAMHaCn4qBJk0lacjqprElD1clysug0Pc1Ls rAnjqRfub9CDOWPz76rvGjsIpZccjWSNnpgH7+tX4LmLBfsqkXhRu0DqWRQ0MuG9RohusP8JoLm rT92g0HNVKy0Bq9kafuZKluoIFDEDC/tc2EVhMTxx1N0AACIdCETzC/z6iyFzUS9/BSfcjjj98K Ay3iuwqqNSz3fVJmodfTlGXbvNuiqi0whAAN2IFtIIY/ISnL0Xv7SEoBghv9uaCMkJPkvCpGcEL tBkX1BnZQJ99R3QXvKkaqkTOYejvWOqQ0p4qsmQyIEhlgtVUxcFue8xx1X+ag4mBaU1XagrQw8v T82Ks= X-Received: by 2002:a05:6a00:2d23:b0:845:bcf0:118 with SMTP id d2e1a72fcca58-847f6f55a19mr7186973b3a.41.1783302950430; Sun, 05 Jul 2026 18:55:50 -0700 (PDT) Received: from lgs.. ([101.36.107.181]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-847f6b96c04sm2832348b3a.22.2026.07.05.18.55.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Jul 2026 18:55:49 -0700 (PDT) From: Guangshuo Li To: Chun-Kuang Hu , Philipp Zabel , David Airlie , Simona Vetter , Matthias Brugger , AngeloGioacchino Del Regno , CK Hu , Louis-Alexis Eyraud , dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Guangshuo Li , stable@vger.kernel.org Subject: [PATCH v2] drm/mediatek: mtk_hdmi: Fix DDC adapter double put in v2 Date: Mon, 6 Jul 2026 09:55:07 +0800 Message-ID: <20260706015507.453222-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260705_185551_632819_B27CBE43 X-CRM114-Status: GOOD ( 13.17 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org mtk_hdmi_common_probe() gets the DDC adapter with of_find_i2c_adapter_by_node() and registers a devm action to release the adapter device reference with put_device(). The HDMI v2 remove callback also calls i2c_put_adapter() on the same DDC adapter. This is not paired with of_find_i2c_adapter_by_node(): it drops the adapter device reference before the devm action drops it again, and it also puts a module reference that was never taken. Remove the extra i2c_put_adapter() call and drop the now-empty HDMI v2 remove callback. The common devm action releases the adapter device reference. Fixes: 8d0f79886273 ("drm/mediatek: Introduce HDMI/DDC v2 for MT8195/MT8188") Cc: stable@vger.kernel.org Signed-off-by: Guangshuo Li --- v2: - Drop the empty remove callback, as suggested by Johan Hovold. - Mention that i2c_put_adapter() also drops a module reference that was never taken. - Fix the Fixes tag. - Add Cc stable. drivers/gpu/drm/mediatek/mtk_hdmi_v2.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi_v2.c b/drivers/gpu/drm/mediatek/mtk_hdmi_v2.c index 7bbf463056c9..ffe456238a2b 100644 --- a/drivers/gpu/drm/mediatek/mtk_hdmi_v2.c +++ b/drivers/gpu/drm/mediatek/mtk_hdmi_v2.c @@ -1499,13 +1499,6 @@ static int mtk_hdmi_v2_probe(struct platform_device *pdev) return 0; } -static void mtk_hdmi_v2_remove(struct platform_device *pdev) -{ - struct mtk_hdmi *hdmi = platform_get_drvdata(pdev); - - i2c_put_adapter(hdmi->ddc_adpt); -} - static const struct of_device_id mtk_drm_hdmi_v2_of_ids[] = { { .compatible = "mediatek,mt8188-hdmi-tx", .data = &mtk_hdmi_conf_mt8188 }, { .compatible = "mediatek,mt8195-hdmi-tx", .data = &mtk_hdmi_conf_mt8195 }, @@ -1515,7 +1508,6 @@ MODULE_DEVICE_TABLE(of, mtk_drm_hdmi_v2_of_ids); static struct platform_driver mtk_hdmi_v2_driver = { .probe = mtk_hdmi_v2_probe, - .remove = mtk_hdmi_v2_remove, .driver = { .name = "mediatek-drm-hdmi-v2", .of_match_table = mtk_drm_hdmi_v2_of_ids, -- 2.43.0