From: Pan Chuang <panchuang@vivo.com>
To: Sean Wang <sean.wang@mediatek.com>, Vinod Koul <vkoul@kernel.org>,
Frank Li <Frank.Li@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
dmaengine@vger.kernel.org (open list:MEDIATEK DMA DRIVER),
linux-arm-kernel@lists.infradead.org (moderated list:MEDIATEK
DMA DRIVER),
linux-mediatek@lists.infradead.org (moderated list:MEDIATEK DMA
DRIVER),
linux-kernel@vger.kernel.org (open list:ARM/Mediatek SoC support)
Cc: Pan Chuang <panchuang@vivo.com>
Subject: [PATCH 05/26] dmaengine: mediatek-mtk-hsdma: Remove redundant dev_err()/dev_err_probe()
Date: Thu, 9 Jul 2026 21:58:09 +0800 [thread overview]
Message-ID: <20260709135846.97972-6-panchuang@vivo.com> (raw)
In-Reply-To: <20260709135846.97972-1-panchuang@vivo.com>
The devm_request_irq() now automatically logs detailed error messages on
failure. This eliminates the need for driver-specific dev_err() and
dev_err_probe() calls that previously printed generic messages.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/dma/mediatek/mtk-hsdma.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/dma/mediatek/mtk-hsdma.c b/drivers/dma/mediatek/mtk-hsdma.c
index a43412ff5edd..6ee8911c12e0 100644
--- a/drivers/dma/mediatek/mtk-hsdma.c
+++ b/drivers/dma/mediatek/mtk-hsdma.c
@@ -988,11 +988,8 @@ static int mtk_hsdma_probe(struct platform_device *pdev)
err = devm_request_irq(&pdev->dev, hsdma->irq,
mtk_hsdma_irq, 0,
dev_name(&pdev->dev), hsdma);
- if (err) {
- dev_err(&pdev->dev,
- "request_irq failed with err %d\n", err);
+ if (err)
goto err_free;
- }
platform_set_drvdata(pdev, hsdma);
--
2.34.1
next prev parent reply other threads:[~2026-07-09 13:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-09 13:58 [PATCH 00/26] dmaengine: Remove redundant error messages on IRQ request failure Pan Chuang
2026-07-09 13:58 ` [PATCH 04/26] dmaengine: mediatek-mtk-cqdma: Remove redundant dev_err()/dev_err_probe() Pan Chuang
2026-07-09 13:58 ` Pan Chuang [this message]
2026-07-09 14:26 ` [PATCH 00/26] dmaengine: Remove redundant error messages on IRQ request failure Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260709135846.97972-6-panchuang@vivo.com \
--to=panchuang@vivo.com \
--cc=Frank.Li@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=sean.wang@mediatek.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox