From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A011EC44506 for ; Fri, 10 Jul 2026 05:06:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=AtVsXFH15IrgzMd0VFvy62roDSh+hKjqh257VzvTJMo=; b=Hd+Vs4LtZaDXMLbAjDNv3dLWb3 rZSxo4+rkASPDtVc7IKM2hMVZcNro2jjieo0RK71qEL3aObAhVV6U10DeskTlOpnJwqum0rvHSHUC rN9NnMRmrUI6myhUTazelWXtdQx7EDw9lfgHnXSFj3A7Db0k9UIBEs7Gx5I/xKitmLq6jZgbONsg4 lwggAfbnyo5AjWBPMj1rel6Znc2VBlB3krt96CE8W0bh3pwJEL+n2KC6G/1wNCKx41RrhxtOYnf1e ZLPiZri5rqTNndoQ/ObGBA6w7OGt/BN3/DP2MTqFnwNU4mPQPwbAJlwmINEr31opFBDxVRtLBJjGT dKtpVuJw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wi3Rq-000000048h0-2ypR; Fri, 10 Jul 2026 05:06:50 +0000 Received: from mail-pf1-x436.google.com ([2607:f8b0:4864:20::436]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wi3Ro-000000048e8-1Nnw for linux-mediatek@lists.infradead.org; Fri, 10 Jul 2026 05:06:49 +0000 Received: by mail-pf1-x436.google.com with SMTP id d2e1a72fcca58-8485fad302bso469078b3a.3 for ; Thu, 09 Jul 2026 22:06:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783660008; x=1784264808; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=AtVsXFH15IrgzMd0VFvy62roDSh+hKjqh257VzvTJMo=; b=QSzt8Hys4T71GMVvJwFgIiNYpT65Kg4kAPYChSRA8mqfqMTkLLcZqt5iU9rjlLB6o5 B3W/si9lfbApRinZPHzNTuHvs4f3ZoFKkRaIMbAbgPqa8/1B85cJfHV2j7mh7rFFStEA N0kPmLvlpAgzx35W6GPwJMOA8kxw4bewofHt2kao67cUTKeA02cpx7JHtUSB94wi8vcs pcn5hzfqrD1qF4VTHoSx5jS9XHrKFPlaUS2/89DDvO2osL5NF1UpDjXAqYCOZTyz/AxR 160scUumii9DgdR30yYixfALKfRifO1PHCC+zQhCF5yVw6XLbyH5YvPpv491vx7HIJd7 Ushg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783660008; x=1784264808; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=AtVsXFH15IrgzMd0VFvy62roDSh+hKjqh257VzvTJMo=; b=ohs06J6qYBHzO40y8Jycrpllv5npSK1rXaPaaqwj9BwRNlKHvKPR5ax7CHuqFf/niM NNkD+KCa+NHQN9TJf06V1bMVkB8mW6onL8mxyn8l8ozOlm87+IGio7ZuJUva/wTFzi6j w9bD3LeHftw45l1k6crjOmcTrMvUar1XZuwrmTX4GOCY3dqW65zciFeyVc2Qj/w7vHdj 6qzR0kqsrC36CvJr0LMZaslLJk/h6xchstKKHbB9CPOEbxydzVK5Ilm/r/zp7MwkOwNQ NztcbfvV2Y39cuT9QBjJNj8hr8gNYOziFNv/gm3Ur+Q0pfPT5CmRbyCzVJYb9mBnDLyK oEVw== X-Forwarded-Encrypted: i=1; AHgh+RpGeefAhbfgjVE8MV1isjyz/nEdHxDl02aOSBFNo5FSjaTe1ytvBKZqHZ7R0vDkqsHcQQqEYZxfI9bpLGHIUw==@lists.infradead.org X-Gm-Message-State: AOJu0Yz4Z/JIPFWA1XXeYO+HUrncWQ3NvuDMMaOxbZABVjS2QIXWRvSW naKu+SvUoID3bgUABZgcExO4g6PUCpd887nlQXA9CD7hGq53eZ+eo8Ko X-Gm-Gg: AfdE7cmr9r6smUrvw9wnrIKPE4iPNPOSvtQBAjL9OdM/aMp4Con9oCclT60PExHfrhG hR4imKNigGeYj0G/99+AZeye2WkCDR1empf9Y8t0NSRZ1sFVPcsgVEhtiozG77AIZQk4rnsZgRn XdFbJ6caH2wEZ5ZJIsJ0UevD3mGYVu7gmx8TzAFfG0EmMJF9C6dcCzGHIwQa+t7zl6VqvreJfQ1 DHMj1yzBtT3+sc7L8uFM6+ItknkXxwlv/CpgSqUJSbHAIOtCLsdRKKrHMYkr59powjhu6zyQ8jA 76indjofkC07K7CHen7lduBCwNEWi0W3keMpEeniSn7IF6T0Fk5/OItX/wFvoTAc/VdNnbKg83v UdxxT3HyJPcMUE5Ux6ZT/m99jDcPTF9/qIphvg/bOX+d/ynEVlmfnhJqZVnh8u1iJeHgHXY77ue oWjq5MTufKnvM6LopbuGeY65Krq0TeXjnblPo3n/h4OlCGnvo= X-Received: by 2002:a05:6a00:a15:b0:848:2f77:e2df with SMTP id d2e1a72fcca58-8484392f4a8mr10653484b3a.72.1783660007641; Thu, 09 Jul 2026 22:06:47 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84847275fa0sm3400499b3a.22.2026.07.09.22.06.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Jul 2026 22:06:47 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , Takashi Iwai , Nick Li , Herve Codina Cc: Support Opensource , Liam Girdwood , Jaroslav Kysela , Srinivas Kandagatla , Charles Keepax , Richard Fitzgerald , Matthias Brugger , AngeloGioacchino Del Regno , Shenghao Ding , Kevin Lu , Baojun Xu , Sen Wang , Oder Chiou , Linus Walleij , Kuninori Morimoto , u.kleine-koenig@baylibre.com, Zhang Yi , Marco Crivellari , Kees Cook , HyeongJun An , Arnd Bergmann , Qianfeng Rong , linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, bui duc phuc Subject: [PATCH v3 12/27] ASoC: codecs: max98095: Use guard() for mutex locks Date: Fri, 10 Jul 2026 12:04:56 +0700 Message-ID: <20260710050511.14439-10-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260710050511.14439-1-phucduc.bui@gmail.com> References: <20260709045902.498848-1-phucduc.bui@gmail.com> <20260710050511.14439-1-phucduc.bui@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260709_220648_374912_ACA0C36C X-CRM114-Status: UNSURE ( 9.69 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org From: bui duc phuc Clean up the code using guard() for mutex locks. Merely code refactoring, and no behavior change. Signed-off-by: bui duc phuc --- sound/soc/codecs/max98095.c | 35 ++++++++++++++++++++--------------- 1 file changed, 20 insertions(+), 15 deletions(-) diff --git a/sound/soc/codecs/max98095.c b/sound/soc/codecs/max98095.c index ced9bd4d94da..c47bfa2378b8 100644 --- a/sound/soc/codecs/max98095.c +++ b/sound/soc/codecs/max98095.c @@ -5,6 +5,7 @@ * Copyright 2011 Maxim Integrated Products */ +#include #include #include #include @@ -1532,15 +1533,17 @@ static int max98095_put_eq_enum(struct snd_kcontrol *kcontrol, regsave = snd_soc_component_read(component, M98095_088_CFG_LEVEL); snd_soc_component_update_bits(component, M98095_088_CFG_LEVEL, regmask, 0); - mutex_lock(&max98095->lock); - snd_soc_component_update_bits(component, M98095_00F_HOST_CFG, M98095_SEG, M98095_SEG); - m98095_eq_band(component, channel, 0, coef_set->band1); - m98095_eq_band(component, channel, 1, coef_set->band2); - m98095_eq_band(component, channel, 2, coef_set->band3); - m98095_eq_band(component, channel, 3, coef_set->band4); - m98095_eq_band(component, channel, 4, coef_set->band5); - snd_soc_component_update_bits(component, M98095_00F_HOST_CFG, M98095_SEG, 0); - mutex_unlock(&max98095->lock); + scoped_guard(mutex, &max98095->lock) { + snd_soc_component_update_bits(component, M98095_00F_HOST_CFG, + M98095_SEG, M98095_SEG); + m98095_eq_band(component, channel, 0, coef_set->band1); + m98095_eq_band(component, channel, 1, coef_set->band2); + m98095_eq_band(component, channel, 2, coef_set->band3); + m98095_eq_band(component, channel, 3, coef_set->band4); + m98095_eq_band(component, channel, 4, coef_set->band5); + snd_soc_component_update_bits(component, M98095_00F_HOST_CFG, + M98095_SEG, 0); + } /* Restore the original on/off state */ snd_soc_component_update_bits(component, M98095_088_CFG_LEVEL, regmask, regsave); @@ -1683,12 +1686,14 @@ static int max98095_put_bq_enum(struct snd_kcontrol *kcontrol, regsave = snd_soc_component_read(component, M98095_088_CFG_LEVEL); snd_soc_component_update_bits(component, M98095_088_CFG_LEVEL, regmask, 0); - mutex_lock(&max98095->lock); - snd_soc_component_update_bits(component, M98095_00F_HOST_CFG, M98095_SEG, M98095_SEG); - m98095_biquad_band(component, channel, 0, coef_set->band1); - m98095_biquad_band(component, channel, 1, coef_set->band2); - snd_soc_component_update_bits(component, M98095_00F_HOST_CFG, M98095_SEG, 0); - mutex_unlock(&max98095->lock); + scoped_guard(mutex, &max98095->lock) { + snd_soc_component_update_bits(component, M98095_00F_HOST_CFG, + M98095_SEG, M98095_SEG); + m98095_biquad_band(component, channel, 0, coef_set->band1); + m98095_biquad_band(component, channel, 1, coef_set->band2); + snd_soc_component_update_bits(component, M98095_00F_HOST_CFG, + M98095_SEG, 0); + } /* Restore the original on/off state */ snd_soc_component_update_bits(component, M98095_088_CFG_LEVEL, regmask, regsave); -- 2.43.0