From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 29AC9C43458 for ; Fri, 10 Jul 2026 05:07:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ro7dNqCD2kLl5dqOgIDoE4tVtLHIEVBSdhnRDBcC1Vc=; b=HBnenRmZ0DPC0uuJnF89GXiiZF EhqaSAt+RNbJ9vV4Uv3rrI36q4gNZW7mPgBqUpu6K22jZ64rZ5lhukP65WARPO/LFF01VsQCxVV7E fod2t8t7mNlm5tLXOvHQ9fj1MMWlRcYq+aOIPuQqV2KygEsY07Hb5NUqj47d4+p2WFAYMTV0wDPwD MQOFQCIXM9lb9uHalx2yP1Y5pVJZ8gLY6pR5Lp6CQKwr0T82hMDqMN5QyVnZBAscFHa9LgPtm0Rfl MWekYEEfaCcwfs868ecOKIFJQIgGXIbZouoAxYMnnm+Mkejo5RBqg4FkF35v7y10i9m8lOhc4yLEG FJIISsCw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wi3SX-000000049IN-15GM; Fri, 10 Jul 2026 05:07:33 +0000 Received: from mail-pf1-x42d.google.com ([2607:f8b0:4864:20::42d]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wi3SU-000000049G1-2aQO for linux-mediatek@lists.infradead.org; Fri, 10 Jul 2026 05:07:32 +0000 Received: by mail-pf1-x42d.google.com with SMTP id d2e1a72fcca58-842338c18e0so426899b3a.1 for ; Thu, 09 Jul 2026 22:07:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783660050; x=1784264850; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ro7dNqCD2kLl5dqOgIDoE4tVtLHIEVBSdhnRDBcC1Vc=; b=ovBGjsoHpu8Ie7codUYymW0rBqXSLquok8iEPRjA3U7bu3TZF4oC5A1OOfLzlDZZPk B0fL6kch1yP5VU3/6BC8u5/EGgPPe0eZ/eDQFLzhDpMzsrXyfDq4POPL+Pk1ww9/jtEo KOFJKtIKNhQ8yrdIQzBUo5Xc2w+Gmh4PXRw1ubD6qV81phIWp8bkrTkL3oo7Ov5cjOw5 SLsRkrwoRqzaPHqyqcG63SFQZuTYTW3cyKk7B8v2AreYHFm76UGErF4WrYYIgNGJs/Kn 5DS+LIoTBa71KtIVqen3aFPRlTYS5P3yYl5QsQUjNUHZ9JHDPQaInaiO4x4++J3yNyLd xQkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783660050; x=1784264850; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=ro7dNqCD2kLl5dqOgIDoE4tVtLHIEVBSdhnRDBcC1Vc=; b=Cjinjv3/Q0Y1FtW939QCkn2P5ZxmBIK0XPacV/AGqEUxRjjZyLO7dxKhY8xGHQez/R HW0URHyrX0W8peSxsDRc/BYJP4qVIgsr7vfQIAunz2kLcg2CAkKyzskWHkZZpcjQBEOV BPf1BBtz4VdvyDDrf2i6bzQYNprjbWmxWArvBYXwVIA9NrzI9onaxOUEc1kVBRn+0x+d ZMZC2ZXHscZGpe0whNnkeG735NxrQ+hovZGBeTR6NXTJ1sGO7DRoC9ZNKvVjFPQ+q5Uj +fgeSP2gprd/mXlWoGcjt550DiceeRGLcnGjESdbex+zrGVD9wsg4d1TGp1DxWJZbh5A RJaw== X-Forwarded-Encrypted: i=1; AHgh+Rr1CDwJJeT5kqF7QSElz28uyJYP8NgVh4tpTiBhxhmPfvyWL7xfhvsqyv9+3l2NefQpxBJ5cJyxp33PjZlo6Q==@lists.infradead.org X-Gm-Message-State: AOJu0YyxsgMl6bctkV963krF1RtWVrGQz7p9plkGgXp5Z51TFZfZ4rOQ d2B3ofzP+rdXLNhc00748gTW2epnavmvEC/B/WpXk4+BxybQ3UDtEcJc X-Gm-Gg: AfdE7ckySyttvPdxaotzhEpmIWohf3yjDNI1Mieuu5gVXk4VyAY12yEK6sBzpd4kS4s hDAjiFMk8/qrceTXg2I4pZPWVtA/VoqgYDZ7rN/26L1ancsIGcc7v1jptk6da6npVk09Umiw6au NnIslGtKqYDJIdcArHx/45aKheynLpxAn4jok5/GTe4HiaapNO9U26S5iiXqblQw1k2nkl+taem bsqqfUG221hlhD4IMH1ZftRDFik/iTRiTk7h8U//hwOGJ55IlY7189SLvB/GAPG9WTqzFgP96lh EC/t6FFHEdHjUTqEbYhEcYfirb6pxtFtsk1KvmiAU0+gUHoeLOvLrz3jnaeYWiHaGWuSuUcAHzW DoMA2F/8SHGWbbTWsj0OnMEnbxufhC9dG73FtVv1XZMxDMUDzInLC7Wgq+r3GAaAnMMIJukZpFq rts3xWwzCH2o09/4Yd2NdJo4CQfUx80JINdhIdbRNZW+cFV5M= X-Received: by 2002:a05:6a00:198f:b0:848:6f63:8d37 with SMTP id d2e1a72fcca58-8486f639411mr2153035b3a.61.1783660049877; Thu, 09 Jul 2026 22:07:29 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84847275fa0sm3400499b3a.22.2026.07.09.22.07.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Jul 2026 22:07:29 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , Takashi Iwai , Nick Li , Herve Codina Cc: Support Opensource , Liam Girdwood , Jaroslav Kysela , Srinivas Kandagatla , Charles Keepax , Richard Fitzgerald , Matthias Brugger , AngeloGioacchino Del Regno , Shenghao Ding , Kevin Lu , Baojun Xu , Sen Wang , Oder Chiou , Linus Walleij , Kuninori Morimoto , u.kleine-koenig@baylibre.com, Zhang Yi , Marco Crivellari , Kees Cook , HyeongJun An , Arnd Bergmann , Qianfeng Rong , linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, bui duc phuc Subject: [PATCH v3 17/27] ASoC: codecs: rt5514-spi: Use guard() for mutex locks Date: Fri, 10 Jul 2026 12:05:01 +0700 Message-ID: <20260710050511.14439-15-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260710050511.14439-1-phucduc.bui@gmail.com> References: <20260709045902.498848-1-phucduc.bui@gmail.com> <20260710050511.14439-1-phucduc.bui@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260709_220730_671288_6697DD6C X-CRM114-Status: GOOD ( 12.09 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org From: bui duc phuc Clean up the code using guard() for mutex locks. Merely code refactoring, and no behavior change. Signed-off-by: bui duc phuc --- sound/soc/codecs/rt5514-spi.c | 21 ++++++++------------- 1 file changed, 8 insertions(+), 13 deletions(-) diff --git a/sound/soc/codecs/rt5514-spi.c b/sound/soc/codecs/rt5514-spi.c index 199507d12841..91290bfe8daa 100644 --- a/sound/soc/codecs/rt5514-spi.c +++ b/sound/soc/codecs/rt5514-spi.c @@ -6,6 +6,7 @@ * Author: Oder Chiou */ +#include #include #include #include @@ -79,17 +80,17 @@ static void rt5514_spi_copy_work(struct work_struct *work) unsigned int cur_wp, remain_data; u8 buf[8]; - mutex_lock(&rt5514_dsp->dma_lock); + guard(mutex)(&rt5514_dsp->dma_lock); if (!rt5514_dsp->substream) { dev_err(rt5514_dsp->dev, "No pcm substream\n"); - goto done; + return; } runtime = rt5514_dsp->substream->runtime; period_bytes = snd_pcm_lib_period_bytes(rt5514_dsp->substream); if (!period_bytes) { schedule_delayed_work(&rt5514_dsp->copy_work, 5); - goto done; + return; } if (rt5514_dsp->buf_size % period_bytes) @@ -111,7 +112,7 @@ static void rt5514_spi_copy_work(struct work_struct *work) if (remain_data < period_bytes) { schedule_delayed_work(&rt5514_dsp->copy_work, 5); - goto done; + return; } } @@ -146,9 +147,6 @@ static void rt5514_spi_copy_work(struct work_struct *work) snd_pcm_period_elapsed(rt5514_dsp->substream); schedule_delayed_work(&rt5514_dsp->copy_work, 5); - -done: - mutex_unlock(&rt5514_dsp->dma_lock); } static void rt5514_schedule_copy(struct rt5514_dsp *rt5514_dsp) @@ -216,7 +214,7 @@ static int rt5514_spi_hw_params(struct snd_soc_component *component, snd_soc_component_get_drvdata(component); u8 buf[8]; - mutex_lock(&rt5514_dsp->dma_lock); + guard(mutex)(&rt5514_dsp->dma_lock); rt5514_dsp->substream = substream; rt5514_dsp->dma_offset = 0; @@ -225,8 +223,6 @@ static int rt5514_spi_hw_params(struct snd_soc_component *component, if (buf[0] & RT5514_IRQ_STATUS_BIT) rt5514_schedule_copy(rt5514_dsp); - mutex_unlock(&rt5514_dsp->dma_lock); - return 0; } @@ -236,9 +232,8 @@ static int rt5514_spi_hw_free(struct snd_soc_component *component, struct rt5514_dsp *rt5514_dsp = snd_soc_component_get_drvdata(component); - mutex_lock(&rt5514_dsp->dma_lock); - rt5514_dsp->substream = NULL; - mutex_unlock(&rt5514_dsp->dma_lock); + scoped_guard(mutex, &rt5514_dsp->dma_lock) + rt5514_dsp->substream = NULL; cancel_delayed_work_sync(&rt5514_dsp->copy_work); -- 2.43.0