From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DABA8C43458 for ; Mon, 13 Jul 2026 11:41:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=Bjup8tkbZReyLVbx7owWNWJpf0WRCU5BarQCoUzbWwU=; b=Tm8z8ZVzKMVf8HQu9iYJNGbTLx 8OCMAvQFNLhD6ciDeYoFz3dWrSaFmxKw1SvSv753RJTl+8TCv97J+3Knq9bxCPF+9DDC76LzBz4vZ CWn4r1P/PQF3+vuZ0/b2JTfqAxcdgmcVh4qtiERQcGAAQUdvGhHR+ujNMPbptOz/8QTu5uGxXOKf5 qj3SCzg0hCWeL9IffIdfit9vVApUh8HLkny0AKJjbIgiSnGmrovR4naXHDJJWU9YOc3r0LEoQvgtH hC1a290CxgrwCUesuTI9KbFWmBQH47f1bZR+YkY4kQonKVlCav9agdiq3U0NxRvw58ucSgOVZy0UW dV+KDqwg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wjF2E-0000000931g-1YeS; Mon, 13 Jul 2026 11:41:18 +0000 Received: from mail-pl1-x62c.google.com ([2607:f8b0:4864:20::62c]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wjF2B-0000000930A-0DEV for linux-mediatek@lists.infradead.org; Mon, 13 Jul 2026 11:41:16 +0000 Received: by mail-pl1-x62c.google.com with SMTP id d9443c01a7336-2cc6dd436c6so37123305ad.2 for ; Mon, 13 Jul 2026 04:41:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783942874; x=1784547674; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=Bjup8tkbZReyLVbx7owWNWJpf0WRCU5BarQCoUzbWwU=; b=DF7/NLo7eCCAwTHBtHDclQd07+MtzpVE5c2n+juqBXjdfsWiW2xmjxzIwLnJHMlfoX jBXgHKXURU743MXWa2yqDxUch042uUExxWyyHEyIdBZN1SNP9V5twJf46r5orV+PSAs1 uE748cySf3lmPtGafR8ArDWDcVQT8KKK3wq6KfndJD1tdC1p/2IMMbFR78g80O6D/g7s ER6UEG1AazM2Uqa3Gn21Xh5NW6i1SJ0zTMkC51w/NmL0DL5hm/tZYXzKRseL+tuupeQI MwJHs+oJsqWw/A1w/3EDK3tyGVc9XjmLWn16AKNKGKlNLOhUZvzaTqLi3t65dX3ZQZ94 eE+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783942874; x=1784547674; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Bjup8tkbZReyLVbx7owWNWJpf0WRCU5BarQCoUzbWwU=; b=UYrL/yoSurN6t1uokHacFLb3RGeq/5I62yzvUlFGuPkvnfr+6IY5IjkYVDTBYpxTw0 YYcL8X0Qzvorm+VUkIyho2Rz1FoTVP38vd9uVw1heVdwqzFe314MJk1S02N73d0arO/U DnzT1N9RIBhfMhtUhqjP1LgpSEsiT2wU1bULe4M3DC3YjY8ikUQsa3E2mo43srT2nkoO y9k8vNJ/Y01eRFZ980XpWaTRubb5khjPthGKZVbf9AhllMLDAv+pRAbndq3XAgBSNDCb SS0HAdB/SqPalt5jlTwM037wtpk0bzfnjQ5ckwQ4Dn/eCeI9UmXcY9ADOnjler8n3zui kgjA== X-Forwarded-Encrypted: i=1; AHgh+RqZzD4NEE9XfsG5VRAMpi41ekB5eL4RngxZoRUQ9YbHtto0CIFK7ULnPB8nilqNvFOHX3T3/ifzuBuW6C08JQ==@lists.infradead.org X-Gm-Message-State: AOJu0YzphMW6PTfXaVVt0jM6cTYklylcVFhKreTD5WyBrH12X1UnqadM obv93ndYqEMYkXtEz5xrJvXeTxUo19YiSC3+P6cZmnGGMjntFW0Ner3Aob+2mhtUtQE= X-Gm-Gg: AfdE7cma4/yoPV66/gARN5KRVU3QLCU6qDpr3bRPujeP3AKzh8TbfSvMShKY6HHCHdZ Epxcqzlt5SzCmRRY095E1rWmwD+LReTjBvG4xfsE0EJZz0HFOBjlPyN8ErDFm3RwKKQhRbKcWu4 m64ryMeAjw1uj961z0aBSezsXZByVTtfMfo5m9dl2oK5b+dIp0/4uhRek5i6sNRTrzSdqhdO8Fp 2seiHq47j9wA8iJp9xLKKfeugEYNja6mvslxZ5JfepMpYaWa++Qs8zYjhY50GChUldvDoV0pcrF gFyBBSz3A88YwHIeOTL1BrUfnPm7Gq/IjUn9MGVoZ900q2jqff4v7nOHufhkFSVX1ijOaWzFBQk U5SUYrIz7jPn+dEKg3VSlXc4trY2tKtoOkd5tP4t2BvnGc2NGfz+pkeAotuE5nS7bg3V4iGs1Mz XmMVcppw== X-Received: by 2002:a17:902:ea03:b0:2c0:e2ea:6b0c with SMTP id d9443c01a7336-2ce9ed181f6mr81660085ad.21.1783942873961; Mon, 13 Jul 2026 04:41:13 -0700 (PDT) Received: from lgs.. ([2001:250:5800:1000::f280]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ccc9d59e33sm95978515ad.74.2026.07.13.04.41.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jul 2026 04:41:13 -0700 (PDT) From: Guangshuo Li To: Mauro Carvalho Chehab , Matthias Brugger , AngeloGioacchino Del Regno , Hans Verkuil , Nicolas Dufresne , Johan Hovold , Kees Cook , Guangshuo Li , =?UTF-8?q?Thomas=20Wei=C3=9Fschuh?= , Marco Crivellari , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Cc: stable@vger.kernel.org Subject: [PATCH v2] media: platform: mtk-mdp3: Fix SCP device refcounting Date: Mon, 13 Jul 2026 19:38:59 +0800 Message-ID: <20260713113859.921358-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260713_044115_088885_59A10174 X-CRM114-Status: GOOD ( 11.21 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org mdp_probe() first tries to get the SCP handle with scp_get(). When that fails, it falls back to looking up the SCP platform device with __get_pdev_by_id() and then reads its driver data. The fallback lookup returns the platform device with a reference, just like scp_get() does. However, the fallback path currently drops that reference immediately after platform_get_drvdata(). The driver later still calls scp_put(mdp->scp) unconditionally from the probe error path and from mdp_video_device_release(), which drops the SCP device reference again. Keep the fallback reference until the existing scp_put() call, so that the fallback path follows the same ownership rules as the scp_get() path. Fixes: 8f6f3aa21517 ("media: platform: mtk-mdp3: fix device leaks at probe") Cc: stable@vger.kernel.org Reviewed-by: Johan Hovold Signed-off-by: Guangshuo Li --- v2: - Add Cc stable. - Add Reviewed-by tag from Johan Hovold. - No code changes. drivers/media/platform/mediatek/mdp3/mtk-mdp3-core.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/platform/mediatek/mdp3/mtk-mdp3-core.c b/drivers/media/platform/mediatek/mdp3/mtk-mdp3-core.c index 8f4da4cf55d2..121b1006ffdc 100644 --- a/drivers/media/platform/mediatek/mdp3/mtk-mdp3-core.c +++ b/drivers/media/platform/mediatek/mdp3/mtk-mdp3-core.c @@ -294,7 +294,6 @@ static int mdp_probe(struct platform_device *pdev) goto err_destroy_clock_wq; } mdp->scp = platform_get_drvdata(mm_pdev); - put_device(&mm_pdev->dev); } mdp->rproc_handle = scp_get_rproc(mdp->scp); -- 2.43.0