From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 117DEC4450A for ; Tue, 14 Jul 2026 12:33:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:Message-ID:Date:Subject:CC:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=HRgpQ687rmVlcSLEtzyKur7PumzkNtjmY3LfBO60S8w=; b=V8qm57nefsN/v/MCuGHCToRCFf XfFKnYreRj1af2u5eD3ZRN7RgqUzMtt5KueovjtW97xiYKdZl6bzn14UzdFT5koj572yrE2phzsBT Sd/0TvJDOfwEp+e/2v+lovuTSM3yXsWBfluglnUcANmgX8TlHovO46RB9MSJP7cWPYiAi7ySW2uLT iD3aKgfCvzXt+/HYqtsVhIcdxEjBUUUELrv0Zx/OMP5+IIa1fSYw9nZ8WpMKg0tK7qRIXLc8ddcRL TXomMDEOamZ+HR32V9N89GiwFdhnvHijcBvJakq30PcKP7bjd0Pf+9O2n8JCGu/iKnxrie9WijkkY 7DhD8b/w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wjcKJ-0000000Bx1H-00Gz; Tue, 14 Jul 2026 12:33:31 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wjcKE-0000000Bwy2-06VP for linux-mediatek@lists.infradead.org; Tue, 14 Jul 2026 12:33:28 +0000 X-UUID: 311ae0907f8011f1afed4741b24580c9-20260714 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Type:Content-Transfer-Encoding:MIME-Version:Message-ID:Date:Subject:CC:To:From; bh=HRgpQ687rmVlcSLEtzyKur7PumzkNtjmY3LfBO60S8w=; b=lxTjXlzWOniemOK8C/U0pEFVF7Iadk7voGMIDZPdraHZbWYNdA50Xo4wjLonu5YV6ExKDggy9LGOoHZ5flfNbV64OA7sMb4k81ywUIG7UM888dmicptKvhfbgiWhzQP4iJ27rnhMZ222/3rwYGnvIWItBhJP0d436balCeLKI0I=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.3.17,REQID:85a8d19a-ddb0-4563-9faa-697d28dca7b9,IP:0,U RL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION: release,TS:0 X-CID-META: VersionHash:d497b38,CLOUDID:9b8e2115-ea64-44d4-98db-4e1fb89955a3,B ulkID:nil,BulkQuantity:0,SF:102|136|836|865|888|898,TC:-5,Content:0|15|50| 99|100|102|156|200|213,EDM:-3|-100,IP:nil,URL:0,File:130,RT:0,Bulk:nil,QS: nil,BEC:-1,COL:0,OSI:0,OSA:0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0,ARC :0 X-CID-BVR: 2,SSN|SDN X-CID-BAS: 2,SSN|SDN,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR X-CID-RHF: D41D8CD98F00B204E9800998ECF8427E X-UUID: 311ae0907f8011f1afed4741b24580c9-20260714 Received: from mtkmbs10n1.mediatek.inc [(172.21.101.34)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 1377457510; Tue, 14 Jul 2026 05:33:18 -0700 Received: from mtkmbs11n2.mediatek.inc (172.21.101.187) by MTKMBS09N1.mediatek.inc (172.21.101.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.29; Tue, 14 Jul 2026 20:33:15 +0800 Received: from mtksitap99.mediatek.inc (10.233.130.16) by mtkmbs11n2.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.2562.29 via Frontend Transport; Tue, 14 Jul 2026 20:33:15 +0800 From: Chris Lu To: Marcel Holtmann , Johan Hedberg , Luiz Von Dentz CC: Sean Wang , Will Lee , SS Wu , Steve Lee , Paul Menzel , linux-bluetooth , linux-kernel , linux-mediatek , Chris Lu Subject: [PATCH v10 0/7] Bluetooth: btmtk: Add MT7928 support Date: Tue, 14 Jul 2026 20:33:06 +0800 Message-ID: <20260714123314.814333-1-chris.lu@mediatek.com> X-Mailer: git-send-email 2.45.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260714_053326_080613_6028AD8E X-CRM114-Status: GOOD ( 13.81 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org This patch series adds support for MT7928 (device ID 0x7935) to the btmtk driver, which requires a new two-stage firmware loading process with CBMCU firmware. The series is organized to fix existing issues first, then improve code quality, and finally add new functionality: Patch 1 fixes a DMA out-of-bounds access in btmtksdio_tx_packet() where round_up() alignment causes DMA to read beyond the skb buffer, potentially leaking kernel memory or triggering IOMMU faults. Patch 2 fixes a pre-existing security issue in btmtk_setup_firmware_79xx() by adding comprehensive firmware size validation to prevent out-of-bounds memory access with truncated or malicious firmware files. Patch 3 fixes a pre-existing bug in btmtksdio_setup() where btmtk_fw_get_filename() generates the correct firmware path but is immediately overwritten by snprintf() with a generic legacy format, causing newer chips to request incorrect filenames. Patch 4 fixes a regression introduced in commit 28b7c5a6db74 ("Bluetooth: btmtk: Add MT6639 (MT7927) Bluetooth support") where SDIO devices would incorrectly log "BT HW ver: 0x0000" due to hardcoded dev_id=0. Patch 5 refactors existing firmware download code by replacing magic numbers with a descriptive BTMTK_WMT_PKT_* enum, making the packet sequencing logic clearer. Patch 6 improves BT firmware logging to provide more useful information for debugging: adds firmware filename before loading and displays chip ID as HW version instead of firmware's hwver field. Patch 7 implements MT7928 firmware download flow, which requires loading CBMCU firmware before Bluetooth firmware. The CBMCU firmware uses a two-phase download sequence: Phase 1 downloads the section containing global descriptor and signature data, Phase 2 downloads the remaining firmware sections. Tested on MT7928 hardware with successful firmware loading and Bluetooth functionality verification. Changes in v10: - Add Patch 1 to fix DMA out-of-bounds access in btmtksdio_tx_packet() Discovered during v9 review - round_up() alignment can cause DMA to read beyond skb buffer, potentially leaking kernel memory or triggering IOMMU faults. Fix by expanding skb tailroom and zero-filling padding. Changes in v9: - Reorder patches to group SDIO fixes together (Patch 3-4) - Patch 2 (was Patch 1 in v8): Fix firmware size validation in btmtk_setup_firmware_79xx() - Patch 3 (was Patch 1, new in v9): Fix firmware filename override in btmtksdio_setup() where btmtk_fw_get_filename() result was incorrectly overwritten by snprintf() - Patch 4 (was Patch 2 in v8): Fix SDIO device logging regression SDIO devices were passing hardcoded 0, causing "BT HW ver: 0x0000" log Changes in v8: - Add Patch 2 (now Patch 3 in v10) to fix firmware size validation in btmtk_setup_firmware_79xx() - Add Patch 3 (now Patch 4 in v10) to fix SDIO device logging regression SDIO devices were passing hardcoded 0, causing "BT HW ver: 0x0000" log Changes in v7: - Patch 5 (was Patch 1): Extend magic number refactoring to btmtk_setup_firmware() in addition to btmtk_setup_firmware_79xx() for consistency - Patch 6 (was Patch 2): Fix potential buffer over-read by using %.16s format specifier for hdr->datetime which is a 16-byte array that may not be null-terminated - Patch 7 (was Patch 3): Apply same %.16s fix to CBMCU firmware logging Changes in v6: - Fix timeout handling in btmtk_cbmcu_patch_status() to return -ETIMEDOUT instead of success when polling exhausts retry count - Add integer overflow protection in btmtk_load_cbmcu_firmware() using check_mul_overflow() and check_add_overflow() Changes in v5: - Split into three patches: refactoring, logging improvement, and new feature - Add Patch 6 (was Patch 2) to improve BT firmware logging independently - Apply same logging improvements to CBMCU firmware in Patch 7 (was Patch 3) Changes in v4: - Split into two patches: refactoring and new feature - Add BTMTK_WMT_PKT_* enum to improve code readability - Replace magic numbers (0xF0, 0xF1) with descriptive macros Changes in v3: - Add firmware size validation with bounds checking - Improve error messages with context information Changes in v2: - Simplified enum usage by consolidating status definitions Chris Lu (7): Bluetooth: btmtksdio: Fix DMA out-of-bounds access in TX path Bluetooth: btmtk: Add firmware size validation in btmtk_setup_firmware_79xx() Bluetooth: btmtksdio: Remove redundant firmware filename override Bluetooth: btmtksdio: Pass hardware dev_id to mt79xx_setup() Bluetooth: btmtk: Replace magic numbers with WMT packet flag enum Bluetooth: btmtk: Improve BT firmware logging Bluetooth: btmtk: Add MT7928 support drivers/bluetooth/btmtk.c | 427 +++++++++++++++++++++++++++++++++- drivers/bluetooth/btmtk.h | 9 + drivers/bluetooth/btmtksdio.c | 40 +++- 3 files changed, 457 insertions(+), 19 deletions(-) -- 2.45.2