From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 318A6C4450F for ; Fri, 17 Jul 2026 07:21:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date :Subject:CC:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ZmTvoKDC7PrrRL2tdxxzKf0b2x6nEFuLyd0DX3GSMTw=; b=rrD6KT++t+wKril4vyYpjpRkZ6 wgjcMj7qeGRYOjnip37BspHmTPM5itjpC2cVMMijEyImNuu342KNt4u2X64mkHa110v2pvU+rq0sd E/U7r1g9QBs9ugKjZ4YANL7q06Q4WkX0MYbA/jO//lCms8o7MZEjhU/Ht3A6LCTmzA3AqfBXC5Erf HxngWNmRQ4vb0kn1SZg+HjR/CdZ8AVZ8NqX9Vf2Z6rQ7kmCXCfbFcRA+lARcm+KwdS4POI5SRolPJ ULCeQFciKXIMEKjTKhH4DZSUwURDNkzpyv97EZYjuVFlPNG+lOGzE1J1hT9CLsHobDNSgL2++OQR+ 4rsR77sA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wkctJ-00000001OPN-0Q4a; Fri, 17 Jul 2026 07:21:49 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wkctE-00000001OLQ-2wxp for linux-mediatek@lists.infradead.org; Fri, 17 Jul 2026 07:21:47 +0000 X-UUID: 2604980481b011f1acbe4559397dec65-20260717 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Type:Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:CC:To:From; bh=ZmTvoKDC7PrrRL2tdxxzKf0b2x6nEFuLyd0DX3GSMTw=; b=ptU29Hk+lreBMnOpZLu5v4zW8Ujo1bgO6ojXgnfsMKG3TzgADL+X6gXxLU52c3iOIsP6xmeSdxb1ygoI3Vfs0bujafchML0aDBjV15eqOeyIHnKpV3OINVVWHP6scTemXNx1oJCN2Xq32LDNUst2kT4d/im4Uas32+1qhaFmC04=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.3.18,REQID:54bcc62f-57c2-48c0-aad8-893c56d27f9d,IP:0,U RL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION: release,TS:0 X-CID-META: VersionHash:8a735a6,CLOUDID:4b28f450-9df4-4a32-98eb-0af8dcdad6c0,B ulkID:nil,BulkQuantity:0,SF:81|82|102|836|865|888|898,TC:-5,Content:0|15|5 0|99|200|213,EDM:-3,IP:nil,URL:0,File:130,RT:0,Bulk:nil,QS:nil,BEC:-1,COL: 0,OSI:0,OSA:0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0,ARC:0 X-CID-BVR: 2,SSN|SDN X-CID-BAS: 2,SSN|SDN,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR X-CID-RHF: D41D8CD98F00B204E9800998ECF8427E X-UUID: 2604980481b011f1acbe4559397dec65-20260717 Received: from mtkmbs13n2.mediatek.inc [(172.21.101.108)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 77278393; Fri, 17 Jul 2026 00:21:37 -0700 Received: from mtkmbs11n1.mediatek.inc (172.21.101.185) by mtkmbs10n1.mediatek.inc (172.21.101.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.29; Fri, 17 Jul 2026 15:21:35 +0800 Received: from mtksitap99.mediatek.inc (10.233.130.16) by mtkmbs11n1.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.2562.29 via Frontend Transport; Fri, 17 Jul 2026 15:21:35 +0800 From: Chris Lu To: Marcel Holtmann , Johan Hedberg , Luiz Von Dentz CC: Sean Wang , Will Lee , SS Wu , Steve Lee , Paul Menzel , linux-bluetooth , linux-kernel , linux-mediatek , Chris Lu , Sashiko Subject: [PATCH v14 1/7] Bluetooth: btmtksdio: Fix SKB handling issues in TX path Date: Fri, 17 Jul 2026 15:21:27 +0800 Message-ID: <20260717072133.2858136-2-chris.lu@mediatek.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20260717072133.2858136-1-chris.lu@mediatek.com> References: <20260717072133.2858136-1-chris.lu@mediatek.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260717_002144_747418_66F2405E X-CRM114-Status: GOOD ( 18.41 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Fix two SKB handling issues in btmtksdio_tx_packet(): 1. DMA out-of-bounds read: The driver aligns transfer size to 256 bytes using round_up(), but does not ensure the skb buffer has sufficient tailroom, causing DMA to read beyond the buffer. Fix by expanding skb tailroom if needed and zero-filling the padding. 2. Cloned SKB corruption: The driver modifies SKB header (via skb_push) and tail (via skb_put_zero) without checking if the SKB is cloned. If the Bluetooth core passes a cloned SKB (e.g., from L2CAP retransmission queues), the driver corrupts the shared data buffer for other subsystems. Fix by calling skb_unshare() at function entry to ensure we have a private copy before any modifications. Fixes: 9aebfd4a2200 ("Bluetooth: mediatek: add support for MediaTek MT7663S and MT7668S SDIO devices") Reported-by: Sashiko Signed-off-by: Chris Lu Assisted-by: Claude:Sonnet-4.5 --- drivers/bluetooth/btmtksdio.c | 46 +++++++++++++++++++++++++++++++---- 1 file changed, 41 insertions(+), 5 deletions(-) diff --git a/drivers/bluetooth/btmtksdio.c b/drivers/bluetooth/btmtksdio.c index c6f80c419e90..42cb0bbb720f 100644 --- a/drivers/bluetooth/btmtksdio.c +++ b/drivers/bluetooth/btmtksdio.c @@ -272,9 +272,20 @@ static int btmtksdio_tx_packet(struct btmtksdio_dev *bdev, struct sk_buff *skb) { struct mtkbtsdio_hdr *sdio_hdr; + unsigned int padded_len, pad_len; int err; - /* Make sure that there are enough rooms for SDIO header */ + /* Ensure SKB is not cloned before any modification. + * If cloned (e.g., L2CAP retransmission queues), create a + * private copy to avoid corrupting shared data buffer. + */ + skb = skb_unshare(skb, GFP_ATOMIC); + if (!skb) + return -ENOMEM; + + /* Make sure that there are enough rooms for SDIO header. + * After skb_unshare(), we have exclusive ownership of the buffer. + */ if (unlikely(skb_headroom(skb) < sizeof(*sdio_hdr))) { err = pskb_expand_head(skb, sizeof(*sdio_hdr), 0, GFP_ATOMIC); @@ -290,20 +301,45 @@ static int btmtksdio_tx_packet(struct btmtksdio_dev *bdev, sdio_hdr->reserved = cpu_to_le16(0); sdio_hdr->bt_type = hci_skb_pkt_type(skb); + /* Calculate padded length for block-aligned DMA transfer. + * SDIO requires transfers to be block-aligned (MTK_SDIO_BLOCK_SIZE). + * Pad with zeros to prevent DMA from reading beyond skb buffer. + */ + padded_len = round_up(skb->len, MTK_SDIO_BLOCK_SIZE); + pad_len = padded_len - skb->len; + + if (pad_len > 0) { + /* Ensure sufficient tailroom for padding */ + if (unlikely(skb_tailroom(skb) < pad_len)) { + err = pskb_expand_head(skb, 0, pad_len, GFP_ATOMIC); + if (err < 0) + goto err_skb_pull; + /* Reassign sdio_hdr after buffer reallocation */ + sdio_hdr = (void *)skb->data; + } + + /* Zero-fill padding to prevent information disclosure */ + skb_put_zero(skb, pad_len); + } + clear_bit(BTMTKSDIO_HW_TX_READY, &bdev->tx_state); - err = sdio_writesb(bdev->func, MTK_REG_CTDR, skb->data, - round_up(skb->len, MTK_SDIO_BLOCK_SIZE)); + err = sdio_writesb(bdev->func, MTK_REG_CTDR, skb->data, padded_len); if (err < 0) - goto err_skb_pull; + goto err_skb_trim; - bdev->hdev->stat.byte_tx += skb->len; + /* Record actual transmitted data (excluding padding) */ + bdev->hdev->stat.byte_tx += le16_to_cpu(sdio_hdr->len); kfree_skb(skb); return 0; +err_skb_trim: + if (pad_len > 0) + skb_trim(skb, skb->len - pad_len); err_skb_pull: skb_pull(skb, sizeof(*sdio_hdr)); + kfree_skb(skb); return err; } -- 2.45.2