From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5271FC44524 for ; Sat, 18 Jul 2026 23:36:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=qVQM0So1MCL7ilj5LYZg6mzfa82XvkJyQz/kOpkAFIY=; b=VSYy9au7hCkxpjaUWV0IhfJ9oY 8UuaIYksfBihnLioG0o+TzSFftryt25IwtL/elF299va47sP3/eJeSLaWGq/ftvqEary4iL0/5+OC +6UJ9gzZo6TLHq0HFIXU7mZv/OQ7g24hUARwNo+3UVpATCyMDBRxMVm2O7s/uoGNSUZXCaKaEHXps 3AUhDMTBRIgbY51URATSLgwAcDA7Ttwwr8sleToT2uJB3n9xQEGO1aCAJZTRhp+3I0K1ecj9XXp1/ KSK900W1bHxcky9Y23LHNj2sYNWs77vUH1UkSiWuNQO0BzuDph2hMlVQFCI7vqhQFuSkav5gL94rv EzLu8KpQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wlEZi-00000004bcU-1B3e; Sat, 18 Jul 2026 23:36:06 +0000 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wlEZe-00000004bZb-2eAE for linux-mediatek@lists.infradead.org; Sat, 18 Jul 2026 23:36:04 +0000 Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-493ec555a26so58677265e9.0 for ; Sat, 18 Jul 2026 16:36:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784417761; x=1785022561; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=qVQM0So1MCL7ilj5LYZg6mzfa82XvkJyQz/kOpkAFIY=; b=NsUov35uBFlWfmx2+MwrmaXUW9nHfQp29hSXqdzKtgkNDiJ81B4DKwztIzeDV+LNg6 wV8o0j7950qq1L4y0EFHTjAwtqbs4wrFWUnnvKMIMFVG9PQtF/fZ5u8UBGXouc3U8dcr kR+k8MQppxsjAZEs4hF5zJ1PymKOfiJXbjRFmhYk/qeqXVi8FisnaJYcCppvXivOq4Ty 62/3pwvXo9l5AVaEWLFhPcsUCn9cvYV8ItMq3jFJ2Wo0uvi3qybs4qsR1iDteeAHOia5 Vz/5vjy7/SnHsmKPS0ub2Gliu+2KtmrSYylzMxRFwdQDh8oYCF+fbve1AAN5IDZCX1lJ DlVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784417761; x=1785022561; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=qVQM0So1MCL7ilj5LYZg6mzfa82XvkJyQz/kOpkAFIY=; b=KaBW74jwehivlMF/PplOMbQyALfZglWJXh3DtZNVl7C1Y57FjwjLfMvCw3epRTUe91 h13kLsaM5p6Wt7vPuqa8raXvD15nWv8SLAmefr0IBmc0nJtC571ugoVBKZxOmHS9oEDx mLNfXJXwiffBnNC+v/4R+zEFSPZHlpWRxhxL4lUw0p11NZrLYKOtqT7H1lcbISIELwvP /fF3fIL/uxtc2uAu/2CJhLqovqMbGU7eXBhCMBqeGykgyvLGDeby4cqo7CizOKfwuwAF 5h9ZNaEpip5BHQbuQH9rf6PH0uwTm9KWe6rY8BWLCZxjq4OCmw3pY09w1s4BwYHIDSuA s/xA== X-Forwarded-Encrypted: i=1; AHgh+RoZRN2o78YoTtndPYnOWORifLPJLEGckgyrM2PO/lJNkBnYXamdXIrOrse9CKYHSICySRpUx0vneyJOQQrdQQ==@lists.infradead.org X-Gm-Message-State: AOJu0Yz2e325voBjk0sQcwUwtglwzo+fBqhw5B+BQzgKT9HAUpcaHZ6Q d1QorBTtChhlv1EbyqD5OGoQdvOdOuaQ+fwNOBSUhc4B0XJOq+1M/4Rz X-Gm-Gg: AfdE7ckY34NyNE2HRZTnP3buHJpAeJ5fHlLSa+/sNM6TF9yl+vewMoUcC0sqjtgqPDu aoLRn81s2LLtOciIZBkyqq4TRVafueLoyljYbJzYUIDKjyXqhh62ie30jVKftDZJH97jmPBrl2Q jcw/2M97kc0Q8uo1MHbrcNJBDczIuoaMLVLqLPbqMpAotEYGKPS/mAUSR4Ck9j4UteyzT+HyuYF UoLIQBKPQqqtEe+Drs7iL/i1ZgvbvrYQCGCnqa4UTOc25OFk7Hct7hHy5JQVqcJ5IgzZZwGvDII GsMnNPGXlwDg23l509ga8+vhtPKD8xCc+altNZQzVtoOY0aG/DxfkfdQqeXmNVs6L6C0zgcH98g IjHHdHYUxQ6LszVviNs/yfnAeXfiEph+Mvk5wQjOEDJ6zlS8eGY9qYXiwP467DT7lIsSTcRNBsO 9QJAn7wCMF+g== X-Received: by 2002:a05:600c:4e94:b0:495:571e:e5d3 with SMTP id 5b1f17b1804b1-495571ee75fmr14134205e9.36.1784417760679; Sat, 18 Jul 2026 16:36:00 -0700 (PDT) Received: from [127.0.0.2] ([2a01:14:111:ccf0:645b:9e5c:7fe3:c09f]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4954a2a24b6sm160964675e9.3.2026.07.18.16.35.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Jul 2026 16:36:00 -0700 (PDT) From: Diogo Silva Date: Sun, 19 Jul 2026 01:35:32 +0200 Subject: [PATCH 01/15] drm/exynos: remove dependency on DRM simple helpers MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260719-drm_simple_encoder_init-v1-1-a78c509e3062@gmail.com> References: <20260719-drm_simple_encoder_init-v1-0-a78c509e3062@gmail.com> In-Reply-To: <20260719-drm_simple_encoder_init-v1-0-a78c509e3062@gmail.com> To: Jingoo Han , Inki Dae , Seung-Woo Kim , Kyungmin Park , David Airlie , Simona Vetter , Krzysztof Kozlowski , Peter Griffin , Alim Akhtar , Laurent Pinchart , Tomi Valkeinen , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Michal Simek , Thierry Reding , Mikko Perttunen , Jonathan Hunter , Stefan Agner , Alison Wang , Anitha Chrisanthus , David Airlie , Gerd Hoffmann , Dmitry Osipenko , Gurchetan Singh , Chia-I Wu , Jyri Sarha , Liu Ying , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Chun-Kuang Hu , Philipp Zabel , Matthias Brugger , AngeloGioacchino Del Regno , Geert Uytterhoeven , Xinliang Liu , Sumit Semwal , Yongqin Liu , John Stultz , Liviu Dudau , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Jonathan Corbet , Shuah Khan Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, virtualization@lists.linux.dev, imx@lists.linux.dev, linux-mediatek@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-doc@vger.kernel.org, Diogo Silva X-Mailer: b4 0.15.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260718_163602_726484_4C03D2E5 X-CRM114-Status: GOOD ( 15.15 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org The simple KMS helpers are deprecated because they only add an intermediate layer between drivers and atomic modesetting. Open-code drm_simple_encoder_init() by calling drm_encoder_init() directly and providing driver-local drm_encoder_funcs. Also check the return value from drm_encoder_init() to avoid silent failures. Signed-off-by: Diogo Silva --- drivers/gpu/drm/exynos/exynos_dp.c | 13 +++++++++++-- drivers/gpu/drm/exynos/exynos_drm_dpi.c | 14 ++++++++++++-- drivers/gpu/drm/exynos/exynos_drm_dsi.c | 11 +++++++++-- drivers/gpu/drm/exynos/exynos_drm_vidi.c | 14 ++++++++++++-- drivers/gpu/drm/exynos/exynos_hdmi.c | 15 +++++++++++++-- 5 files changed, 57 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_dp.c b/drivers/gpu/drm/exynos/exynos_dp.c index b80540328150..1598892c602b 100644 --- a/drivers/gpu/drm/exynos/exynos_dp.c +++ b/drivers/gpu/drm/exynos/exynos_dp.c @@ -24,11 +24,11 @@ #include #include #include +#include #include #include #include #include -#include #include #include "exynos_drm_crtc.h" @@ -79,6 +79,10 @@ static void exynos_dp_nop(struct drm_encoder *encoder) /* do nothing */ } +static const struct drm_encoder_funcs exynos_dp_encoder_funcs = { + .destroy = drm_encoder_cleanup, +}; + static const struct drm_encoder_helper_funcs exynos_dp_encoder_helper_funcs = { .mode_set = exynos_dp_mode_set, .enable = exynos_dp_nop, @@ -95,7 +99,12 @@ static int exynos_dp_bind(struct device *dev, struct device *master, void *data) dp->drm_dev = drm_dev; - drm_simple_encoder_init(drm_dev, encoder, DRM_MODE_ENCODER_TMDS); + ret = drm_encoder_init(drm_dev, encoder, &exynos_dp_encoder_funcs, + DRM_MODE_ENCODER_TMDS, NULL); + if (ret) { + dev_err(dp->dev, "Failed to initialize encoder\n"); + return ret; + } drm_encoder_helper_add(encoder, &exynos_dp_encoder_helper_funcs); diff --git a/drivers/gpu/drm/exynos/exynos_drm_dpi.c b/drivers/gpu/drm/exynos/exynos_drm_dpi.c index 0dc36df6ada3..4e42a1da81d1 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_dpi.c +++ b/drivers/gpu/drm/exynos/exynos_drm_dpi.c @@ -12,10 +12,10 @@ #include #include +#include #include #include #include -#include #include