From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 89611C44523 for ; Sat, 18 Jul 2026 23:36:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=/m2It/8MnIxoX8xbOWjx4p2UhJgFTMfhBAqsULip3yI=; b=EtoyvOOk7Cfpxs3dMjnocF932j +xnOS3qeHn4zZ09rZjlszOvHEnPoNPHb9+uWULv4A9G8W2nHMrYRO7F2J+Hzrnt/6f62jsB9hG5Ad pA5QmuhBn+7ffd7rwLCuiABp4y3R32YKWq9kAfxmW9Uv/8QqxebIPpgvK1hgVlSQLNw8HD0dC6XJb 4whjOuPArJpK54hMJaSAMLN4weM7Kky6HBL8fX2hX2LkVbjGlaCHl32NddtaGyB8Tq17q2Q1iVwbj U5b+eqWi2v4SH80XeKWtU8BGJXOp8layREV+3tnGCGXJjbcVyxxkr0+SKeDkOeqb78V8MtJo1QKwY qLxTFE9A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wlEa0-00000004bw3-1oAH; Sat, 18 Jul 2026 23:36:24 +0000 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wlEZx-00000004brN-0d1v for linux-mediatek@lists.infradead.org; Sat, 18 Jul 2026 23:36:23 +0000 Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-4953ddae026so28559815e9.3 for ; Sat, 18 Jul 2026 16:36:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784417779; x=1785022579; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=/m2It/8MnIxoX8xbOWjx4p2UhJgFTMfhBAqsULip3yI=; b=GZkQZyrJlB8YHZbZJE7hhHbAN4e3qhvy5VR1bDb026dNPFKqekEkFLvQkKwsO+6aom mL65owsfi8K6s4P61+LRUFk7VzH4i9rY2t7WW110yGXWz1jNMOqx9nZekUYWdCF929sX Gl6PWDMS0PbUVuYTuRgEZ4hkS2bzmCmZAkqZXKbV7VZTruigZyemYXXjrHb8kPxl7P1x OXLJpaBNAsT0HwVkgCphF68YaK0M7TakON5BYGreit2/2liugE2JpNrsT7Hjt+KmPrsU fnJU0qTwpDIH4JNeofvEAze5rAo7EU37Ow1TYKvrxv+X6oo5rzjMfm+XlI8J3y1sTnAI SrwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784417779; x=1785022579; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=/m2It/8MnIxoX8xbOWjx4p2UhJgFTMfhBAqsULip3yI=; b=XoXcwyizVTXKGTVTAo/0YE1w1e9xeKrQj1ZghgSdQhzbySYslreoObtvFYoGHpR23v 4bDUhZHcY6cWXong3sgy8MVjQC101hoME8yu5y8WiyUMsgc0nPuyPrCd1tKlJzcjCDxg HWLORyFaR/KPYGxEfX6MwY/YXglUsld6Jft5QD2nd8TpmnySII33lSbWMYqbbAOzDMN5 nC1tmjLDiSku2HY1GRnzQ4I4ReyF99M0ZORhs3YR7SKwg+nVJj8NUKH87o6B0Gy8X1fN 2NOybcs9Jb3HscoxTfprIeZF5mU1ga5KsSzPAh6MW9MlLlRuNRPRwUnwj7uZKkqfph/0 Lsnw== X-Forwarded-Encrypted: i=1; AHgh+RrROka9+of3dGZWOhq24FqYuLlKB6QLs7KYQdwkOyalQoRYqc1ftg1u0EDuDu2pRYsP+ibtNohD0qaLJGATOA==@lists.infradead.org X-Gm-Message-State: AOJu0YyKuagH4mrlxDMRtG8ROdTV/4Eb73oNuoYKuzunZlNCzo4xGJkI 5UDwAl6jeT+6c663LC1HbI0upBfI5cG1APqsIRtkcwgCMqpYhQY3HH4Q X-Gm-Gg: AfdE7cn5Nr05BZIak29k68qhidtWgExkg4sTo4ZODfL26DnVpbj2PWDXrSED+xzZlzG 4QGYb8K8l2E3zv/Qiuk0B/Ym5c0cRqDPu18Zk15gpLDUAMegFgzzSKy/EZY6wSqnNr2G7x6EEX3 qHZ/UVNh3KG2udILnHpvl29jO4crxn1ORI2ciceyJYlqRGWbXyF2knrAMSURNDEF0Rg57/RMK4Q BChWerSgyNfdpiNwcuWqusLmZJtWSNoyOkuWvX/JEA25s6oMg8cLp5X8YYcCWq+XymcmazLBuys 7tHiv0EV05SY5RHRXuQABmBjPZGx4Z4qbBUtGDOGgK8lOno4+hevJHNVGm7RJoY7ieNfbWygSaK kLlz9vWnoESp+GuFFXkOAveRYItVudjcVNOP/Htd3dsGd83kHrAB0ItvvwtUD0VqN+13BnJELai IIjte2/oasRIKUJH/BP3uE X-Received: by 2002:a7b:ca50:0:b0:495:3fe1:4ce4 with SMTP id 5b1f17b1804b1-4954a40c110mr70449165e9.26.1784417779234; Sat, 18 Jul 2026 16:36:19 -0700 (PDT) Received: from [127.0.0.2] ([2a01:14:111:ccf0:645b:9e5c:7fe3:c09f]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4954a2a24b6sm160964675e9.3.2026.07.18.16.36.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Jul 2026 16:36:18 -0700 (PDT) From: Diogo Silva Date: Sun, 19 Jul 2026 01:35:37 +0200 Subject: [PATCH 06/15] drm/virtio: remove dependency on DRM simple helpers MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260719-drm_simple_encoder_init-v1-6-a78c509e3062@gmail.com> References: <20260719-drm_simple_encoder_init-v1-0-a78c509e3062@gmail.com> In-Reply-To: <20260719-drm_simple_encoder_init-v1-0-a78c509e3062@gmail.com> To: Jingoo Han , Inki Dae , Seung-Woo Kim , Kyungmin Park , David Airlie , Simona Vetter , Krzysztof Kozlowski , Peter Griffin , Alim Akhtar , Laurent Pinchart , Tomi Valkeinen , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Michal Simek , Thierry Reding , Mikko Perttunen , Jonathan Hunter , Stefan Agner , Alison Wang , Anitha Chrisanthus , David Airlie , Gerd Hoffmann , Dmitry Osipenko , Gurchetan Singh , Chia-I Wu , Jyri Sarha , Liu Ying , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Chun-Kuang Hu , Philipp Zabel , Matthias Brugger , AngeloGioacchino Del Regno , Geert Uytterhoeven , Xinliang Liu , Sumit Semwal , Yongqin Liu , John Stultz , Liviu Dudau , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Jonathan Corbet , Shuah Khan Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, virtualization@lists.linux.dev, imx@lists.linux.dev, linux-mediatek@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-doc@vger.kernel.org, Diogo Silva X-Mailer: b4 0.15.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260718_163621_220358_DB0C0D8E X-CRM114-Status: GOOD ( 12.84 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org The simple KMS helpers are deprecated because they only add an intermediate layer between drivers and atomic modesetting. Open-code drm_simple_encoder_init() by calling drm_encoder_init() directly and providing driver-local drm_encoder_funcs. Also check the return value from drm_encoder_init() to avoid silent failures. Signed-off-by: Diogo Silva --- drivers/gpu/drm/virtio/virtgpu_display.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_display.c b/drivers/gpu/drm/virtio/virtgpu_display.c index 44ffffec550f..67023d91d40b 100644 --- a/drivers/gpu/drm/virtio/virtgpu_display.c +++ b/drivers/gpu/drm/virtio/virtgpu_display.c @@ -28,11 +28,11 @@ #include #include #include +#include #include #include #include #include -#include #include #include @@ -232,6 +232,10 @@ static enum drm_mode_status virtio_gpu_conn_mode_valid(struct drm_connector *con return MODE_BAD; } +static const struct drm_encoder_funcs virtio_gpu_enc_funcs = { + .destroy = drm_encoder_cleanup, +}; + static const struct drm_encoder_helper_funcs virtio_gpu_enc_helper_funcs = { .mode_set = virtio_gpu_enc_mode_set, .enable = virtio_gpu_enc_enable, @@ -306,7 +310,11 @@ static int vgdev_output_init(struct virtio_gpu_device *vgdev, int index) if (vgdev->has_edid) drm_connector_attach_edid_property(connector); - drm_simple_encoder_init(dev, encoder, DRM_MODE_ENCODER_VIRTUAL); + ret = drm_encoder_init(dev, encoder, &virtio_gpu_enc_funcs, + DRM_MODE_ENCODER_VIRTUAL, NULL); + if (ret) + return ret; + drm_encoder_helper_add(encoder, &virtio_gpu_enc_helper_funcs); encoder->possible_crtcs = 1 << index; -- 2.54.0