From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 17078C4452B for ; Mon, 20 Jul 2026 15:40:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=XyYn7XebW1XE8vBENDzZtPaPly9Do87l9WwImEGfz+U=; b=3hBhX0ymri6DjdtSD0o2z4e5hW Q2v1YQQjUEUbe2u8BJ4qUGaTFAYelb65eMfBcHlq9CQj5zSVa6HmW1r+KESl45uNVk32hjuQSCQL5 0sDsNybojmnHTuIfQf2wYGSQdHfohCUapRopKGJHm9wj5AtKi4IGfgQHJKk5aZk5J3CD2kXhMQv3L oDh7c4Af5ea1adiY6eAV3I9FrSiTqnQyE+adSuAnxk0clHAXUIx129KQGTi088yp10igH1he8ww7t JQhKdQH4iv+rc1Gxj/PMgaLHJ0sOwcdLwFmgh/iA28ZDlSsE94+0HqRKXs4eg8EmnfZgWBLYVo4bY JF1a5VHg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wlq6x-00000007DtW-3eE8; Mon, 20 Jul 2026 15:40:55 +0000 Received: from mail-wr1-x431.google.com ([2a00:1450:4864:20::431]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wlq6t-00000007DqW-27QO for linux-mediatek@lists.infradead.org; Mon, 20 Jul 2026 15:40:52 +0000 Received: by mail-wr1-x431.google.com with SMTP id ffacd0b85a97d-476a130c138so6779634f8f.0 for ; Mon, 20 Jul 2026 08:40:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784562050; x=1785166850; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=XyYn7XebW1XE8vBENDzZtPaPly9Do87l9WwImEGfz+U=; b=B6a6qJyyt8oIc1WHf8CL3fFHHKeukD0QIKO9M1jiN0vff7qqJUq+t9mOJMXU7xM96P zScC26k6O1wPkCz08axL0XEz0Orhz/ehobld90NpmW9+wj4k/KO89q/qgoDw6QuiO+rX QxRRqLL9wepq4JMzaGZybX2JxN9DpKo4jbB5jiSstplWr/fm6MknpRUnalRFiwNWAq+1 cObfZDSLLMdoeIWmME5DM6Fizhuo68s+d2piGQVKnrkGyCwSco6OLAlcsvTfaM1VnqAm yZENZE21ryUOxnUX5xLFPdaeGDNXEtt1Xa7Aqx4899MZonwvrRrO7qpHAfzStXmKBh5q P5Xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784562050; x=1785166850; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=XyYn7XebW1XE8vBENDzZtPaPly9Do87l9WwImEGfz+U=; b=ROwqOOGQqOm5PFSrwqn0Y1ozvwoYjoSy1HTBk2FhmT8HkzaAU8LjllK0DO/vDMq7cH zvpTFukc2vtlu8FfakqNd3ucjnEIePIbBTzVLFzhPVlUganowpkaty+rLDFDq7zgSMxE r79VdhHu702s9P6Q6em4uisln0NQ+Sa+cwdWg9DyYfkkQulffWzY8xi7AfAFJ0UCyoMA Zf3auRqWCoMZtnv4bCaWfn6LXcSmj/GyBlOZhy9mEoGRTtuPS97qgvn3VWt/3oq8PDP+ IGQELhbRld2+/OzcQZmMtHCPTdNwK5f12DqocxmmGs6DE3RFdoij9sAMKsCbV5Tp+59r v3zQ== X-Forwarded-Encrypted: i=1; AHgh+Rooa28TQivWVnT3QUfgoGudE6UyyeQQcVR6O7mIK4Qn0A4ambxSA+Mq6rxNLe3MH2wCEeDvidhZuiOuRiyiVg==@lists.infradead.org X-Gm-Message-State: AOJu0YxaYd0duuOAImEoveDfvujLxsYB9kzRWXCILX0tJs/bUwV+Fr0Z uBg5ffZSmu8VVwUgXBc66AR016/ql5ByQ+b7eBML066XCzcufT7J93Sn X-Gm-Gg: AR+sD13D4vmNh75K0pmrNFKa7IcIebg4HPlQn7WZbENIMAmrol5NfTq+CWjTlDQRaRu IwPjcrZ5lP3uBTvFfYWRLiFYM01xhXc1plzyF0c0EUoDxuHKDCl2sv+fHpro2V52P8iABSv1IDZ 792wL1yY4KCIz757HgwF3H/fXxsegCEDzn3tdPnaeq1DXO5B1vCb6XWumXJS3sRz/YdSzehQxDZ 7tXkNPWo8jcPfLjgwzGp+OHJ3qww7CGwnp8s/s2GPMbCdFhdNn/y/jtiWMkfOJyvfACvdu3OO3L ge1pWMoAkua6un0EODlBXoBvuK2RP6aGWg73wctP2CqWTz02HrRkvtRIPQjynAYx8s5U6Yl4HMt bIyXtQbY6OiFNo9Ol2hJsWxN4LXKkulEwXsV90mHhqpFI7Pwj2H04GWItht1sKc7Vw8es4hQrkz l+AgcqfEvHxQ== X-Received: by 2002:a5d:5885:0:b0:46e:1815:6a83 with SMTP id ffacd0b85a97d-47f62318f12mr16050393f8f.29.1784562049630; Mon, 20 Jul 2026 08:40:49 -0700 (PDT) Received: from [127.0.0.2] ([2a01:14:111:ccf0:e9c1:2f80:10a9:c708]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47f67466e09sm32667936f8f.21.2026.07.20.08.40.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jul 2026 08:40:49 -0700 (PDT) From: Diogo Silva Date: Mon, 20 Jul 2026 17:40:33 +0200 Subject: [PATCH v2 01/15] drm/exynos: remove dependency on DRM simple helpers MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260720-drm_simple_encoder_init-v2-1-5020b630668a@gmail.com> References: <20260720-drm_simple_encoder_init-v2-0-5020b630668a@gmail.com> In-Reply-To: <20260720-drm_simple_encoder_init-v2-0-5020b630668a@gmail.com> To: Jingoo Han , Inki Dae , Seung-Woo Kim , Kyungmin Park , David Airlie , Simona Vetter , Krzysztof Kozlowski , Peter Griffin , Alim Akhtar , Laurent Pinchart , Tomi Valkeinen , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Michal Simek , Thierry Reding , Mikko Perttunen , Jonathan Hunter , Stefan Agner , Alison Wang , Anitha Chrisanthus , David Airlie , Gerd Hoffmann , Dmitry Osipenko , Gurchetan Singh , Chia-I Wu , Jyri Sarha , Liu Ying , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Chun-Kuang Hu , Philipp Zabel , Matthias Brugger , AngeloGioacchino Del Regno , Geert Uytterhoeven , Xinliang Liu , Sumit Semwal , Yongqin Liu , John Stultz , Liviu Dudau , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Jonathan Corbet , Shuah Khan Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, virtualization@lists.linux.dev, imx@lists.linux.dev, linux-mediatek@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-doc@vger.kernel.org, Diogo Silva X-Mailer: b4 0.15.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260720_084051_597410_D3808527 X-CRM114-Status: GOOD ( 15.13 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org The simple KMS helpers are deprecated because they only add an intermediate layer between drivers and atomic modesetting. Open-code drm_simple_encoder_init() by calling drm_encoder_init() directly and providing driver-local drm_encoder_funcs. Also check the return value from drm_encoder_init() to avoid silent failures. Signed-off-by: Diogo Silva --- drivers/gpu/drm/exynos/exynos_dp.c | 13 +++++++++++-- drivers/gpu/drm/exynos/exynos_drm_dpi.c | 13 +++++++++++-- drivers/gpu/drm/exynos/exynos_drm_dsi.c | 11 +++++++++-- drivers/gpu/drm/exynos/exynos_drm_vidi.c | 13 +++++++++++-- drivers/gpu/drm/exynos/exynos_hdmi.c | 14 ++++++++++++-- 5 files changed, 54 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_dp.c b/drivers/gpu/drm/exynos/exynos_dp.c index b80540328150..957382223956 100644 --- a/drivers/gpu/drm/exynos/exynos_dp.c +++ b/drivers/gpu/drm/exynos/exynos_dp.c @@ -24,11 +24,11 @@ #include #include #include +#include #include #include #include #include -#include #include #include "exynos_drm_crtc.h" @@ -79,6 +79,10 @@ static void exynos_dp_nop(struct drm_encoder *encoder) /* do nothing */ } +static const struct drm_encoder_funcs exynos_dp_encoder_funcs = { + .destroy = drm_encoder_cleanup, +}; + static const struct drm_encoder_helper_funcs exynos_dp_encoder_helper_funcs = { .mode_set = exynos_dp_mode_set, .enable = exynos_dp_nop, @@ -95,7 +99,12 @@ static int exynos_dp_bind(struct device *dev, struct device *master, void *data) dp->drm_dev = drm_dev; - drm_simple_encoder_init(drm_dev, encoder, DRM_MODE_ENCODER_TMDS); + ret = drm_encoder_init(drm_dev, encoder, &exynos_dp_encoder_funcs, + DRM_MODE_ENCODER_TMDS, NULL); + if (ret) { + drm_err(drm_dev, "Failed to initialize encoder\n"); + return ret; + } drm_encoder_helper_add(encoder, &exynos_dp_encoder_helper_funcs); diff --git a/drivers/gpu/drm/exynos/exynos_drm_dpi.c b/drivers/gpu/drm/exynos/exynos_drm_dpi.c index 0dc36df6ada3..de4a80158746 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_dpi.c +++ b/drivers/gpu/drm/exynos/exynos_drm_dpi.c @@ -12,10 +12,10 @@ #include #include +#include #include #include #include -#include #include