From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 99780C4452D for ; Mon, 20 Jul 2026 15:41:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=UCTzuFV7eFCGxIzO9ORcmzHtSM3Ggk/jrKBR0xDgYaA=; b=xoXkB+TRX7aeTVL6cVLC2YUfPz 0YC7Wl++mLx+GLXe3iGVy0rsDUdyuA/yjobqmAZ6Tv1jM07DmcN794plD2yUiMO/9VlrW+kZ6dVQ2 /+ylW2I0W6KIBJk3ycNJxMtvxW+jY7Z/UZSQbLLkowmP+FwXdqRkOOT3WnCSKWdxwYI7vum+ByNgH TB9xYI6TIx669cbK2V2AeRmm/Obqz0PZQum75b3aFfv2QSM+ihesJjSRFRyHwVOIS/EbTSZRVWpeb lMfgCvXQqZSGetfbSEedHj7sbpw2ALAZwTEahCo3G7TnZ5TDhHFxa3s4q0kSUhRhJqOzmHCI7XQ2g IihxohDg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wlq7Z-00000007Eee-3RNK; Mon, 20 Jul 2026 15:41:33 +0000 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wlq7W-00000007EYQ-0qC7 for linux-mediatek@lists.infradead.org; Mon, 20 Jul 2026 15:41:32 +0000 Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-4954c0833b4so18818175e9.1 for ; Mon, 20 Jul 2026 08:41:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784562088; x=1785166888; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=UCTzuFV7eFCGxIzO9ORcmzHtSM3Ggk/jrKBR0xDgYaA=; b=q6qy8r+IrXNTxMVyiVU1iGY64PhhfAAxiaO0AioYO2c7Cn+VjSViVTZSCx8UWYo4ol OJZMLnnkOFnDdpa9Hno8KuUn9P4UzVYFdqt9+Eni6o11mt88xe3sNMCe7JAXaw/sfshj XoKPc3yS9o5o8iRYY6egbO+FOo5V0UCyKhtcHfbpYu/EVuCHbAIY6fU1I7dhQPgBU2va 37PIm3BQruen60HOGCT0e9OsxTiDQnxCWrSYY5Pas1xhS2DVBCGBihGgNYjH38XI6Gly ooeWmRXgAYOMWmGgtkR/irih6hZsVfBorwi+VXBG18Iodel8lNbFdS5/3ZMK4uyMpPMJ JtFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784562088; x=1785166888; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=UCTzuFV7eFCGxIzO9ORcmzHtSM3Ggk/jrKBR0xDgYaA=; b=b1JPeuKUrEetfslpabXwUtxdPRwlWmhlO/EjQIAV1nUGYlK9pjonJ3QkTYuOVjYf0b jStXh5/qF/9s1pBt8i1d7BJvSdpIWTGrwLv3Z/DkelD8NUG4Gn2d0CPt1NTFG39uKahY TPt8OPHLKN7xpneB2sVgOlETz8da3VRfSNbZvL2k04Bs8W404Is/ty9OsGXFg5CFM+aF LSfXNhTXtdwOKBgkcib/uvQxikJdsgu8RwzP6OLk49A7a/QMRm910iaZUS9Oc0m4Y+S/ N20qRuBVyVMJBVKpT2sdtgMNvZY5WL2x2pYsSLY88/5YdjflBcdIixZOiJChpD/CwRAo e3Hg== X-Forwarded-Encrypted: i=1; AHgh+RqyacC6Hj+V9TZ2m4ONedR247VP5GA9xWzXwDyHw12XPEZvKk0zgKMJiZNw5fHM0C0XUuPV+Cpw9T9SyrcNkQ==@lists.infradead.org X-Gm-Message-State: AOJu0YyQxnqxcIIkDNKVBwFelrlTK2CS2ljudADbjGpp+Gs2PHqXuc5j 8jcYRyxtz8nffPXobJb9ewWEIgBZpPciuEa5qnz+4zhlfup8+QWX1nsT X-Gm-Gg: AfdE7ckbBetrPbFkhkDUP4g0P/bX8Wjz7Q0moAT9PCIJTbg0tL1bAJMHtfHbio9bsND PBEI9B07icNA6ylqSGPgfy1eSAoRK8MbYKa4BSjW2riRFDdfU1HH5wPVfmF+MK8FcpPwrPxfwOZ VPfbzTf2aRLFsXbnAqCtXjPgVprxpHzm8QWWHstcStm4s4fuGVSmwyoCzKMsdZZ90ohM/jzUGU+ XqnYeGt+3XPsKld5b6On5On2q2XRaT2r3NnipucSx32YR98uuYNbE8cLQDup4CX1qaWz/3Od2Cv pt3VsHzv3OWM/ZunQ78x/hW4l9Y/jNLLxaiiXupzJrXFiuxFqn0+aJyxCJBx0QN6SUl7q3+2oPB JtyiQcQhOEyOXcXyq8drJe0b7TtUZ7BOGXnmQfCIRIxPVxx1OZMQPyb1NQJx4y8DQvPuq0C+WbI 6Jw27dH3z3u4/tPDpDuIed X-Received: by 2002:a05:600c:1d1e:b0:493:b6ee:fcb7 with SMTP id 5b1f17b1804b1-4954a3f39ffmr153406895e9.14.1784562088052; Mon, 20 Jul 2026 08:41:28 -0700 (PDT) Received: from [127.0.0.2] ([2a01:14:111:ccf0:e9c1:2f80:10a9:c708]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47f67466e09sm32667936f8f.21.2026.07.20.08.41.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jul 2026 08:41:27 -0700 (PDT) From: Diogo Silva Date: Mon, 20 Jul 2026 17:40:43 +0200 Subject: [PATCH v2 11/15] drm/hisilicon/kirin: remove dependency on DRM simple helpers MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260720-drm_simple_encoder_init-v2-11-5020b630668a@gmail.com> References: <20260720-drm_simple_encoder_init-v2-0-5020b630668a@gmail.com> In-Reply-To: <20260720-drm_simple_encoder_init-v2-0-5020b630668a@gmail.com> To: Jingoo Han , Inki Dae , Seung-Woo Kim , Kyungmin Park , David Airlie , Simona Vetter , Krzysztof Kozlowski , Peter Griffin , Alim Akhtar , Laurent Pinchart , Tomi Valkeinen , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Michal Simek , Thierry Reding , Mikko Perttunen , Jonathan Hunter , Stefan Agner , Alison Wang , Anitha Chrisanthus , David Airlie , Gerd Hoffmann , Dmitry Osipenko , Gurchetan Singh , Chia-I Wu , Jyri Sarha , Liu Ying , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Chun-Kuang Hu , Philipp Zabel , Matthias Brugger , AngeloGioacchino Del Regno , Geert Uytterhoeven , Xinliang Liu , Sumit Semwal , Yongqin Liu , John Stultz , Liviu Dudau , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Jonathan Corbet , Shuah Khan Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, virtualization@lists.linux.dev, imx@lists.linux.dev, linux-mediatek@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-doc@vger.kernel.org, Diogo Silva X-Mailer: b4 0.15.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260720_084130_264705_D83FCC7E X-CRM114-Status: GOOD ( 12.24 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org The simple KMS helpers are deprecated because they only add an intermediate layer between drivers and atomic modesetting. Open-code drm_simple_encoder_init() by calling drm_encoder_init() directly and providing driver-local drm_encoder_funcs. Signed-off-by: Diogo Silva --- drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c b/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c index 15042365dec0..62c5bd3277da 100644 --- a/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c +++ b/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c @@ -20,11 +20,11 @@ #include #include #include +#include #include #include #include #include -#include #include "dw_dsi_reg.h" @@ -687,6 +687,10 @@ static int dsi_encoder_atomic_check(struct drm_encoder *encoder, return 0; } +static const struct drm_encoder_funcs dw_encoder_funcs = { + .destroy = drm_encoder_cleanup, +}; + static const struct drm_encoder_helper_funcs dw_encoder_helper_funcs = { .atomic_check = dsi_encoder_atomic_check, .mode_valid = dsi_encoder_mode_valid, @@ -708,7 +712,8 @@ static int dw_drm_encoder_init(struct device *dev, } encoder->possible_crtcs = crtc_mask; - ret = drm_simple_encoder_init(drm_dev, encoder, DRM_MODE_ENCODER_DSI); + ret = drm_encoder_init(drm_dev, encoder, &dw_encoder_funcs, + DRM_MODE_ENCODER_DSI, NULL); if (ret) { DRM_ERROR("failed to init dsi encoder\n"); return ret; -- 2.54.0