From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 07424C531F9 for ; Fri, 24 Jul 2026 08:45:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=FPhOqCEBzv3eJgxR2FHq6mhzbCgxaYl9KnF0Ou483ms=; b=sOWUaXKSKu5UEYBZFLo+TG1PZI /shW68GTnnt8uX+nHd/IQkYOtu2A5YB9/3BH3RQDzMT6es93gO1+K/AFR4LvYym4H2CKQ6MS02HMU qBrZIqTaPPLLVRbUXtJmSDkc3YmMFfZQ5WuL5t7iRpz6HwzdDVGy9hZzK/6gk8GsyXxekFcuYc/Q8 sqZiHvjUx3DgAb1yuFSwXWbIj/ziWPxj8rZ18uDF4xv9ofELVtr0yNqYTHeZRZcTq9SwK48n0oY6d yleB+j2tfLThXNwXMgLLHKM9YzRLmDXA1nm4zvsr+u8qecuMld11UpvxRxCl9KW0SwN7RVbzL4uSl EHE4JDNQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wnBXM-0000000Frhy-35KZ; Fri, 24 Jul 2026 08:45:44 +0000 Received: from mail-pj1-x1036.google.com ([2607:f8b0:4864:20::1036]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wnBWv-0000000FrKW-2mXf for linux-mediatek@lists.infradead.org; Fri, 24 Jul 2026 08:45:19 +0000 Received: by mail-pj1-x1036.google.com with SMTP id 98e67ed59e1d1-38e58034d05so164131a91.2 for ; Fri, 24 Jul 2026 01:45:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1784882717; x=1785487517; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=FPhOqCEBzv3eJgxR2FHq6mhzbCgxaYl9KnF0Ou483ms=; b=E+t9VxheiExBGWSrk72KBP3VIbyIWwGTMrx/07h9l8zJU+5uYVm9ztWLnCV6gUjrX+ 2oLX5Nxa6cITUBKr0iqa2Tmeh9nXT7SkP2+iNQysd1dmB68n/uydVvUbPuJKXT5VGyGE 3k1xuvy9421fwdGYZ6OJBpAvjAj6VkU1oVMSs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784882717; x=1785487517; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=FPhOqCEBzv3eJgxR2FHq6mhzbCgxaYl9KnF0Ou483ms=; b=LnpuciF5hC5CxQ7C8ULzMIU5gdGV2oS8SOZyjthmRy1zYUjYhGv0gweaI19ReZFpsk BvcR3kQ20n7cWkBVpq00Buqs+fqB1qiTYXr9/pKS83EKzONFvM4qLyu/5sknTF83mp/R CYDoqQF7syfwkZETeL/d2QTDiN/cHXg1KgBNWE87+phM8S5Td0iUv3DZeMnfYIeq/hkF cGuS7o/uAXlFdo4U3sqyDmNOtLxPnfhgck8yLKNv9FEMOiUiK7cBP0TPSOsQIWZP4DNP /8WTcUhnhYdOp7zxyMA3S6NeD+MCHhrvsrHNmTtEO7kaix4TSxoOVS7zZB3tNHzJryiJ EycQ== X-Forwarded-Encrypted: i=1; AHgh+RqUvFQUAK/A+bp+3hr+tOBGcGT+L1CK93WdBPRjPI8SW+l0i2imkbcRrgCjqyRZ0SauQYHuxpucpFPK6uL44A==@lists.infradead.org X-Gm-Message-State: AOJu0YyvinZRtvTp1Z9ToE7Z75q2U+97KPmcm6pAjRWlN3Dc6RxVyKNr oh2ly2i15Lhj8AbR6BI8eMTM6fH/qzdbGg+e6U6CDpmq7KL0gxcAwlUwlAEH/gtypg== X-Gm-Gg: AR+sD10pt9tqSfOGeO+NCBXu5B+H65HpDgSjGqCY6vZPcee71uV4rgd0VVeIIei6cJx F1+yNWMYJHvVLUFIcPVx68qY41EgEdNRHJZrQa1ponX2/rdoD9wtDlVTfUPyA8ejHq97N8h1XhM uhRmR1XYNWzpT8qH2nj/YsREk6I86xEXAl9Ai95+CR3cWSa54ojG0NGosHfSe5hlNxkp/1qlXj1 XRq980yWe4vOLuRyDoMO2L7Suq9M+MWszw+UineMMZ25SUj0dqjG76OrW64PbaU0grJEcHbfDc+ uuz4HesxHQa78Jb6TbbFExHRplLa09D+7+NMHMDrOTpwKIoUvTpzb8p4fnXT4Siu3fIXf5HU1R9 tQLj6OF3GWptZ7zhpdoTb5um1YvCcZu2zHTSyh7jQIvlXicgwSKoZCqwIuUwWe7aaaIkFDaJ9/w Xc1pr5pEWpFlxwqIiQMdXFNLmGnt/kpc+cZXYna0EXcfjlSAbcbs45O8UMprM= X-Received: by 2002:a17:90a:d64c:b0:381:bc4c:da5b with SMTP id 98e67ed59e1d1-38ec6985236mr6392312a91.18.1784882717037; Fri, 24 Jul 2026 01:45:17 -0700 (PDT) Received: from wenstp920.tpe.corp.google.com ([2a00:79e0:201d:8:f131:86cc:5858:7325]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38f089ac6d8sm434546a91.2.2026.07.24.01.45.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jul 2026 01:45:15 -0700 (PDT) From: Chen-Yu Tsai To: Bartosz Golaszewski , Greg Kroah-Hartman , Andy Shevchenko , Daniel Scally , Heikki Krogerus , Sakari Ailus , "Rafael J. Wysocki" , Danilo Krummrich , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno Cc: Wei Deng , Chen-Yu Tsai , linux-acpi@vger.kernel.org, driver-core@lists.linux.dev, linux-pm@vger.kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Manivannan Sadhasivam , Alan Stern Subject: [PATCH v7 14/16] power: sequencing: pcie-m2: Split Bluetooth unit based on interface Date: Fri, 24 Jul 2026 16:43:23 +0800 Message-ID: <20260724084328.3943997-15-wenst@chromium.org> X-Mailer: git-send-email 2.55.0.229.g6434b31f56-goog In-Reply-To: <20260724084328.3943997-1-wenst@chromium.org> References: <20260724084328.3943997-1-wenst@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260724_014517_718708_20A57FEE X-CRM114-Status: GOOD ( 21.73 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Some UART / serdev based Bluetooth drivers need to be able to reset the hardware during initialization or recovery. This is not possible with the current power sequencing API if a unit is shared between USB and UART interfaces. For now, split the Bluetooth unit into two, one for each interface. This allows either interface to independently toggle the power, with the last action prevailing, thereby unbreaking the Qualcomm Bluetooth serdev driver. This is also needed for the Realtek Bluetooth serdev driver (hci_h5). Having independent control from either interface unfortunately means that userspace is able to shut down the controller from sysfs using the USB port's "disable" setting without the serdev driver knowing about it. On the USB side, independent control is also desired, as it allows the USB core to power cycle the port/device during faults, and for userspace to initiate reset and recovery using the aforementioned "disable" setting. However when USB is used, a serdev device is not created, and there is no conflicting usage, which allows the power sequencing to work even without the split unit. Suggested-by: Wei Deng Signed-off-by: Chen-Yu Tsai --- Changes since v4: - New patch This patch is _not_ squashed into the previous to provide clear context on the change, and the less than perfect nature of it. I think what we need in this case is some sort of lockout. The serdev consumer would want "exclusive" access, locking out the USB consumer, which can tolerate "shared" access. Something similar would be needed for the WiFi if we ever add support for SDIO for toggling the state of W_DISABLE#1. At least the SDIO and PCIe reset signals are separate. --- drivers/power/sequencing/pwrseq-pcie-m2.c | 22 ++++++++++++++++++---- 1 file changed, 18 insertions(+), 4 deletions(-) diff --git a/drivers/power/sequencing/pwrseq-pcie-m2.c b/drivers/power/sequencing/pwrseq-pcie-m2.c index 693b0d33f8cf..56e4f40e0480 100644 --- a/drivers/power/sequencing/pwrseq-pcie-m2.c +++ b/drivers/power/sequencing/pwrseq-pcie-m2.c @@ -83,8 +83,22 @@ static int pwrseq_pci_m2_e_bt_disable(struct pwrseq_device *pwrseq) return gpiod_set_value_cansleep(ctx->w_disable2_gpio, 1); } -static const struct pwrseq_unit_data pwrseq_pcie_m2_e_bt_unit_data = { - .name = "bt-enable", +/* + * XXX There are two Bluetooth units to allow either one to be able to power + * off and thus reset the controller. In practice only one of the interfaces + * is used, so there is no conflict. However userspace could power off the + * USB unit by disabling the associated USB port, without the UART unit or + * its consumer ever knowing. + */ +static const struct pwrseq_unit_data pwrseq_pcie_m2_e_bt_uart_unit_data = { + .name = "bt-uart-enable", + .deps = pwrseq_pcie_m2_unit_deps, + .enable = pwrseq_pci_m2_e_bt_enable, + .disable = pwrseq_pci_m2_e_bt_disable, +}; + +static const struct pwrseq_unit_data pwrseq_pcie_m2_e_bt_usb_unit_data = { + .name = "bt-usb-enable", .deps = pwrseq_pcie_m2_unit_deps, .enable = pwrseq_pci_m2_e_bt_enable, .disable = pwrseq_pci_m2_e_bt_disable, @@ -130,13 +144,13 @@ static int pwrseq_pcie_m2_e_pwup_delay(struct pwrseq_device *pwrseq) static const struct pwrseq_target_data pwrseq_pcie_m2_e_uart_target_data = { .name = "uart", - .unit = &pwrseq_pcie_m2_e_bt_unit_data, + .unit = &pwrseq_pcie_m2_e_bt_uart_unit_data, .post_enable = pwrseq_pcie_m2_e_pwup_delay, }; static const struct pwrseq_target_data pwrseq_pcie_m2_e_usb_target_data = { .name = "usb", - .unit = &pwrseq_pcie_m2_e_bt_unit_data, + .unit = &pwrseq_pcie_m2_e_bt_usb_unit_data, }; static const struct pwrseq_target_data pwrseq_pcie_m2_e_pcie_target_data = { -- 2.55.0.229.g6434b31f56-goog