From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9971BC531FA for ; Fri, 24 Jul 2026 08:44:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=H3ipik7auGStkEDr/T9A/4r5EQKWd/pec5jMaPqfTe4=; b=JMJPepE7Q49l2z3cGy7Q0YC9EJ en2lE2L6f4qNwQtKD00h8TN+zDM0FlYYoyfVnOtIPB1/XEUqVw0A17FiFPlwBD5UPspl2ZCSgO1+2 yUiN1PY09XB5QQ1SovwpFtPuHtYS+QKpnMNWTYWPWZmPJl0cIsIccA6Y9N2aevOrF0mR7v6+2IvmL 14CEQDBm8zSrelP7NmkGAn4DJF9geLRDNBecJojfxEcinvm1nz+aIagA7A+5KOKF2Hu/IVQMvbig7 +lklW+iQXPG9BDtiPDw4V9eyVxK8PUD6J21/Xxb2IQO3me2T45q748ZCbPXNtbTkFZjAaa5dx6UP6 YYdQ3+sw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wnBWB-0000000Fqh0-2yzi; Fri, 24 Jul 2026 08:44:31 +0000 Received: from mail-pj1-x102c.google.com ([2607:f8b0:4864:20::102c]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wnBW4-0000000Fqah-2MKs for linux-mediatek@lists.infradead.org; Fri, 24 Jul 2026 08:44:25 +0000 Received: by mail-pj1-x102c.google.com with SMTP id 98e67ed59e1d1-38e071ed6aeso139474a91.0 for ; Fri, 24 Jul 2026 01:44:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1784882664; x=1785487464; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=H3ipik7auGStkEDr/T9A/4r5EQKWd/pec5jMaPqfTe4=; b=oHxwIoiw2RwPctcWZ030MWa2cTB1arlIjWjcBxaGXhcc11x30MDKQo9hmC2YzisX8t rt3QZ5Cn40hxZmE1c+dNPakHZ36yRkfQJqVGy6AjNL7DzNhxgNBUCrJNGdzgbQi/Qfem JJgp0CF1k5lO6Yckq+/+9aq8Ltn187uA5fIu4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784882664; x=1785487464; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=H3ipik7auGStkEDr/T9A/4r5EQKWd/pec5jMaPqfTe4=; b=GM25DhyNJbJCONiByb95G8uEuoq+p7JLOL7eiMA2HoSxsnU+QY95E2jv2qn+dfpfao 8ZnyfWpuXJtbfPX5kkz2NBi1aj1CKIfhPJFZygJpHzVTu+hMTg3bFLZeUHWjcHfUHFwv DcG6PWIvgUL4u04ovxCR+xUKZX4N6pyZtfUIvSvB+BPzSEkmiuwlA2Gijpg/+OUdrw5D hTL6brpg8bKmlpw3w/5bpHWaJk7BZoUbEye5n+pn3Jh5sai9AN4gW4ggbiDjJg5JcNna QvUI7qUqR7Xz/DyAnwkvZLV5im08rfPJso0myrx90R0epOolLDPW+KLDcHbUIKQwnizh IrHw== X-Forwarded-Encrypted: i=1; AHgh+RpCNlKycFvPmtCkdO31UXcV01sjb0d3dL4BcvVdIFVz+MCTUQb6GuKuPPkjCm3MWZRuHCQ8qJUuNYlfzk+cVQ==@lists.infradead.org X-Gm-Message-State: AOJu0YxUOJAwz+Yg0j5C1m6tzlFSA8/4KA9z9Cwyo5DmuMFDRTuQ1BUS lXYqtvoJ5Rj4jq3zSF+i3h7+j62vj6y2lwtaGKL3ouF9DhSlDxiw87p2i/dWVu9dP1z0zWkwrD5 HP5Y= X-Gm-Gg: AR+sD13lv/At6B6/trIBGWUpVi8P0RTbBN0E8ZkXU/xrWvHuiubLzAqoj57/IVf9Gvj cK512aBAeG+eu7RjGn1N2vTm8/MyMNvK1IcjNIxqRovp54kFvKjPGvV+Z5k4mJ8BkOfmma2XKnK vpXBMRbWVk/mE0vA6jK7LtXXy+/N9ufm8smmiQLFDWZV4YAv7Ehd+6cevzRnF+sD2UrPr4DLsRu 6/hSsqTfE+SKSA9zWSnE/7AuDPbnCEOkm3ILDAy8JqT4UOLa6Nfq6DQeWv+yVV+brb3xfXMLoHG /c+BGRD9khJ2i1tKbvL4Pa0nHLGau0bLE45KT7aiFzHn+WxsQTXoQHdU6YRRuoxTx97t2v8IouE ro42SCpydi8tjUyWfaOEtxqHXGBxmjhGjydatYFhDQ0EIL1/QI8Ob2x3eT95d0SIwFYBuFTZrK5 VNChULfVXIohspf5OR91YCgzLKTCIkIxo2oC5d+dSrE9YWXnkoq4k9Ly9TNzs7BEjLgimUTA== X-Received: by 2002:a17:90b:314a:b0:381:23d5:693f with SMTP id 98e67ed59e1d1-38ec65f9916mr6632501a91.28.1784882663919; Fri, 24 Jul 2026 01:44:23 -0700 (PDT) Received: from wenstp920.tpe.corp.google.com ([2a00:79e0:201d:8:f131:86cc:5858:7325]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38f089ac6d8sm434546a91.2.2026.07.24.01.44.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jul 2026 01:44:23 -0700 (PDT) From: Chen-Yu Tsai To: Bartosz Golaszewski , Greg Kroah-Hartman , Andy Shevchenko , Daniel Scally , Heikki Krogerus , Sakari Ailus , "Rafael J. Wysocki" , Danilo Krummrich , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno Cc: Wei Deng , Chen-Yu Tsai , linux-acpi@vger.kernel.org, driver-core@lists.linux.dev, linux-pm@vger.kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Manivannan Sadhasivam , Alan Stern , Bartosz Golaszewski Subject: [PATCH v7 04/16] usb: hub: Use assign_bit() in usb_hub_set_port_power() Date: Fri, 24 Jul 2026 16:43:13 +0800 Message-ID: <20260724084328.3943997-5-wenst@chromium.org> X-Mailer: git-send-email 2.55.0.229.g6434b31f56-goog In-Reply-To: <20260724084328.3943997-1-wenst@chromium.org> References: <20260724084328.3943997-1-wenst@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260724_014424_613841_2FD05C08 X-CRM114-Status: GOOD ( 11.62 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org usb_hub_set_port_power() open-codes assign_bit(). Just use the assign_bit() macro instead. This makes subsequent additions to usb_hub_set_port_power() easier to read. This change does not introduce any functional changes. Suggested-by: Andy Shevchenko Reviewed-by: Andy Shevchenko Reviewed-by: Bartosz Golaszewski Signed-off-by: Chen-Yu Tsai --- Attributing suggestion to Andy, since the change was originally requested as part of a review. Changes since v4: - New patch (split out from "usb: hub: Power on connected M.2 E-key connectors with power sequencing API") (Andy) --- drivers/usb/core/hub.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c index 2cfe09a141d8..715f26f05a31 100644 --- a/drivers/usb/core/hub.c +++ b/drivers/usb/core/hub.c @@ -10,6 +10,7 @@ * Released under the GPLv2 only. */ +#include #include #include #include @@ -899,10 +900,7 @@ int usb_hub_set_port_power(struct usb_device *hdev, struct usb_hub *hub, if (ret) return ret; - if (set) - set_bit(port1, hub->power_bits); - else - clear_bit(port1, hub->power_bits); + assign_bit(port1, hub->power_bits, set); return 0; } -- 2.55.0.229.g6434b31f56-goog