From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8D69BC55184 for ; Mon, 3 Aug 2026 14:19:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=SZCNDtviR1JC6xXXbBCpthup0l4v5bhXrxKWkP3TttE=; b=cuNB3LdM8lb78MytpDE3jZ2ovq t/oFiqeoQ1vqjYGQ+1eGTNyfUyJKelcpWYd/AGJhXtxoQT3VOwCk/MuZLmjFU/QY7Rkq7nyKYNMo+ hvwFW8+9dgxGfVZpRtexh88KQsJogx9w0yQYmqeMWd+1lk6A1zDS8VVYaWd6Q+62aGBDO+or2cip4 wQ569bB5G9ZU7ugjK4148xsBzbXSrye1eeKoP6XgH2sz+p7ERT2X5t5sAAXJqoAm3mCZdjnJnB8v7 Z9C94JzI+cZkPGowEWxWtsXg2un5iEZYxekKjBkmFtMdN7oQ6FdlvvVMs3d0Cdd3hbtf9SVA2viGZ JJrJ5Y8g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wqtVa-0000000HLuS-3Tz3; Mon, 03 Aug 2026 14:19:14 +0000 Received: from mail-pj1-x1031.google.com ([2607:f8b0:4864:20::1031]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wqtVY-0000000HLpA-225m for linux-mediatek@lists.infradead.org; Mon, 03 Aug 2026 14:19:13 +0000 Received: by mail-pj1-x1031.google.com with SMTP id 98e67ed59e1d1-382ef647e20so3627221a91.1 for ; Mon, 03 Aug 2026 07:19:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785766752; x=1786371552; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=SZCNDtviR1JC6xXXbBCpthup0l4v5bhXrxKWkP3TttE=; b=CehvcxcflRtPie+jYkrSaDvn0rv4p8gvt6OhXcyquOI3/9JxDlt/c4gaFCL7pIQP7+ rQGCZHasBLPA+Fi7cTtzLNPSowOb4cFQz45lWbGxX8bgkqLQhFHYTC391Gpto2wy6PLc RbpukC9jtHH+tmAgA88j65fIbTyDFOaGHVYf0S2p7ztAHbr+QiGZwADmYXkMIPU9VEBO hzuuvkhBgyQ8ORPFAxwO+5kz5vNIMoe5rq6ZHurTv7ZU91xE7feEv3a3vGvib7JHdAXA JT8CZdfP8WmpDqAGS9/Qa8h8M5BOfcKpMbT0efj9TNW1yoKZg2c12rnU8YyjRTucdZoY CYkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785766752; x=1786371552; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=SZCNDtviR1JC6xXXbBCpthup0l4v5bhXrxKWkP3TttE=; b=VBK8/bTQvhGas9+be0esNIVTCEq/zar05B9RVXYoXOuJC5ZD1CoFvPJkIehC6LCpqc l4DA953yuHgyXckqf1Uxyfy0V4seNabzjRCsL+n6W3pHucLF2AGEVF1o/O+speEcF77G HvMfyyQ/2ZQBJ27jkarbdUcaI4hmbp3pRh+uju/b/EsfOkE6OrHX1Fd73Z587otYWNRP Ri8oEmt5z0riMl705YU2h4JX6UrG7ywTBKFI28koDJJAstixgo2xvuzlMQRbI5lvusAN IOdcD0Bgq6egaqW0nBzNFtFPzqEsowpxgQYy1CRXUYTaQ1qQrE/zKZ82FTyUDyEEiWxJ s3PQ== X-Forwarded-Encrypted: i=1; AHgh+RpWCO6vgcK36wHLcsKdZkTU5Cn6RJFuACrEYbqZZh7iI4y5K14ZUtsL+rkwB9wsMT2pQgcQ95eTL72gtNtGCQ==@lists.infradead.org X-Gm-Message-State: AOJu0YzTCcrGybB3JTl5vJz5HADGVnvGZQOnd0s/PELSfhE1xRpqvZp0 xu/cGSSJX1UKoB3pdXJAopcgnZTg22KsmsPxiux7/X8UMqmgyceMLeyt X-Gm-Gg: AR+sD116Tv2bwJtO/9zIRi2zdQLZiYqMU4/sPULITWoOjeFuBDts0HMchQB0nceMMuC HwBiBE3hJ8lv55VRXOJ+ptxzL+Ky1SMeN5+OZey10IYlbvep1R5VBdyESMm0YVEM5XK2oYY5NDJ OH0Hfmcr52UgB7/0ANgJV0sa3s6ewMKIN0zc3mwk7jwbzk84NKSWm8tU0rR0K0dQ+134Fca/6AL onUV5aXaN3cGCTVA+UtihuiPop/dX7HuzQUnCsAvpgOUy6ckPGtbyRnzfRWyJzICKVLhmlMw2cT Qj0uoh9mbzaf7F0simNgWeqjQWhVLdLiVlZ2hHOFK3MaVnDAL5SL9jaM8yaHhOMPBG5PtQ+ClUb Fwpi/nPBF0SNwPWfoYOZEIepIa/i6HO3n9Tvf7wqKVdBv1dV423M2EUgRaoGDtn/M9+NakYI/Fh 3LTsNeA73rUrxlueTlWGp3F4E/4xQ7cLsLnd51gfDT8QxmVQ9kuiDJstmU1OEuu9lyCZzX5YotI XH5zffprT5rv/tsH1Jh X-Received: by 2002:a17:90b:2251:b0:384:5dbc:cba5 with SMTP id 98e67ed59e1d1-38fbc4cdedamr9399280a91.26.1785766751774; Mon, 03 Aug 2026 07:19:11 -0700 (PDT) Received: from buffalo-ssd (M014013071096.v4.enabler.ne.jp. [14.13.71.96]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38fb30dff2esm4078462a91.13.2026.08.03.07.19.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Aug 2026 07:19:11 -0700 (PDT) From: Akari Tsuyukusa To: Michael Turquette , Stephen Boyd , Brian Masney , Matthias Brugger , AngeloGioacchino Del Regno , Yassine Oudjana , Richard Cochran Cc: Laura Nao , =?UTF-8?q?N=C3=ADcolas=20F=2E=20R=2E=20A=2E=20Prado?= , Chen-Yu Tsai , Akari Tsuyukusa , Bartosz Golaszewski , Danilo Krummrich , Bjorn Helgaas , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig=20=28The=20Capable=20Hub=29?= , Nicolas Frattaroli , Takashi Sakamoto , Haotian Zhang , Kees Cook , Miles Chen , Daniel Golle , Sam Shih , linux-clk@vger.kernel.org (open list:COMMON CLK FRAMEWORK), linux-kernel@vger.kernel.org (open list), linux-arm-kernel@lists.infradead.org (moderated list:ARM/Mediatek SoC support), linux-mediatek@lists.infradead.org (moderated list:ARM/Mediatek SoC support), netdev@vger.kernel.org (open list:PTP HARDWARE CLOCK SUPPORT:Keyword:(?:\b|_)ptp(?:\b|_)), stable@vger.kernel.org Subject: [PATCH 23/32] clk: mediatek: mt8135-apmixedsys: Switch to common probe/remove helpers Date: Mon, 3 Aug 2026 23:16:50 +0900 Message-ID: <20260803141659.559129-24-akkun11.open@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260803141659.559129-1-akkun11.open@gmail.com> References: <20260803141659.559129-1-akkun11.open@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260803_071912_558796_7904D1F2 X-CRM114-Status: GOOD ( 13.77 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org The MT8135 apmixedsys driver can use the MediaTek clock framework common initialization sequence. Reduce boilerplate code by creating struct mtk_clk_desc and using the mtk_clk_simple_probe/remove helpers. Signed-off-by: Akari Tsuyukusa --- drivers/clk/mediatek/clk-mt8135-apmixedsys.c | 50 +++----------------- 1 file changed, 7 insertions(+), 43 deletions(-) diff --git a/drivers/clk/mediatek/clk-mt8135-apmixedsys.c b/drivers/clk/mediatek/clk-mt8135-apmixedsys.c index e3b7dc13b458..fe868417de48 100644 --- a/drivers/clk/mediatek/clk-mt8135-apmixedsys.c +++ b/drivers/clk/mediatek/clk-mt8135-apmixedsys.c @@ -47,56 +47,20 @@ static const struct mtk_pll_data plls[] = { PLL(CLK_APMIXED_VDECPLL, "vdecpll", 0x304, 0x31c, 0x80000000, 0, 21, 0x2b0, 6, 0x0, 0x308, 0), }; -static int clk_mt8135_apmixed_probe(struct platform_device *pdev) -{ - struct clk_hw_onecell_data *clk_data; - struct device_node *node = pdev->dev.of_node; - int ret; - - clk_data = mtk_alloc_clk_data(CLK_APMIXED_NR_CLK); - if (!clk_data) - return -ENOMEM; - - ret = mtk_clk_register_plls(&pdev->dev, plls, ARRAY_SIZE(plls), - clk_data); - if (ret) - goto free_clk_data; - - ret = of_clk_add_hw_provider(node, of_clk_hw_onecell_get, clk_data); - if (ret) - goto unregister_plls; - - platform_set_drvdata(pdev, clk_data); - - return 0; - -unregister_plls: - mtk_clk_unregister_plls(plls, ARRAY_SIZE(plls), clk_data); -free_clk_data: - mtk_free_clk_data(clk_data); - - return ret; -} - -static void clk_mt8135_apmixed_remove(struct platform_device *pdev) -{ - struct device_node *node = pdev->dev.of_node; - struct clk_hw_onecell_data *clk_data = platform_get_drvdata(pdev); - - of_clk_del_provider(node); - mtk_clk_unregister_plls(plls, ARRAY_SIZE(plls), clk_data); - mtk_free_clk_data(clk_data); -} +static const struct mtk_clk_desc apmixed_desc = { + .plls = plls, + .num_plls = ARRAY_SIZE(plls), +}; static const struct of_device_id of_match_clk_mt8135_apmixed[] = { - { .compatible = "mediatek,mt8135-apmixedsys" }, + { .compatible = "mediatek,mt8135-apmixedsys", .data = &apmixed_desc }, { /* sentinel */ } }; MODULE_DEVICE_TABLE(of, of_match_clk_mt8135_apmixed); static struct platform_driver clk_mt8135_apmixed_drv = { - .probe = clk_mt8135_apmixed_probe, - .remove = clk_mt8135_apmixed_remove, + .probe = mtk_clk_simple_probe, + .remove = mtk_clk_simple_remove, .driver = { .name = "clk-mt8135-apmixed", .of_match_table = of_match_clk_mt8135_apmixed, -- 2.55.0