From: Eason Lai <eason.lai@mediatek.com>
To: <nbd@nbd.name>, <lorenzo@kernel.org>
Cc: <linux-wireless@vger.kernel.org>,
<linux-mediatek@lists.infradead.org>, <kun.wu@mediatek.com>,
<deren.wu@mediatek.com>, <sean.wang@mediatek.com>,
<quan.zhou@mediatek.com>, <ryder.lee@mediatek.com>,
<leon.yen@mediatek.com>, <litien.chang@mediatek.com>,
<jb.tsai@mediatek.com>, <ck.chang@mediatek.com>,
<eason.lai@mediatek.com>
Subject: [PATCH v1 2/2] wifi: mt76: mt7925: Add coredump end collect mechanism
Date: Wed, 5 Aug 2026 17:25:31 +0800 [thread overview]
Message-ID: <20260805092531.1490746-3-eason.lai@mediatek.com> (raw)
In-Reply-To: <20260805092531.1490746-1-eason.lai@mediatek.com>
From: "ck.chang" <ck.chang@mediatek.com>
Add collect mechanism, when parse to specific coredump string, immediately save the collected coredump content into coredump file
Signed-off-by: ck.chang <ck.chang@mediatek.com>
---
drivers/net/wireless/mediatek/mt76/mt76_connac.h | 1 +
drivers/net/wireless/mediatek/mt76/mt7925/mac.c | 8 +++++++-
drivers/net/wireless/mediatek/mt76/mt7925/mcu.c | 10 +++++++++-
3 files changed, 17 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/mediatek/mt76/mt76_connac.h b/drivers/net/wireless/mediatek/mt76/mt76_connac.h
index b1677ca24703..6374add14160 100644
--- a/drivers/net/wireless/mediatek/mt76/mt76_connac.h
+++ b/drivers/net/wireless/mediatek/mt76/mt76_connac.h
@@ -128,6 +128,7 @@ struct mt76_connac_coredump {
struct sk_buff_head msg_list;
struct delayed_work work;
unsigned long last_activity;
+ bool complete;
};
struct mt76_connac_sta_key_conf {
diff --git a/drivers/net/wireless/mediatek/mt76/mt7925/mac.c b/drivers/net/wireless/mediatek/mt76/mt7925/mac.c
index b5dd1b58618c..77b6fa34a1ba 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7925/mac.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7925/mac.c
@@ -1580,12 +1580,18 @@ void mt7925_coredump_work(struct work_struct *work)
dev = (struct mt792x_dev *)container_of(work, struct mt792x_dev, coredump.work.work);
- if (time_is_after_jiffies(dev->coredump.last_activity +
+ /* if received the last coredump payload or timeout, start
+ * saving coredump file and trigger reset.
+ * Otherwise, wait for other coredump payload coming
+ */
+ if (!dev->coredump.complete &&
+ time_is_after_jiffies(dev->coredump.last_activity +
4 * MT76_CONNAC_COREDUMP_TIMEOUT)) {
queue_delayed_work(dev->mt76.wq, &dev->coredump.work,
MT76_CONNAC_COREDUMP_TIMEOUT);
return;
}
+ dev->coredump.complete = false;
skb_queue_head_init(&local_list);
spin_lock_bh(&dev->mt76.lock);
diff --git a/drivers/net/wireless/mediatek/mt76/mt7925/mcu.c b/drivers/net/wireless/mediatek/mt76/mt7925/mcu.c
index fa29c486a455..c4194c800dc6 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7925/mcu.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7925/mcu.c
@@ -671,6 +671,7 @@ static void
mt7925_mcu_uni_rx_unsolicited_event(struct mt792x_dev *dev,
struct sk_buff *skb)
{
+#define COREDUMP_END_STR "; coredump end"
struct mt7925_mcu_rxd *rxd;
rxd = (struct mt7925_mcu_rxd *)skb->data;
@@ -700,10 +701,17 @@ mt7925_mcu_uni_rx_unsolicited_event(struct mt792x_dev *dev,
case MCU_UNI_EVENT_RSSI_MONITOR:
mt7925_mcu_rssi_monitor_event(dev, skb);
break;
- case MCU_UNI_EVENT_COREDUMP:
+ case MCU_UNI_EVENT_COREDUMP: {
+ size_t hdr_len = sizeof(struct mt7925_mcu_rxd) + 8;
+
dev->fw_assert = true;
+ if (skb->len > hdr_len &&
+ strnstr(skb->data + hdr_len, COREDUMP_END_STR,
+ skb->len - hdr_len))
+ dev->coredump.complete = true;
mt76_connac_mcu_coredump_event(&dev->mt76, skb, &dev->coredump);
return;
+ }
case MCU_UNI_EVENT_NAN:
mt7925_nan_mcu_event(dev, skb);
break;
--
2.45.2
prev parent reply other threads:[~2026-08-05 9:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-05 9:25 [PATCH v1 0/2] wifi: mt76: mt7925: Fix coredump issue and add coredump end collect mechanism Eason Lai
2026-08-05 9:25 ` [PATCH v1 1/2] wifi: mt76: mt7925: Fix coredump size not enough issue Eason Lai
2026-08-05 9:25 ` Eason Lai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260805092531.1490746-3-eason.lai@mediatek.com \
--to=eason.lai@mediatek.com \
--cc=ck.chang@mediatek.com \
--cc=deren.wu@mediatek.com \
--cc=jb.tsai@mediatek.com \
--cc=kun.wu@mediatek.com \
--cc=leon.yen@mediatek.com \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=litien.chang@mediatek.com \
--cc=lorenzo@kernel.org \
--cc=nbd@nbd.name \
--cc=quan.zhou@mediatek.com \
--cc=ryder.lee@mediatek.com \
--cc=sean.wang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox