From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 10F1CC5DF7D for ; Fri, 21 Aug 2026 12:29:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=axXA4DN3AZ7lZ4uoWKWlKISmN+79vPMNk4IXFpeL8kY=; b=2hJRT5FCru+WCFuAFFdB23QL/t /vRFdBQlILdz5bJyIK9j7a+/wYRaBbayvj+/NsNych5Ib4kDcss3n0t+mpPytldhAXCLIxgpm7kw3 9DZ5YS5nUiuTwUgTFrxYaUsj+J3SmVcH5uSlG+6NS5lsb4zz28kXrjq6hOFF/Bg0HSVAhWXSyDN1F JsakC1YYqG+OK4GdPuJrruMNn+Y3bUCbrR+9hKy1ekA/vUIaHvLZp7eVPei8O5iHVK3Nu+NRIK7fw BvzCv1Uj4wJ9DO2sUuau1mNcvBqCfGFAxg4/wllyImYg/NkhMrRLeUrtFp4ImDxiq7YrJxCOJc9RT fm9RLm1g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wxONc-0000000DJOG-0pmO; Fri, 21 Aug 2026 12:29:52 +0000 Received: from mail-pf1-x42b.google.com ([2607:f8b0:4864:20::42b]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wxONY-0000000DJLT-3E3D for linux-mediatek@lists.infradead.org; Fri, 21 Aug 2026 12:29:51 +0000 Received: by mail-pf1-x42b.google.com with SMTP id d2e1a72fcca58-8487214ad2bso1174178b3a.1 for ; Fri, 21 Aug 2026 05:29:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787315388; x=1787920188; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=axXA4DN3AZ7lZ4uoWKWlKISmN+79vPMNk4IXFpeL8kY=; b=HDRf9PFrcGFrFTYiWdXtb0zf520qcXq5u86/pc2DjjaQe9ZRaLzlpJwbx5zgshQ5Np zUt86RqBAjkXXIOfOJobPcdsyzSi8ecF3Fyx5bND+H31yzxGtteNVUVGDrHiv9IheyXz fNNsdIu29RdVxuIsBf8F2/0YWWlSoYifHh0KBpA8z2JB8Ve4cjrdBZr6T+VgeuBsXoux 6TS0+E3X8QsVoIZshEV5eHbAcIa2ptU28XADtKKudBzts2deei8NkV03ySXzWGv4DTSh MY9120uyg5SgZ0/zb+MHoy1ePEOKwKAJfmPs176EwHQ2dLW4YE5fmRzwz7SowGEBFczC Zmqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787315388; x=1787920188; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=axXA4DN3AZ7lZ4uoWKWlKISmN+79vPMNk4IXFpeL8kY=; b=IpQxsBKleKzy7s/BC5Hm6rDYtumF2eVp5VR54/GPR+W6bh4jlWfgEAuIEliCtEYrTJ LapD3toMbX1ftjHcN5cFi2q/8omQOapWgOWD6QbHFAuWdXMzNEKm4loQKX21u32W6/KU LlpxIDd2xwYJ+rsRCwy/90nFp/qBACs0I89dwmjW5MZ1/BTiDQ+7abAjieqeNL/7m7W3 xQVd6Mw/+KpeGw/JYUSeaCdiQ3XD/mz0oqIizJjbJK6+0K3E4DjmD2iZ5LUXyN0eY5+b nKLHmw9od1toAOyZqA5GGp6djUnNpCeSWoiqd8o1E+85lHl+pcYpmr/p6umM/qc/JDTG pU7g== X-Forwarded-Encrypted: i=1; AHgh+RpAcS1q8oVa24jIbGBFmO8UK9rbRutbcbMLrBd3RPXfxuDYH9ryKSDTddbfmH/DTSK7ycnYkOGDFa6/Ynp8bw==@lists.infradead.org X-Gm-Message-State: AFuF++nSr8UdD4DMVZhfKHpro4j9j2oaY1KJ2sTmT7Yh20hWSe0Q7aF9 d5LkaquqB0P+uAB3ANLPCfew49iKO36+eJjbZC5bqKXzEXePwpMGXVPf X-Gm-Gg: AR+sD10FkLXoxpAO5zIO9uxBs+9X+W9seodS9UGuqzKihCDZOcNj1tccK6BSuqj6fYx /DRWZD5XLEprOc44IW3wAQ8VkYAoiwFlk69W6Xe5M7cqIJX/w0Wu/Rxo2VDF+nSRpZheWWnZjo9 iFhhKnEGnMiryyGGABQ57ceKf0tvJ7E6ZAhmq3NaO9VcivBVqppq8ffz6/ZvHvNp2vzockswYHY JBs468JSmPu6ifywZWojD3WMhTVJveA0OFdPvpGkJqvrzB8R9E0ZI0dWpj47/1E0IVTobN5vd6O 6diihT6X1kaD6/QphOcyg1dOj67WASeAd8rcXBG+Ywa6dC9KTKykog9uG36aJkSCY/DVgnZZopX VUI8+IgVeGF4tf/eT1+aZSMpinAVorb85WdD3DXLHdSBVxvo5Y6ZvS9lrKQfrS3cqNzxbS5R3Tw EklK/KqVTOWdjOe8caY1apAfYZso6hTL7M2FlM9aCWV8yRPgYAjPhLhRKrSM3+f4vy4zjvf7oZf QifOR5uGgvI05JSap/VXC6nlW5k5o67ziAXjqh65KGuw0xW0izr8mF4K74hyX8S4DJ/FaxEQ/GG AgPG X-Received: by 2002:a05:6a00:a589:b0:851:c2a6:172f with SMTP id d2e1a72fcca58-851f9efcc14mr9394852b3a.7.1787315387771; Fri, 21 Aug 2026 05:29:47 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-851d3389fc4sm2848582b3a.14.2026.08.21.05.29.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Aug 2026 05:29:47 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , Matthias Brugger Cc: Liam Girdwood , AngeloGioacchino Del Regno , Jaroslav Kysela , Takashi Iwai , Cezary Rojewski , linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH v2 1/4] ASoC: mediatek: mt8183: Fix wrong clock cleanup on clk_set_parent() failure Date: Fri, 21 Aug 2026 19:29:25 +0700 Message-ID: <20260821122928.41343-2-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260821122928.41343-1-phucduc.bui@gmail.com> References: <20260821122928.41343-1-phucduc.bui@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260821_052948_813557_639A59FB X-CRM114-Status: GOOD ( 11.54 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org From: bui duc phuc In mt8183_afe_enable_clock(), when clk_set_parent() fails, the current error path incorrectly cleans up the previously enabled clock instead of the clock used by clk_set_parent(). Fix the error path to clean up the correct clock when clk_set_parent() fails. Fixes: a94aec035a12 ("ASoC: mediatek: mt8183: add platform driver") Signed-off-by: bui duc phuc --- sound/soc/mediatek/mt8183/mt8183-afe-clk.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/mediatek/mt8183/mt8183-afe-clk.c b/sound/soc/mediatek/mt8183/mt8183-afe-clk.c index cc4f8f4d3dab..6ab0734ad136 100644 --- a/sound/soc/mediatek/mt8183/mt8183-afe-clk.c +++ b/sound/soc/mediatek/mt8183/mt8183-afe-clk.c @@ -137,7 +137,7 @@ int mt8183_afe_enable_clock(struct mtk_base_afe *afe) dev_err(afe->dev, "%s(), clk_set_parent %s-%s fail %d\n", __func__, aud_clks[CLK_MUX_AUDIO], aud_clks[CLK_CLK26M], ret); - goto CLK_MUX_AUDIO_ERR; + goto CLK_MUX_AUDIO_INTBUS_ERR; } ret = clk_prepare_enable(afe_priv->clk[CLK_MUX_AUDIOINTBUS]); @@ -153,7 +153,7 @@ int mt8183_afe_enable_clock(struct mtk_base_afe *afe) dev_err(afe->dev, "%s(), clk_set_parent %s-%s fail %d\n", __func__, aud_clks[CLK_MUX_AUDIOINTBUS], aud_clks[CLK_TOP_SYSPLL_D2_D4], ret); - goto CLK_MUX_AUDIO_INTBUS_ERR; + goto CLK_AFE_ERR; } ret = clk_prepare_enable(afe_priv->clk[CLK_AFE]); -- 2.43.0