From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C61F4C61DBE for ; Tue, 25 Aug 2026 11:26:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=n+tRyTnlpLmJp3+Wgs2dMuwtgQimEwJVqYrZ9xUm0L0=; b=TrvySE6Cfq6/SV/tfbX6/t0Khw yetqzST5JX6caKnNl1JGtfWywS637lbGCbN8Rm+H9WOnvzHbXVVmxMyesLRsnswmtoaQgicLctHTD LF4nphjV8Z8O4/7LqnNhvvT1RYlE6y1aEqgvkGi/tBvLCSdfr6L1k7yd0U9Fy8teVojKY+m6BG6x2 r7SJV/dbvxmUe1d+eKeJ2iSC/UO7Wtg8vQj066FXNxOsSAh9+h/GoDaPOUMKdoo03LY2P9ev99G7D srDGThzRwv6IGwtSA5Y+JjfhvshYSIQbGlgs8gbWm5rfQMKw4dPik3Rpix6puZ5k9QK4YhhGQ5sKp lOpgoh2w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wypIZ-00000000giB-0THZ; Tue, 25 Aug 2026 11:26:35 +0000 Received: from mail-pg1-x532.google.com ([2607:f8b0:4864:20::532]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wypIW-00000000gh8-2x7x for linux-mediatek@lists.infradead.org; Tue, 25 Aug 2026 11:26:33 +0000 Received: by mail-pg1-x532.google.com with SMTP id 41be03b00d2f7-cc149372c14so3382479a12.1 for ; Tue, 25 Aug 2026 04:26:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787657191; x=1788261991; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=n+tRyTnlpLmJp3+Wgs2dMuwtgQimEwJVqYrZ9xUm0L0=; b=dknCLuFYoto48GCxwiCAVeaNHO6sAVJTI+MWy7Q7qzk3WEd7jCOLWZprwqCfkIdfZE 4irZ+h96PIBaxiNODI6GIbEk3GPShbNei7sB5dzEz9XGYdv6YePbWsdyGK+z043x2hgg jh9bvmNskaQbcG0pPORmoBQ9AKiQtR70OHzJjIHb/Esdpho2zphc/lp9tskoTNm/yCqA VjvZAiGQruw3WX3W1b1SMX8RNfBBBLHGdkEx00uNkOklyl9Y6qTN7/joi/LM3hW5VrRD svIVhtXui7ZiMeDx9lb+N4Z4xDsYIu7ihBb9iZ3cF6Pklj9HBnP9TABMRAIpAPXX6AZa 8bZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787657191; x=1788261991; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=n+tRyTnlpLmJp3+Wgs2dMuwtgQimEwJVqYrZ9xUm0L0=; b=hAt4WjDco4qtEXvxQTPHzEybmwGpIJg/BLwd7ySwNQux2h9Sue4+y5PzMb0+fyqBU7 kOcLZSqukWms5WP7HuF0jfwqOV+5xMBiSpTuj++EJiIrPeBhA2go0ywkAKP/81wR3o4Y S9/2eSYBYrRtjSvt++67Zngnj/bvLBGynPlvrF7QwTZ3SAs1D2/QUWir+42VSKFohNiC YRJ8dzKUA39V+u6Ee3LVoAeZdCTI0BaRCJEfV7kvczBdYThZKtnAHSTCqGAW+dWuKS+b klrqPg8JSCGFic7LZT5C3NAupVRZyTXXGI58Gd4LqkRnQDwxAQsyO+bFy8/nVuAQ3ygc Y54Q== X-Forwarded-Encrypted: i=1; AHgh+RqyO/aha4fx71+lIk9E3eAtr4HidEju2PVLo8XWDAsCLOEPgsJANgbU4rpm31oe4hAa/ox5wFDT2zgKc4Z6SQ==@lists.infradead.org X-Gm-Message-State: AFuF++ke/SCM6lRk1aC8NwDt+XPcKbMTNxEm933l94+5kBRQHkpBotD/ 11/NcghaL6JgNS7lKOtCf0acnTBDWyqcxtAPTURRC0EuM3BFGRAptKu5 X-Gm-Gg: AR+sD13ffZOdJ8RZZyORl2fs+DSZbfDX1ImGKYrgUk2rWPECmJOjdFZCZgALl5hHBpN bhcypYbIRXhLDwVG0k/7MR223znB4WWuyXWbchBWNgke82XZs3vr1WnNmQQCSJ317vqTvFjIjhg H4IG9QhlCI8nnZWXEd4iDSdPmr2MK3BO4a8BPjAO9gwI/DIoD9WzJKbFQdGfELZf0NToW5+pJ/c 8+UIeiw8FPtW9bG/jCOEDLGomyg7rsHO9BvZowlJZEvMql0ZtaoL7lMJNbmQBATPWLKAUi4pDx0 YD9LhjyVaojj5fvoAbqpJNTsY4XKUAMMcNuL28URSXsNPecRGBGSx1Gn4ahpipYi7dJS+cw4xqj Opf74JP1bgM/BjsJ0BjrR3qUATsGlwmVqY8vF7tFXwOlBzDA6h9OCQ/3D4G5sy/RFpusl+tln1q QKOxS+3CBkLrUsRWB8Zffu9I7YMRNEXdc0C0tGiPJnrTGEXZsJUN2JP2M2GanSEUrnHjK4SAspQ rOe5MKmXJytYMTxP8x13Mhgy2o= X-Received: by 2002:a17:90b:2ecb:b0:381:1f51:1ff0 with SMTP id 98e67ed59e1d1-396462b886dmr13579385a91.2.1787657191098; Tue, 25 Aug 2026 04:26:31 -0700 (PDT) Received: from KRHW1CJW23.bytedance.net ([203.208.189.10]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-327f909a51fsm32952386eec.4.2026.08.25.04.26.24 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 25 Aug 2026 04:26:30 -0700 (PDT) From: Zhao Li To: Felix Fietkau , Lorenzo Bianconi , Ryder Lee Cc: Shayne Chen , Sean Wang , Matthias Brugger , AngeloGioacchino Del Regno , Rex Lu , Peter Chiu , Chad Monroe , Howard Hsu , StanleyYP Wang , MeiChia Chiu , Bo Jiao , Evelyn Tsai , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, stable@vger.kernel.org Subject: [PATCH v2] wifi: mt76: mt7996: unlink TWT flow if the MCU rejects the agreement Date: Tue, 25 Aug 2026 19:26:20 +0800 Message-ID: <20260825112620.97568-1-enderaoelyther@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260729173632.14387-3-enderaoelyther@gmail.com> References: <20260729173632.14387-1-enderaoelyther@gmail.com> <20260729173632.14387-3-enderaoelyther@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260825_042632_741013_615DC2F8 X-CRM114-Status: GOOD ( 13.19 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org mt7996_mac_add_twt_setup() links a new flow into dev->twt_list before asking the MCU to add the agreement, but exits without unlinking the flow if the request fails. The flow-ID and table masks are only committed after MCU success, so the still-linked flow is invisible to the mask-gated teardown paths. If the station retries the setup, the same slot is cleared and its embedded list node reinitialized while it is still linked, corrupting dev->twt_list. If the station disassociates instead, teardown skips the flow and station storage can be freed while the node remains linked. A later scheduling or debugfs twt_stats walk can then dereference the freed flow, resulting in a use-after-free. Unlink the flow when the MCU rejects the agreement. This restores the list to its pre-request state while leaving the unchanged mask and agreement accounting untouched. Fixes: 98686cd21624 ("wifi: mt76: mt7996: add driver for MediaTek Wi-Fi 7 (802.11be) devices") Cc: stable@vger.kernel.org Link: https://lore.kernel.org/all/20260729173632.14387-3-enderaoelyther@gmail.com/ Assisted-by: Codex:gpt-5.6-sol Assisted-by: Kimi:K3 Signed-off-by: Zhao Li --- Changes in v2: - Rebase onto wireless/main commit 2812e64e1575. - Send mt7996 as a standalone patch; mt7915 is fixed by commit 16a04441eab0 ("wifi: mt76: mt7915: unlink TWT flow if the MCU rejects the agreement"). - Use list_del() to match the accepted mt7915 fix. --- drivers/net/wireless/mediatek/mt76/mt7996/mac.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/mediatek/mt76/mt7996/mac.c b/drivers/net/wireless/mediatek/mt76/mt7996/mac.c index 0eebc8182ca9..4d3829e4220d 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7996/mac.c +++ b/drivers/net/wireless/mediatek/mt76/mt7996/mac.c @@ -3207,8 +3207,10 @@ void mt7996_mac_add_twt_setup(struct ieee80211_hw *hw, flow->tsf = le64_to_cpu(twt_agrt->twt); if (mt7996_mcu_twt_agrt_update(dev, &msta->vif->deflink, flow, - MCU_TWT_AGRT_ADD)) + MCU_TWT_AGRT_ADD)) { + list_del(&flow->list); goto unlock; + } setup_cmd = TWT_SETUP_CMD_ACCEPT; dev->twt.table_mask |= BIT(table_id); -- 2.50.1 (Apple Git-155)