From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 35CB3C61DD6 for ; Tue, 1 Sep 2026 15:39:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=uKHgMtQputqbDhfus+bqWMYy0sB4+ucFHgWmr26Bs0M=; b=j9/wx/ifwWzw1Zlxyb0RP5IOYe PplyUjSSK0hqjHokW4WvddgLj6UnrdSD43MRkb8iuJJK362TPf4kP7m7osLd/53quwOxLG9Y0FM3w KjbTtFLWVSfspa7GozCv+cCOl5NE/iWHu5o7a95GBZiHKD6ybiAmyQtFYBTBmNo4kID2W/0Ty2j3W p309OjhetABJaDm4YtzcTk+ok6LkGUZmDQJ07A12s8VgLabZaajuJCcakq/LmYD19YJBUABAQ2mmq /o7FMnNmU5D4hTZ2iW0H9S/iAdymRd7Tm6xZvZdMfVifZgyA873NLypVp8+3BxINCmwybDe/h+4lP GcQCAbbA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x1QaS-0000000CXVk-1gI2; Tue, 01 Sep 2026 15:39:48 +0000 Received: from bali.collaboradmins.com ([2a01:4f8:201:9162::2]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x1QaK-0000000CX37-0wRL; Tue, 01 Sep 2026 15:39:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1788277178; bh=L2LyAjUUvnLIqA7nXO5wWmLeUrg9gPkR753DhuTI30Q=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=hrLXysCPMlAV8R7j9Cye1jpIziTg3QKWdTLDeCfG48Fa28i3Bgd+8U7DLVTSSuPQ7 ZJuTUJufqSRvnzn10I9ASvhv96zNOjiKLf0aibCnIJGcTceewCCGG/x4Gq/k6HL/yt eE2x3nSrHDQjoYkZ2Jmvq6jDp6crYxPR2RnDj3F7gYlKoJrvZrMTkHYNLZNuR7V4kT SyA1+gAjW1ZpsaMJpcgTAuMWtqSVIc8up0GzAEzoCdrAbIKt7O1DZnuWICmYDapCTh JpDcgWJdNYdQzowe1oReJBjFzvce6EJmxn8aTWfNkqNuXv+Q3Ezu+FA5cgB7zznmiT kri5U7twgvaag== Received: from yukiji.home (unknown [100.64.0.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: laeyraud) by bali.collaboradmins.com (Postfix) with ESMTPSA id 40E5317E07DB; Tue, 01 Sep 2026 17:39:37 +0200 (CEST) From: Louis-Alexis Eyraud Date: Tue, 01 Sep 2026 17:39:00 +0200 Subject: [PATCH v11 12/24] scsi: ufs: mediatek: Remove undocumented downstream reset cruft MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260901-mt8196-ufs-v11-12-dbd007704490@collabora.com> References: <20260901-mt8196-ufs-v11-0-dbd007704490@collabora.com> In-Reply-To: <20260901-mt8196-ufs-v11-0-dbd007704490@collabora.com> To: Chunfeng Yun , Vinod Koul , Neil Armstrong , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Peter Wang , Chaotian Jing , Alim Akhtar , Avri Altman , Bart Van Assche , Stanley Jhu , "James E.J. Bottomley" , Philipp Zabel , Liam Girdwood , Mark Brown , Manivannan Sadhasivam , "Martin K. Petersen" , "Martin K. Petersen" Cc: kernel@collabora.com, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Nicolas Frattaroli , Louis-Alexis Eyraud X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1788277163; l=2332; i=louisalexis.eyraud@collabora.com; s=20250113; h=from:subject:message-id; bh=CR34d5yfvMhIxYS7i9UAHVrLNZzMjtuLEbTpbPOFwr4=; b=X5NInAGQw5vfVBEKdDq2lPm18OVU7yOQdcFjgVf1bVLgFftzsA0PHrxblIs6v1Ws5UaAWmYVk oKWtf++OUuUA/DIXoEbR3Op/5IZ4XV02Fywm4DYU3KziEGzUAQk+hXi X-Developer-Key: i=louisalexis.eyraud@collabora.com; a=ed25519; pk=CHFBDB2Kqh4EHc6JIqFn69GhxJJAzc0Zr4e8QxtumuM= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260901_083940_489911_1AE072DA X-CRM114-Status: GOOD ( 14.92 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org From: Nicolas Frattaroli The MediaTek UFS host driver's probe function allows using a ti,syscon-reset as a reset, without going through the appropriate abstractions, or by documenting this in the binding at all. Remove this, it's downstream code and does not belong here. Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Nicolas Frattaroli Reviewed-by: Chaotian Jing Signed-off-by: Louis-Alexis Eyraud --- drivers/ufs/host/ufs-mediatek.c | 33 +++------------------------------ 1 file changed, 3 insertions(+), 30 deletions(-) diff --git a/drivers/ufs/host/ufs-mediatek.c b/drivers/ufs/host/ufs-mediatek.c index f61727879c3c..b01fc37bd259 100644 --- a/drivers/ufs/host/ufs-mediatek.c +++ b/drivers/ufs/host/ufs-mediatek.c @@ -2442,38 +2442,12 @@ MODULE_DEVICE_TABLE(of, ufs_mtk_of_match); static int ufs_mtk_probe(struct platform_device *pdev) { int err; - struct device *dev = &pdev->dev, *phy_dev = NULL; - struct device_node *reset_node, *phy_node = NULL; - struct platform_device *reset_pdev, *phy_pdev = NULL; - struct device_link *link; struct ufs_hba *hba; + struct platform_device *phy_pdev = NULL; + struct device *dev = &pdev->dev, *phy_dev = NULL; + struct device_node *phy_node = NULL; struct ufs_mtk_host *host; - reset_node = of_find_compatible_node(NULL, NULL, - "ti,syscon-reset"); - if (!reset_node) { - dev_notice(dev, "find ti,syscon-reset fail\n"); - goto skip_reset; - } - reset_pdev = of_find_device_by_node(reset_node); - if (!reset_pdev) { - dev_notice(dev, "find reset_pdev fail\n"); - goto skip_reset; - } - link = device_link_add(dev, &reset_pdev->dev, - DL_FLAG_AUTOPROBE_CONSUMER); - put_device(&reset_pdev->dev); - if (!link) { - dev_notice(dev, "add reset device_link fail\n"); - goto skip_reset; - } - /* supplier is not probed */ - if (link->status == DL_STATE_DORMANT) { - err = -EPROBE_DEFER; - goto out; - } - -skip_reset: /* find phy node */ phy_node = of_parse_phandle(dev->of_node, "phys", 0); @@ -2519,7 +2493,6 @@ static int ufs_mtk_probe(struct platform_device *pdev) out: of_node_put(phy_node); - of_node_put(reset_node); return err; } -- 2.55.0