From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7BEA9C624C6 for ; Tue, 1 Sep 2026 08:30:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:To:From:Reply-To: Cc:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=1bFwMN34t/laBcuJvUM/XSHQIvcTBfIZ9zeEVi8dxW8=; b=xc/DdXZY1whkbZMi6VZubSL8Sa bIlQspQoIkmavbmjBsXcck5TPM5DnjEneyc1VGYvHtABgRXpxHzUuvIhyzPNBXd65Ntj1riyLBOfX QXQIZxGzziDJdvZHOzbsM7nOkfW8ViueaORSz2n3R18858jLImA1zlgQr0d5IA1z8RyVsgypulvpo LMv2DzVDh8NVuPM4XXhLOCq/bIdW7+UfHbwF+u1hp0W3GWX7nnIpgsWGK36Dz2U9S/wlV3NUCw7dN M0BXFUBXp/iLDOBLxgg1KhUITbozxR66OxzIHNfH+kcwsNQqN9WKLSKN1ANA0JRRIaA7jT3gy0bmW 0JgI1PdQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x1JtE-0000000BH5v-0PwS; Tue, 01 Sep 2026 08:30:44 +0000 Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x1Jt8-0000000BGtq-3QlP for linux-mediatek@lists.infradead.org; Tue, 01 Sep 2026 08:30:42 +0000 Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-4998b5a63e2so6663115e9.1 for ; Tue, 01 Sep 2026 01:30:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788251437; x=1788856237; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to:content-type; bh=1bFwMN34t/laBcuJvUM/XSHQIvcTBfIZ9zeEVi8dxW8=; b=VKnd0wxlvuMV8K9aEJ6hoyGBnl7ddtp5a2JZdq8mTSSJ6uF6lzOuefcWiofkw8czVy H/bQ7UumCtslfHkWbX27POShiJPZghIA+e9Yc0bcvH0vNuzBA51xVvB4xNLlHiRWGSQi m0DUD+FqP2jOIXS/TJHpPdZf9VKEeVr8cb5k3O+u13h+IDmtxGuJDL9n1ARyBgp0yUr3 m/dCxIpwhzV1OFozmwv6VWHbEu5oR7Q8B+O7pv9Dujm4bJYyZHDerm17zk02XAviofPA /TGgk7KbgSIJXG3sMqFfYnA6qUFV85SM9cG5uDm4KYzwSE0yh2EfMs+kNjcU/wipZ9id /Llg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788251437; x=1788856237; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to:content-type; bh=1bFwMN34t/laBcuJvUM/XSHQIvcTBfIZ9zeEVi8dxW8=; b=fW+ETQz4xJckfjrory2vZTVF1uXuWc+3M/OrtFnEgWengSJlMvfUV37VPDaXaN4kuj hVvGuPx6ZGFIp93iPIBo7Hwtqfnq2Ifwa8XY9saKPEn/94cITkes2c1UFkNkMnXZb9+G Ks45aIzQ7aQoCkEgEdFiNEJV69jmnivOAhqWtt9lIk1GNgRHslTSLGxL26/fRnHRWkZj lfxXdsijq+2tLd7Fu38m48M5hRw1XhWUFVjflJiMXW5XHvAbmMjfj9kl/6MXovN5oYw1 Wr2Fzt6zMWwhfwF2G/uYfpLOBXRXkMPoBECLjA8msFw7whZL4gqCzlyigu+opt6pj0cw BXfQ== X-Forwarded-Encrypted: i=1; AHgh+RowG7Lmoe+KROPCgOE8zWpVmVLeSAAsXhEVP8f05j4E6mpECnCUJoGL0B80ZqXdzFsQWjJOTGpQRZC14xj5rw==@lists.infradead.org X-Gm-Message-State: AFuF++nh6mPM6zgysfBfEgLUImrWXTndXZ9Kyu3OrbQ+Z5s+jZJYfUap QdlINCjwbGlGJh/RIXa7M3Hl99cqY2pqf8y303Wn9JAC9S9hnIGV6ZQg X-Gm-Gg: AR+sD11rqeJoiCRt6DMuj6cdwDtG13zdlWIbo+wzpkPuKOdhy/v8bM1pRWRDayV253e 5GAthUL4fzSX1tuK5nsNvwcXpx0F7HJEw4nraZpiwDUgfGHSPdBMXczxg8TkN23oivNCgXM7bs2 ek5+MKTvqyNdYdG88qkhIeFPXPlj2qM7KDKEzeqDchuP+BdZpmdKHCU7myMnarRY/3lc0pMq54Y mjD13Ffuuo2xg7vetUN61Kj2PqivyiCBbTpK+/GSzlaGjoaxkudAgMk6XWOLn7+JjkxQOV9NJ7V EhJayV9tzR5A6P2FUi+5TqCxVRIZyso6P8KDGGxU8rvrdqeG6EJEU9pnPY5ePeDDr6HqDqrIFph 2w6cmh+YktWy/0tQ9g8kmouKoB+eSGahJ56y1ojcUdZ9dzA/5V9tt1fiWdfVhddukdoCiZAPZpl QTKJcs9GXCTuacyWiO4dsKbGmrF2R2cH9G2qI0VNfeJOpXq0tTPCCzTtPapWIbnwfLG5JQQ5L2Z 7aZeZBmIop7uiymdMi+cq4kb5AJVDnmZ7gSfKGX59Zn1L/DuRSb X-Received: by 2002:a05:600c:529a:b0:49c:cedc:3c36 with SMTP id 5b1f17b1804b1-49ccedc3cafmr333314475e9.16.1788251437016; Tue, 01 Sep 2026 01:30:37 -0700 (PDT) Received: from Ansuel-XPS24.localdomain (host-79-26-252-140.retail.telecomitalia.it. [79.26.252.140]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-49cdce08862sm51459635e9.1.2026.09.01.01.30.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Sep 2026 01:30:36 -0700 (PDT) From: Christian Marangi To: Maxime Chevallier , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Simon Horman , Jonathan Corbet , Shuah Khan , Randy Dunlap , Christian Marangi , Lorenzo Bianconi , Heiner Kallweit , Russell King , Philipp Zabel , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, llvm@lists.linux.dev Subject: [PATCH net-next v15 09/12] net: phylink: add .pcs_link_down PCS OP Date: Tue, 1 Sep 2026 10:29:24 +0200 Message-ID: <20260901083001.8044-10-ansuelsmth@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260901083001.8044-1-ansuelsmth@gmail.com> References: <20260901083001.8044-1-ansuelsmth@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260901_013038_936232_DB182E95 X-CRM114-Status: GOOD ( 15.15 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Permit for PCS driver to define specific operation to tear down the link between the MAC and the PCS. This might be needed for some PCS that reset counter or require special reset to correctly work if the link needs to be restored later. On phylink_link_down() call, the additional phylink_pcs_link_down() will be called after .mac_link_down to tear down the link. PCS driver will need to define .pcs_link_down to make use of this. Signed-off-by: Christian Marangi Reviewed-by: Maxime Chevallier --- drivers/net/phy/phylink.c | 9 +++++++++ include/linux/phylink.h | 12 ++++++++++++ 2 files changed, 21 insertions(+) diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c index a68d77ba5728..e5706b008b39 100644 --- a/drivers/net/phy/phylink.c +++ b/drivers/net/phy/phylink.c @@ -989,6 +989,12 @@ static void phylink_pcs_link_up(struct phylink_pcs *pcs, unsigned int neg_mode, pcs->ops->pcs_link_up(pcs, neg_mode, interface, speed, duplex); } +static void phylink_pcs_link_down(struct phylink_pcs *pcs) +{ + if (pcs && pcs->ops->pcs_link_down) + pcs->ops->pcs_link_down(pcs); +} + static void phylink_pcs_disable_eee(struct phylink_pcs *pcs) { if (pcs && pcs->ops->pcs_disable_eee) @@ -1701,6 +1707,9 @@ static void phylink_link_down(struct phylink *pl) pl->mac_ops->mac_link_down(pl->config, pl->act_link_an_mode, pl->cur_interface); + + phylink_pcs_link_down(pl->pcs); + phylink_info(pl, "Link is Down\n"); } diff --git a/include/linux/phylink.h b/include/linux/phylink.h index 2c647238c7ce..87dc0f27dfc0 100644 --- a/include/linux/phylink.h +++ b/include/linux/phylink.h @@ -528,6 +528,7 @@ struct phylink_pcs { * @pcs_an_restart: restart 802.3z BaseX autonegotiation. * @pcs_link_up: program the PCS for the resolved link configuration * (where necessary). + * @pcs_link_down: tear down link between MAC and PCS. * @pcs_disable_eee: optional notification to PCS that EEE has been disabled * at the MAC. * @pcs_enable_eee: optional notification to PCS that EEE will be enabled at @@ -555,6 +556,7 @@ struct phylink_pcs_ops { void (*pcs_an_restart)(struct phylink_pcs *pcs); void (*pcs_link_up)(struct phylink_pcs *pcs, unsigned int neg_mode, phy_interface_t interface, int speed, int duplex); + void (*pcs_link_down)(struct phylink_pcs *pcs); void (*pcs_disable_eee)(struct phylink_pcs *pcs); void (*pcs_enable_eee)(struct phylink_pcs *pcs); int (*pcs_pre_init)(struct phylink_pcs *pcs); @@ -690,6 +692,16 @@ void pcs_an_restart(struct phylink_pcs *pcs); void pcs_link_up(struct phylink_pcs *pcs, unsigned int neg_mode, phy_interface_t interface, int speed, int duplex); +/** + * pcs_link_down() - tear down link between MAC and PCS + * @pcs: a pointer to a &struct phylink_pcs. + * + * This call will be made just after mac_link_down() to inform the PCS the + * link has gone down. PCS should be configured to stop processing packets + * for transmission and reception. + */ +void pcs_link_down(struct phylink_pcs *pcs); + /** * pcs_disable_eee() - Disable EEE at the PCS * @pcs: a pointer to a &struct phylink_pcs -- 2.53.0