Linux-mediatek Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Junjie Cao <junjie.cao@intel.com>
To: Laxman Acharya Padhya <acharyalaxman8848@gmail.com>,
	Felix Fietkau <nbd@nbd.name>
Cc: Lorenzo Bianconi <lorenzo@kernel.org>,
	Ryder Lee <ryder.lee@mediatek.com>,
	Shayne Chen <shayne.chen@mediatek.com>,
	Sean Wang <sean.wang@mediatek.com>,
	Deren Wu <deren.wu@mediatek.com>,
	Ming Yen Hsieh <mingyen.hsieh@mediatek.com>,
	Mikhail Gavrilov <mikhail.v.gavrilov@gmail.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	stable@vger.kernel.org, linux-wireless@vger.kernel.org,
	linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] wifi: mt76: mt7921: skip unknown CLC firmware records
Date: Tue,  1 Sep 2026 22:27:57 +0800	[thread overview]
Message-ID: <20260901142757.422688-1-junjie.cao@intel.com> (raw)
In-Reply-To: <20260816174841.1918-1-acharyalaxman8848@gmail.com>

On Sun, 16 Aug 2026 23:33:40 +0545, Laxman Acharya Padhya wrote:
> Treat an out-of-range CLC index as newer firmware rather than a
> malformed image. linux-firmware 20260810 ships MT7922 records with
> idx 3, and rejecting them made mt7921e fail to probe.
[...]
> Fixes: 9417c5818a01 ("wifi: mt76: mt7921: validate CLC firmware records")

Reviewed-by: Junjie Cao <junjie.cao@intel.com>

This wants Cc: stable, and it must not reach stable after 9417c5818a01
does. That commit carries Fixes: 23bdc5d8cadf (2022) and is in v7.3-rc1,
so the Fixes-tag scan can pick it for every series with a three-entry
phy->clc[]; there this firmware then fails probe. Those trees today read
the idx 3 record past the array instead (UBSAN at mcu.c:474 on 7.1.12,
https://bugzilla.redhat.com/show_bug.cgi?id=2515420).

Greg: if 9417c5818a01 gets queued, please take the two together.

My Sep 1 patch duplicates this; withdrawn.


      parent reply	other threads:[~2026-09-01 14:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-10 18:54 [PATCH] wifi: mt76: mt7921: validate CLC firmware records Laxman Acharya Padhya
2026-08-16 13:23 ` Mikhail Gavrilov
2026-08-16 17:48 ` [PATCH] wifi: mt76: mt7921: skip unknown " Laxman Acharya Padhya
2026-08-17 20:16   ` Mikhail Gavrilov
2026-09-01 14:27   ` Junjie Cao [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260901142757.422688-1-junjie.cao@intel.com \
    --to=junjie.cao@intel.com \
    --cc=acharyalaxman8848@gmail.com \
    --cc=deren.wu@mediatek.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=lorenzo@kernel.org \
    --cc=mikhail.v.gavrilov@gmail.com \
    --cc=mingyen.hsieh@mediatek.com \
    --cc=nbd@nbd.name \
    --cc=ryder.lee@mediatek.com \
    --cc=sean.wang@mediatek.com \
    --cc=shayne.chen@mediatek.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox