Linux-mediatek Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Hans Buchheim <hbuchheim@gmail.com>
To: Eason Lai <eason.lai@mediatek.com>, linux-wireless@vger.kernel.org
Cc: Felix Fietkau <nbd@nbd.name>,
	Lorenzo Bianconi <lorenzo@kernel.org>,
	linux-mediatek@lists.infradead.org, kun.wu@mediatek.com,
	deren.wu@mediatek.com, Sean Wang <sean.wang@mediatek.com>,
	quan.zhou@mediatek.com, Ryder Lee <ryder.lee@mediatek.com>,
	leon.yen@mediatek.com, litien.chang@mediatek.com,
	jb.tsai@mediatek.com, Devin Wittmayer <lucid_duck@justthetip.ca>,
	stable@vger.kernel.org
Subject: Re: [PATCH v4 2/2] wifi: mt76: fix memory leak in USB TX path
Date: Tue,  1 Sep 2026 12:10:15 -0400	[thread overview]
Message-ID: <20260901161015.607195-1-hbuchheim@gmail.com> (raw)
In-Reply-To: <20260827083526.1621600-3-eason.lai@mediatek.com>

I tested this series on another mt7921u USB device and confirmed that it fixes the zero-length WNM-frame skb/socket-charge leak.

Hardware and software:

  x86_64
  Netgear USB 0846:9065, mt7921u
  Linux 7.1.9-arch1-2
  wpa_supplicant 2.12
  NetworkManager 1.58.1
  firmware HW/SW 0x8a108a10, WM build 20260224110949

I applied both v4 changes without semantic modification to the exact Linux 7.1.9 source and built the mt76 module set against matching Arch headers.

The reproducer used a nonblocking AF_PACKET/SOCK_DGRAM ETH_P_IP socket to send zero-byte payloads to the associated AP and sampled SIOCOUTQ after each send. This produces the same packet shape as wpa_supplicant's synthetic WNM keep-alive without using the supplicant's socket.

With the stock modules, eight sends returned success and SIOCOUTQ increased monotonically by 960 bytes per frame:

  960, 1920, 2880, 3840, 4800, 5760, 6720, 7680

With v4 applied, 500 identical frames paced 10 ms apart completed with SIOCOUTQ=0 on all 500 samples. Both the immediate and settled final values were zero. An additional unpaced burst created a temporary backlog that drained completely to zero in 1.35 seconds.

The link remained healthy after the test: 0% gateway and Internet packet loss, and no mt76 pending-TX timeout, firmware reset, warning, or error in the kernel log.

The reproducer and this report were prepared with assistance from OpenAI Codex using GPT-5.6 Sol at x-high reasoning effort. I reviewed the procedure and results and ran the tests on the hardware described above.

Tested-by: Hans Buchheim <hbuchheim@gmail.com>


      reply	other threads:[~2026-09-01 16:10 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-19  8:21 [PATCH v3 0/2] wifi: mt76: refine USB/SDIO TX path error handling Eason Lai
2026-08-19  8:21 ` [PATCH v3 1/2] wifi: mt76: mt792x: fix UAF in SDIO TX path when out of memory Eason Lai
2026-08-19  8:21 ` [PATCH v3 2/2] wifi: mt76: fix memory leak in USB TX path Eason Lai
2026-08-24 15:29 ` [PATCH v3 0/2] wifi: mt76: refine USB/SDIO TX path error handling Devin Wittmayer
2026-08-27  8:35 ` [PATCH v4 " Eason Lai
2026-08-27  8:35   ` [PATCH v4 1/2] wifi: mt76: mt792x: fix UAF in SDIO TX path when out of memory Eason Lai
2026-08-27  8:35   ` [PATCH v4 2/2] wifi: mt76: fix memory leak in USB TX path Eason Lai
2026-09-01 16:10     ` Hans Buchheim [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260901161015.607195-1-hbuchheim@gmail.com \
    --to=hbuchheim@gmail.com \
    --cc=deren.wu@mediatek.com \
    --cc=eason.lai@mediatek.com \
    --cc=jb.tsai@mediatek.com \
    --cc=kun.wu@mediatek.com \
    --cc=leon.yen@mediatek.com \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=litien.chang@mediatek.com \
    --cc=lorenzo@kernel.org \
    --cc=lucid_duck@justthetip.ca \
    --cc=nbd@nbd.name \
    --cc=quan.zhou@mediatek.com \
    --cc=ryder.lee@mediatek.com \
    --cc=sean.wang@mediatek.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox