From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 247FBC624D3 for ; Fri, 4 Sep 2026 17:58:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=rP0jvIe50D9VMNBI5Koq/QnFNW7rOKsTaV7j4xp9Y8U=; b=ifHb6WMB+C+fo8z7nT9hEg3bMM 1gBOZzKggSX2Bn+X8zme5HIZPAEPGNWGDGdhnCPE6A+EX9mIoZWVVemRgGTLBZMSaZIGQjYRm4MrU AzcgreFIyKpOcFn5+FWHnz0QiL/ucu2ObssfbyUssTgjWXJDDnb/5w6N2WimDl/0jlRhHIygy6Iva wnthU5cUtWYeyzZoQoXBRw+HttLjDdxaID1dWclTM+rtbZM7sFvYqxTmjNcUt5v6qxKvcJ2f4oZCI dROBDAiEIAAZyfMjCESQGwEQu+IyxIeOGBp7Ftc+HHYga32hUVu/ae5WzR+3aoBBiGH6hL8LjW5jB OCgGdSNA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x2YBH-00000002xNp-3jw6; Fri, 04 Sep 2026 17:58:27 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x2YBG-00000002xNC-1Lkc; Fri, 04 Sep 2026 17:58:26 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id AEF5E416A2; Fri, 4 Sep 2026 17:58:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A49421F00A3D; Fri, 4 Sep 2026 17:58:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1788544705; bh=rP0jvIe50D9VMNBI5Koq/QnFNW7rOKsTaV7j4xp9Y8U=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=vVcWPcqG1059ybsmrz21hgN6wQuwVgT6uzFHmLEnROtsmnN/CAYwVKSDtG9lGAiEU tkd1yZrHUaZHJ3eumLByHfJe9TNCknpujWUJKGpAWuMus+fTvh1G7TZqTS6TzxZoq+ MFxyhH9d1b8/dxyRr8Dhs80vd4pcoiD8qcdKqe90= Date: Fri, 4 Sep 2026 19:52:37 +0200 From: Greg Kroah-Hartman To: Chen-Yu Tsai Cc: Andy Shevchenko , Chen-Yu Tsai , Bartosz Golaszewski , Daniel Scally , Heikki Krogerus , Sakari Ailus , "Rafael J. Wysocki" , Danilo Krummrich , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Wei Deng , Konrad Dybcio , linux-acpi@vger.kernel.org, driver-core@lists.linux.dev, linux-pm@vger.kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Manivannan Sadhasivam , Alan Stern , Bartosz Golaszewski Subject: Re: [PATCH v8 07/16] usb: core: Move struct usb_port and related APIs to port.h Message-ID: <2026090433-chair-tidings-5c99@gregkh> References: <20260904084158.1341550-1-wenst@chromium.org> <20260904084158.1341550-8-wenst@chromium.org> <2026090430-botanist-ungodly-0299@gregkh> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Sat, Sep 05, 2026 at 01:24:20AM +0800, Chen-Yu Tsai wrote: > On Sat, Sep 5, 2026 at 12:47 AM Greg Kroah-Hartman > wrote: > > > > On Fri, Sep 04, 2026 at 04:41:46PM +0800, Chen-Yu Tsai wrote: > > > |struct usb_port| and its matching container_of() macro should live in > > > its own port.h, matching the split we have for .c files. > > > > Why? > > This was requested by Andy. And to me it sort of made sense. > > > > Move them as described. Also move usb_port_is_power_on(), since in the > > > next change its |struct usb_hub *| parameter will be changed to > > > |struct usb_port *|, and becomes a non-static function that only > > > references |struct usb_port|. > > > > No, please don't do that unless you have a really good reason. > > Which part? Move the code? Please don't make a new .h file. Moving the function might make sense on its own if you need it in a different file later on, but do a move only, and then change things if you really need to do that. thanks, greg k-h