From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6DD79C79F8C for ; Sun, 6 Sep 2026 06:03:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=NG+h0fEWkShkE2dq/JvgIwncxcSUVIaRrf1Kfa8GBLU=; b=DOd+ZBBzVAkniBf8fys9b+UeEV si5hnOJ9TKfXXRadEDqxUWIuwBz3QFyBARz/x7C7X8wZh4DtpT+RMr06ue3B+3PPZglF/ft+H4z97 cHdoSQRLlUoL78IKbEUlaVPOMaC6UDM0uxZlUhsD1DEWIANtoJaIu/You0wBzpZi0wI2Azl7JYUOf ask/pGOQlt8NlPVQAIyyppt8itPlsHIKK9z4OjNItzGjhySSblyp/A68UyoZUcrqJIo4kS3KUpIh8 4nKrKAwLwTevrTShX16z+iBb7g/Ce0zccpmgmyO/l73rziu85XEnCFZIBJ6K++RbOc1Tns79OS4Yv OSXVJRfg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x35yD-00000004jXi-2veL; Sun, 06 Sep 2026 06:03:13 +0000 Received: from mail-wr1-x430.google.com ([2a00:1450:4864:20::430]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x35yA-00000004jX0-2s1q for linux-mediatek@lists.infradead.org; Sun, 06 Sep 2026 06:03:12 +0000 Received: by mail-wr1-x430.google.com with SMTP id ffacd0b85a97d-48442ea8f59so2844620f8f.1 for ; Sat, 05 Sep 2026 23:03:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788674588; x=1789279388; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=NG+h0fEWkShkE2dq/JvgIwncxcSUVIaRrf1Kfa8GBLU=; b=HXSu1aDydnVyUeD+kHdcItbYz2WDrL6Xd7s72aAAidD0SMWYYI0c2M6mogEXraUGB+ fWFTCV7bBJkoOt5R0nvCmVgDlUoIoSbSe+cUId9h5JYAKZ4Vv44AhDTwlvlswhjxK4XB IGGhGzZb+DGGlwej9wFWa5bM+1tmYZ2njOuTuuHp5vbZTiNQ71JzNCuHapYGFTSnNZ6v pUN9NK5PHPgrbowJGk7N4zdReYSv0qlJq67Aez50bQP6pyIbdVPyeT/rqCmTWniu+Ro8 9GYF2WyyLB7e+PnWXiix0nNHcdrgh3ZvANiD41/pVnmsLsURY9tUmbk4PP1c93489YNE CUtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788674588; x=1789279388; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=NG+h0fEWkShkE2dq/JvgIwncxcSUVIaRrf1Kfa8GBLU=; b=EC15U1EEViYfl0s6eR+SyriGLbNzr9wwn4sa7iGOij8/Wk/yyiYSrKuB7+OngkD1C8 sI/V/joioc/xJMFg8fMQOA0LiG+60EykxCzTu1G/q6Q4E50o31YUp2HtggVhkE9FuqDM RuyX/tLWrX5+VDGYwgAf4NYx83YGUsvhBSJqqD3/O1fjhAEOvUIo0RdySXx3d/sBtwsB xBIaHwwHR7QjFwmNAKNxBC793/kES9IdyVGLgk2dfqq/B0uxOHuPrIu4fs/BOu9u07q6 QDbeizSGzsxtIZ/4tsqlRsW/8Fw3ShmFSgVyspQOvwG3CJ3PTiXZKBOoI9zXanPV5Yoi Zq7A== X-Forwarded-Encrypted: i=1; AKwUvByGE5dpQ2kkaCPSAp1UDGBm2L1dNDNcq7vOA185URbM7P0XOdKrUdqV0E2g0Nbn9WpigcMeTMBtRmToSoVQRQ==@lists.infradead.org X-Gm-Message-State: AFuF++lK8dm53XVkLxCUgNi73SCCXMWysxEZKG4UB8nxB6sNwza+0Ouy XkEdkDsPg5MgzmaUeEW42jG1Bbt5RJD65pvhjXgs9suPpux0Bz1u/3s= X-Gm-Gg: AYBFou3sjm3aIxUr4QM8874oQawbUu0G7tkmXYQ3xJWdeFX7oOpmp6QyBbU7qRJOIUn bCS7ZzvdB+Wp5o/M2KjPyl4s/pK5cAXr7QDXD/8jAFWdHZaPE41hinf6MfZm4/UpGM0KiEzA8/B WwZ2NI+edzGTOeKvlfAhG5giL3fGUDQAkmAnqoMTilr50iUS8lmvQkhfhRkak66cB2kOV51r+Fw CDEBgrO0SAEPW3LcBeUyLXnrhD68mp4mnJpVJ3d7RZd2VF3I2d3SpGBhvYyuMyjyFZG2l8b3x1X svX2jrGjbmZzzrf/FdlJeirK/fu/27RTSICDXBANBavW5EKyVieORUGB1DIeHZp6EALvhmrBNb7 8GpWQzG/mqjK7Hq35P/a+NhrMYbxQe2XOqMLbpDzHyhTa8ldXvoJT+3UUGHNsqqewUr5djXh+7t ERe/hlqWgJLj2aVldn7Ry3fJaQs0zAt4RzK9XC+sIKC+gcTUDw2tU= X-Received: by 2002:a05:600c:1d07:b0:49c:f13e:e4d with SMTP id 5b1f17b1804b1-49cf86f4fe4mr138838165e9.10.1788674588092; Sat, 05 Sep 2026 23:03:08 -0700 (PDT) Received: from fedora ([46.8.219.5]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49cee5f912esm298147805e9.4.2026.09.05.23.03.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 05 Sep 2026 23:03:07 -0700 (PDT) From: Vitaliy Sochnev To: Lorenzo Bianconi , netdev@vger.kernel.org Cc: upstream@airoha.com, Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Vitaliy Sochnev Subject: Re: net: airoha: RX rings below 32 descriptors let hw DMA past the ring Date: Sun, 6 Sep 2026 09:02:49 +0100 Message-ID: <20260906080249.944732-1-sochnev.v.74@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260906063750.719445-1-sochnev.v.74@gmail.com> References: <20260906063750.719445-1-sochnev.v.74@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260905_230310_743305_958B58E0 X-CRM114-Status: UNSURE ( 9.21 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Correction to the platform description, and a stronger dump. I wrote that the images "differ only in RX_DSCP_NUM(); no other patches". That was about the difference between my own images and is misleading as a description of the driver. The tree is OpenWrt's, and it carries an out-of-tree HW GRO patch that touches exactly the ring under test: AIROHA_RXQ_LRO_EN_MASK = GENMASK(7, 0) -> rings 0-7, including ring 4 For an LRO ring that patch sets buf_size to 16 KiB instead of PAGE_SIZE/2 and clears RX_RING_SG_EN_MASK, which mainline always sets. Both are plausibly relevant to a DMA overrun, so the result needed rechecking with that removed. To be precise about the base: it is 6.18.44 with the airoha RX path backported from mainline, including 269389ba5398 ("Set REG_RX_CPU_IDX() once in airoha_qdma_fill_rx_queue()") and bbfb1983944f ("Reserve RX headroom to avoid skb reallocation"), both in net today. The GRO patch is the only out-of-tree piece touching this path. Rechecked with its LRO mask zeroed, which restores page order 0, buf_size = PAGE_SIZE/2 and RX_RING_SG_EN - confirmed on the board by the posted buffer length dropping from 0x3E80 to 0x680. Everything reproduces: ring LRO panics overrun signature 16 on 3 (one with no load at all) present, 560 words 16 off 2 (one with no load at all) present, see below 32 on none 0 of 768 32 off none, 268 018 frames 0 of 768 128 on none 0 of 1024 128 off none, 273 921 frames 0 of 1024 The clean dump, ring 4 = 16, LRO off, taken while the ring was stalled. Descriptor 16 does not exist in a 16-entry ring: desc 15 (last real) desc 16 (past the end) +4 ctrl 0x80000156 +4 ctrl 0xC0000000 DONE|DROP, len 0 DONE, len 342 +8 addr 0x00000000 no buffer posted +20 msg1 0x2A5E0000 +16 msg0 0x00008000 +20 msg1 0x2A5E0000 +24 msg2 0x007F000E +28 msg3 0x0000FFFF msg0-msg3 are bit-identical to the dump taken with LRO on, so it is the same engine either way. addr = 0 explains DROP: hw ran past the posted descriptors, found no buffer in the next slot - a slot that is not part of the ring - and marked the completion dropped, but wrote the structure anyway. The panic in the ring 4 = 16, LRO off run landed in yet another place: nf_conntrack_hash_check_insert+0x480 [nf_conntrack] nf_conntrack_in / nf_hook_slow / __ip_local_out / udp_send_skb Comm: ntpd Five panics so far, in four distinct places, none of them networking: cpufreq's deferred work (__queue_work), the scheduler's load balancer (sched_balance_rq), the scheduler's stack-end check (twice), and conntrack's hash insert. Nothing else in the original mail changes.