From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4C987C79F9F for ; Thu, 10 Sep 2026 12:59:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=DlX7uEp+xJt+DRWD58MvDXb25/Cat7Ywclf9fNm7ioc=; b=HHlaeQ93WueOdVjmWts20IudcE qH95kGic9J58vacUXiSFnMyMEMdmpqSbbTkpQKmEnA6Uir0jhsRrwCOKx3c1HW0VpkOCmGjC/s/1T XpyJNOj5K5XbzjNQpZKZbgNQtKSuFKnu85PGrsde525SUHakxp+TxxwgnVCBYrEBqH2jVcCht+fTn eHOUrgWqnxlTjtvCeSUTj+18aYHuDBnTmedE2VqnVKHeTmnvFS6IFK/kSVzxjJ2+twt4lN54m0ZUS JSSHwIaiml4t8l2bNK+pekEDozJNAt44vskUrh/MRRxxx9F8nwu9ZOG2gKAESZFtb6hQ5pq90v8lC kg4Rjg6A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x4eMt-0000000EPGg-232v; Thu, 10 Sep 2026 12:59:07 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x4eMs-0000000EPDy-07Py for linux-mediatek@bombadil.infradead.org; Thu, 10 Sep 2026 12:59:06 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:MIME-Version :References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=DlX7uEp+xJt+DRWD58MvDXb25/Cat7Ywclf9fNm7ioc=; b=eMpyTJubvdvRwMAvBxhK6wQ4YW t+XEbyzGpGySbAIs1RvZTs/ZrOwxxMmprGqbrG47b87Qc5EXGwb3dZ3a2o4XS2oDoS7VlEaPMXWNp G6SRvTeLjYF0VcxERr2MZXRCPiukgeV9loJmTUVxC4gchkoLTpD5E6XTqHfWOMzgsuEwXpBerZhKG 3w0HdlelpYV9ASc0o4unpFVdyswtEki3tmszukGyHiMKb3rxQh4mwWlQH9eWlU1UST4+6oGwyha/V 0TFWX2WiHed/t7cxVZ7fNJLkJqz1iwH824Gd4tcerMcdc0HkNrIQ2bSjtpW6y44fU1XVOCawHLIjP V6lx5cnw==; Received: from mail-pj1-x1031.google.com ([2607:f8b0:4864:20::1031]) by desiato.infradead.org with esmtps (Exim 4.99.2 #2 (Red Hat Linux)) id 1x4eMo-00000002V80-3zAb for linux-mediatek@lists.infradead.org; Thu, 10 Sep 2026 12:59:04 +0000 Received: by mail-pj1-x1031.google.com with SMTP id 98e67ed59e1d1-3990fe066ebso5740099a91.1 for ; Thu, 10 Sep 2026 05:59:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789045141; x=1789649941; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=DlX7uEp+xJt+DRWD58MvDXb25/Cat7Ywclf9fNm7ioc=; b=XTyopBkuGV7LEOWTfsXjQFOGCsVAXHNb8fXx4Zg4h5jxhJ/n2DAaJsi7i6KA1W3kbl aZlnoIMNcfWc4CLtKTd9wWPWVbqoHRg0kFbcE5ftdRrb7USmE5b5zdKeFMuH9c3/4/yM /jW0nmIF7vsACLVUOVEoQxTX+nT+asW7JsEZt+kyiuE8aSwDW1Cw8eXYKeNDWFHsYbh1 vVDQJ4wV9RoFSwCJ6LjoZomwBEb33EDqbhLMGr82HNo/Dd33YSkwMnc+3yCYOtfMeowr b45oTashKIWTCdKhE57Q1ouqHjJFyDzsgumRZKNj1G3pe3q7Y1/RuCGdHDcArIFbntKg o23Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789045141; x=1789649941; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=DlX7uEp+xJt+DRWD58MvDXb25/Cat7Ywclf9fNm7ioc=; b=RKVon/ockrH44uWWds7wmvQKBduPaBn6L+N3FNdrZVVvb7ZD/mYJrThuF4swpghRDX 5mcoWEE2K17fZOXOvYAy+wJ5dH4MXdQtfmnjliM4Wp/obCnzVrwEy0iFi8vJ2fePjKuv 4GfPBYlE5dXt35gQH7HW6euAZuYTVyTZGabqH0u/wNlf/IpxlHSzahU31Fk0EX2QanAW GkbRM/1GiazqI8FV9B9wVw695RzSzNBsiyNiwo+d35IAfaINesoStLTOvXYFfV8suMrw rQOxP2cSsLEORtYLQs0n95LnA0b603wUxHgENr4uX6Z5HbMR8CuP8472tLFoAjkI8nu3 n3Sg== X-Forwarded-Encrypted: i=1; AKwUvBy7Mbnhg6yq9cAPfmLSI0hWLJ0tM4my1pLle56NEt9F3Px5i2payZRgcAf3//Z+AlUEOtUITc4D0JM4StKZ1w==@lists.infradead.org X-Gm-Message-State: AFuF++kpDTmir44dteR06/l5+z4Z+rlmI69cQ05bhqzgV/Y7jC4UK41v LY8XwlfwKHH5zyeJGjUeLTuaZg7Q3BjM3D9QdM9G2mVnD44UAyJ9xKzK X-Gm-Gg: AYBFou3UObKlWEIVeCxj83SVmR7bGfQjWq7tvDgahM5Hl62KEXPFTjggZ1TS4hQWkIG L9LwulSREmu6eUKzK5LU8Kusxspb6IYaKDWQFQFEG5PKDdBNWmELMxkLMXxssH4Wjq0jjE3PZxy 7tqZ9EI2puWtDsRrc7xRwdrz8QBTaP+I5orFPM9dWaNMfrm0sUfXDuunxM4+GuOCXww4K8QMBfu 17i0enOpIiLqZvrKLrwB3DAshXAe5E71HqO69I/dfJZxTPjgJuW7pMSn6mMGKKyt/m9KUSb+TDI 397ZaPs9oLh7Bvn9PTucuKFdfUF99H2+ToKk+bZXSAbbnDbw/6X2FlnBnEDo1PfuuMFLKm1MG1u 4P0D1iGhrHLdgo+Dl0X348g5J0Yv03ndQueBf2LJ6m5GkTNNc2M4ICm//9nc/EDvDfsZDY0TBpu jtlTFk+TaHix7PCQ2dJEAc15kxZ2iRR2ESZxxunYTZkuvDfp/iPTJMZkryzn6zbRPeyr0rqokiU ZgkmwbBwIg/qrqSxVazNEtBN1pxgv4N6cqp+dW9tv6gVeYX6LEFCXDAr3yl3PCie2nWPWxTpobb smrffm/Zfbt//xY= X-Received: by 2002:a17:90b:3a81:b0:398:c292:ac80 with SMTP id 98e67ed59e1d1-39b2612eaa4mr58543997a91.10.1789045140953; Thu, 10 Sep 2026 05:59:00 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39d7e77b1afsm4891592a91.5.2026.09.10.05.58.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Sep 2026 05:59:00 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , AngeloGioacchino Del Regno Cc: Liam Girdwood , Matthias Brugger , Jaroslav Kysela , Takashi Iwai , Cezary Rojewski , Cyril Chao , Kuninori Morimoto , Dan Carpenter , cassiogabrielcontato@gmail.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH 13/13] ASoC: mediatek: mt8189: Validate TDM MCLK frequency Date: Thu, 10 Sep 2026 19:57:42 +0700 Message-ID: <20260910125742.150902-14-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260910125742.150902-1-phucduc.bui@gmail.com> References: <20260910125742.150902-1-phucduc.bui@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260910_135903_099705_24B8D64B X-CRM114-Status: UNSURE ( 9.27 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org From: bui duc phuc mtk_dai_tdm_cal_mclk() accepts zero or negative frequencies. Reject invalid frequencies before configuring the TDM clock. Fixes: 9f202872ba04 ("ASoC: mediatek: mt8189: support TDM in platform driver") Signed-off-by: bui duc phuc --- sound/soc/mediatek/mt8189/mt8189-dai-tdm.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sound/soc/mediatek/mt8189/mt8189-dai-tdm.c b/sound/soc/mediatek/mt8189/mt8189-dai-tdm.c index 1b51027c6cf4..7748b4ff2c72 100644 --- a/sound/soc/mediatek/mt8189/mt8189-dai-tdm.c +++ b/sound/soc/mediatek/mt8189/mt8189-dai-tdm.c @@ -381,6 +381,9 @@ static int mtk_dai_tdm_cal_mclk(struct mtk_base_afe *afe, int apll; int apll_rate; + if (freq <= 0) + return -EINVAL; + apll = mt8189_get_apll_by_rate(afe, freq); apll_rate = mt8189_get_apll_rate(afe, apll); -- 2.43.0