From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 16FE9C982CC for ; Sat, 19 Sep 2026 23:54:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=W6XpYlqSAUDYu2tTQpZ6AxUTQ7zY6Z7lXw2iw401dcc=; b=cPEtf/+PHOloY4+LNlq27q0ctD 3zZhJrV3MsGH2QnmzQwxkJq8GCrAZeAv3tOJQsxg39Whxr+ju27jAwWj3Ls7VVwLb1g+m2nuqmuIB keLNpfA1U0M3wHMrO8ykQPZf5M0aSTEtkgGGrgw93pzz57jdyOs7izVTdggaNpaOk3dHep//pB3uD j0wlSqyvx0kY//Aed/KeHFMSYUDTVp696H44909TsJwJHTkO08hkuiW874iL+Ri6ySNRJnzjor6AO Nau7toZCnaKpKFGhIQJVabxx56m9yIUOWGOCw4e7K603V+LQOMuy4rqyHbn4G3yr390e4wk7p/H/y TU2xHnEg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x84tC-0000000GgSq-19d9; Sat, 19 Sep 2026 23:54:38 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x84tA-0000000GgSd-2nJX; Sat, 19 Sep 2026 23:54:36 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id EB0A943CB2; Sat, 19 Sep 2026 23:54:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2236B1F000FF; Sat, 19 Sep 2026 23:54:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1789862075; bh=W6XpYlqSAUDYu2tTQpZ6AxUTQ7zY6Z7lXw2iw401dcc=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=KxhccjP0SC+YfGESK9r7B0FuJgV1ssSOv0COhgDFitbx5+kSAHQCGivmtCi241izf 2gPqGwkJFD3iis9udq3WWFNG4k4P0EzXVFAvFzZSs+JeXCQbbMipg1zPPQAc8C8Xy9 Ni4Sr4ogrjCESZmJOd/kSjiSvrO2frcHSZHKgF7iOrAXfOuxtDMR4qQJ7JuSazEL/l YqaZ1wpr/Pwj62Ehq95XIH6W2xmmH7rrIUYt64I3+Nep2zkVbOadjl3OQXXWuW3zNY w+8oN2kW7Zuvpng0pF4wyP+0siJSgM5EWsmQctmDLCTSeI26THuE8shxcQG3GbAarS vKdpB9Ct8ePMg== Date: Sat, 19 Sep 2026 16:54:34 -0700 From: Jakub Kicinski To: Jack Wu via B4 Relay Cc: jackbb_wu@compal.com, Loic Poulain , Sergey Ryazanov , Johannes Berg , Andrew Lunn , "David S. Miller" , Eric Dumazet , Paolo Abeni , Wen-Zhi Huang , Shi-Wei Yeh , Minano Tseng , Matthias Brugger , AngeloGioacchino Del Regno , Simon Horman , Jonathan Corbet , Shuah Khan , Robert Yu , Jeff Chang , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-doc@vger.kernel.org Subject: Re: [PATCH v8 1/6] net: wwan: t9xx: Add PCIe core Message-ID: <20260919165434.08d026a8@kernel.org> In-Reply-To: <20260914-t9xx_driver_v1-v8-1-5206c2e6bea0@compal.com> References: <20260914-t9xx_driver_v1-v8-0-5206c2e6bea0@compal.com> <20260914-t9xx_driver_v1-v8-1-5206c2e6bea0@compal.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Mon, 14 Sep 2026 18:31:52 +0800 Jack Wu via B4 Relay wrote: > +struct mtk_dev_ops { > + u32 (*get_dev_state)(struct mtk_md_dev *mdev); > + void (*ack_dev_state)(struct mtk_md_dev *mdev, u32 state); > + u32 (*get_dev_cfg)(struct mtk_md_dev *mdev); > + int (*register_dev_evt)(struct mtk_md_dev *mdev, u32 dev_evt, > + int (*evt_cb)(u32 status, void *data), void *data); > + void (*unregister_dev_evt)(struct mtk_md_dev *mdev, u32 dev_evt); > + void (*mask_dev_evt)(struct mtk_md_dev *mdev, u32 dev_evt); > + void (*unmask_dev_evt)(struct mtk_md_dev *mdev, u32 dev_evt); > + void (*clear_dev_evt)(struct mtk_md_dev *mdev, u32 dev_evt); > + int (*send_dev_evt)(struct mtk_md_dev *mdev, u32 dev_evt); > +}; Please remove the abstractions which are not necessary in the initial version of the driver. If you have access to a good LLM these prompts will probably do a better job preparing the patches than you: https://github.com/kuba-moo/ai-prompts/blob/main/driver-upstreaming-prompts.md